From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64505373BE7 for ; Fri, 27 Mar 2026 11:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774611343; cv=none; b=kx1HWPupGZL/Xt14HnMF1gOtnvA9oiOfG8/ariVd8HWjbdIIYLoW8Hpf5kVuJUY3mampCgXnytF8KLlOCWdruSGVdLW1yixbMJCVx3Mq62Flf+KZh2486TxpbGbQBIubkDFot81vnh35x1EztjVX4MfKmCFRgT6i7r5UqLUbjC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774611343; c=relaxed/simple; bh=DyCUbqtppyHawVCYlxiZmA6NJ/eiCPE5Znidx3j35KM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ToVmLsX+Vx0+fGiwR1LCXVWhAwyS5Ien1chPs9AX+nwh2TjGc1/1rFzx3PgUt63Om3A0KLnudfYelpk6wFy1lxHugHvxnO1EdyYI9xoBSbUc9AicQC0QTHGSBEFBqxdPURM2l4jF1Dzh8ksAww0vGgBPPZXcFlRS70fSHQaBx90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cnCTSFZ8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aN11Aq8t; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cnCTSFZ8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aN11Aq8t" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R6wvlP2846497 for ; Fri, 27 Mar 2026 11:35:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 30ZC0GJstGxIxDb7g+6xkWIqpNTdQrufacREKq2etWY=; b=cnCTSFZ8JJcxYv3d JGcPi40ja7iPN672yEyDTRr8Gr1FN4QxhFrGT6Irr4tnsDsrOm4hIlnpYiwOuQs5 Pw7UdLw2PZAkow+2ddHo3/0hITA/zBRLvehrp6x7HCVKXPdPvhIeOPUwYagFbXZK KHrMpm0dJR9QzSYkN3KIHbS8y3xA0Q52Dou5aBubyf9qiXx42Jutf329qp7cvg5J Ly6l73zdPNAOqQdeC23+6rCITDOpCa4aUoIUeehjYRTKB2wiGI+6Pc48sS9FYNJe kDKNr9uhywsz1imwy9Ik86H4T0t6WhQwIfFFcFFtQjSQf2EMBtdf2cazgO5SbLi4 uwi1SQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d53eqmu63-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 11:35:41 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd8ea43d4eso44280785a.3 for ; Fri, 27 Mar 2026 04:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774611340; x=1775216140; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=30ZC0GJstGxIxDb7g+6xkWIqpNTdQrufacREKq2etWY=; b=aN11Aq8tovt/YAV4LQQRWvnXNMtR7IlLWpR4v/NtcsLZhfQT0eZ1trnCBJdBeL3fku Uxv8WoI2HVHljX9io8JX4qLTr/4yXL3AO/JZWbYoyhJHZfaCyZzv9+FycY2uFQT76hYz +zd69BWpF6CsUpkh71x5x36FETMVw+/PbxJNKlh5gYL/QIZqGaZwbECEuH1zgLSh0Hwa 80SeJkRLS8qRvhyOIQpYObKREMEbZzTSV3b6jlGd9yBQTSFvmUvLV9ELkMcR1vgqsao1 Uixhpplyw1dO2qzB4RiltCqIc3KTv6zVqJFV5FcKvnLgYFZlOL7HKmPkM4sjmbqHcNQk XBcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774611340; x=1775216140; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=30ZC0GJstGxIxDb7g+6xkWIqpNTdQrufacREKq2etWY=; b=MWfMJBeUfChrAYmyOVuXifLc0390JYanM2nKxbF/SkJ0ChxHdZGwuLY5G+z2Iiiruu 01zWZdyqTPkSqAjA4otOwQUyzhB4QpNlpeKbg6s+cm13l7RamIQw4ctyZkBh0YU5/K4r HnyYxVvd7WctrM2Ytfe2R54Sirm+SrXIlDHQ5YchD7TyJ+bR+lz3VYi3SulTKU1wN+ra 5J2tizlm+YY8yH84lxPS037nyVQKZxJifmjf1UCsZDgbsi121pctR6OihkLDdhdFFHFs WXOz757u1EfJhaKj5SSXVlOKtcc5f7mUvmlkGvX9MyyC2Kp7c6fRDRrSmXt/PTCSjiaP TJZA== X-Forwarded-Encrypted: i=1; AJvYcCWCu3gJM6bkaCrDV27VKt+YUcI7f5kf6NKCh57lfpIZQD6nXVrLs6pXYKwb+KC7bfuBTEiV+qAzUov6F2I=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkg3yiQG8wcG7oWHLRU8gXp6PUnZVRsl0OqpMPxq4nWYRTCDKB BoDiy4l/oBksWSD2Ksz3rOTL8ZMUvo0zv3EnuKJFdkwpVr/bp7ahwuZ9fOqr17DpfkPKK8IgYFA yjN5g8UCw0PBy7MqnawMJnrCAyb58E5tlT1HJMnI0teVkDZvNhwszm5bho4MOcBJ/0Gc= X-Gm-Gg: ATEYQzysPZmYLVLVU3wN+NR6bpgsqKqPbWDUC52jHKjVlSDLkq2nGBEki/+YH8D2DYK dI8/FNX36aiPR6BwYin6aNygcZ4knvre6UUuILde7CDjt+D2o7xMeJNC8dYtm91+gJxlZyZtWys dVjr382CIHDu65fXQ5sDvt/qoueX4j/Udfg4cOfI4DmVj1EJADdTI/GyNH2Oi3Nt1Fce52wlPqj B5NdB+fskjY1OQp9+v9rl4GSw1+FoL07FW8vNrnWyMrIwWfZhoPTXsnaKOff6i+DrtyU1IsSzhx xEjvrUBYQHt/dc4dKrr3dcXEtDpctwmAjghDy3JZ6pmpaLfG/Xw2YmdiDFMul0Q12fIiB1GqqdU PNRyFIsMDyAHO1meuspdOOWAS7OapbsMVmwEt6H5iMBRvwW6u8el0z/MKVTAzeAbomoT+pZAh3T +Jv78= X-Received: by 2002:a05:622a:5c0e:b0:509:e68:22cb with SMTP id d75a77b69052e-50ba394ce8cmr19051811cf.5.1774611340622; Fri, 27 Mar 2026 04:35:40 -0700 (PDT) X-Received: by 2002:a05:622a:5c0e:b0:509:e68:22cb with SMTP id d75a77b69052e-50ba394ce8cmr19051501cf.5.1774611340184; Fri, 27 Mar 2026 04:35:40 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66ad6751cc4sm2337139a12.18.2026.03.27.04.35.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 04:35:38 -0700 (PDT) Message-ID: <8114a15d-510d-498d-af79-a75493a8fc71@oss.qualcomm.com> Date: Fri, 27 Mar 2026 12:35:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/17] drm/msm/adreno: Coredump on GPU/GMU init failures To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> <20260327-a8xx-gpu-batch2-v2-8-2b53c38d2101@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260327-a8xx-gpu-batch2-v2-8-2b53c38d2101@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA4MCBTYWx0ZWRfX5my2SmE19Qo3 w/ZtpvWl2D0eMtPqyQWEAfI7IcwvM9wQGemCPNYrc8JuDqTDC98gy16WtkX+GC7dFMc0aYOuLsP RtT6lhGOCeYlHsxgih2b9m1B2I/t8Tz/0AXy33BBsUa3VVNuKHsXHWERpk2J6MF79LytGscpPyw fpx1q3OkyNrwfyoKqAZcysaFyNF2FFbLcp1oBhrv+SMTXjU3PdPk3wf8vhT3M67XMpiQpln7O26 Xo7U95/tQUsE3Ut72sEOxxbsqXVifbP2T8h2Q8GdCf1zqj+mlcT/LN2FhQUP//XNQRM+REEM6eV Ye3hjuPMGzkHnCWelrxvP2hKz0T/yRwo58ZR2lmLsNWxL3U6nHLGQZ9/LDJmxysmgewBl2TIYPU Y0Qtbeo0scoIPabwcjBghy52aHq7Y+MWZkUh+Ik45X0FD2p823UbV+tcrVTB3FbQkYfrQb/zE3f e6ioVrbRWvLKWK7RacQ== X-Proofpoint-GUID: 1jfQwlUuPmAXCio5q1Q5ZCSxFonztF8O X-Authority-Analysis: v=2.4 cv=S4bUAYsP c=1 sm=1 tr=0 ts=69c66b8d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=wHiI9OMDwfVBJI4OM5sA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 1jfQwlUuPmAXCio5q1Q5ZCSxFonztF8O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270080 On 3/27/26 1:13 AM, Akhil P Oommen wrote: > Capture coredump on GPU or GMU errors during initialization to help in > debugging the issues. To be consistent with the locks while calling > msm_gpu_crashstate_capture(), call pm_runtime_get(gpu) always with > msm_gpu->lock. > > Signed-off-by: Akhil P Oommen > --- [...] > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -391,10 +391,13 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx, > return 0; > case MSM_PARAM_TIMESTAMP: > if (adreno_gpu->funcs->get_timestamp) { > + mutex_lock(&gpu->lock); > pm_runtime_get_sync(&gpu->pdev->dev); > + > *value = adreno_gpu->funcs->get_timestamp(gpu); > - pm_runtime_put_autosuspend(&gpu->pdev->dev); > > + pm_runtime_put_autosuspend(&gpu->pdev->dev); > + mutex_unlock(&gpu->lock); This is something to take care of in a separate patch, but get_sync may fail and then the read could crash the device (GMU may be off too) put_autosuspend could theroetically fail too, but perhaps -edontcarethatmuch Konrad