From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 756B330FC23 for ; Wed, 4 Feb 2026 16:38:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770223122; cv=none; b=sYfK/oAnexGfLw/HA7/qNKHzKYKvNbrtCsiBbMDef2bN3Xi5eUbxbzgvbol+kj7ftV2TNpHMa6Fu5Enc0L4KINrHo63Kw2fajC/chrr9QMndO7F2alj91yNXM10e7usn14Jgk5Ni+4KKW8p1qIpKf/TKHuNkx4FmLr6gL2lZlkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770223122; c=relaxed/simple; bh=vzkmU/xUbgH8k9umSTYH1lGGxteiG1ygk3kWIhODUKM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qGuSpKlo0kcJxuGB9cRiY6EXKGNYSMcs9xI3pDB/OdzqIvnDehSg/OAqCN4FY/G6Xqf/GNEp0RffycGP0ZT6hgjqcRjjMKdvxS6l0CvFoHQekw7UazNsPoqlOUjYiSBAP9qE6HqckObrNfwag8CWRxxCzs9qLdP+SNeICoMGuPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DQK+SFru; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BiVh19d7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DQK+SFru"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BiVh19d7" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614EGc6U926598 for ; Wed, 4 Feb 2026 16:38:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jsCZryUoKWz/GFMWTjKZofaphaorw+gC2G7jmNnM19w=; b=DQK+SFruy/Ai18Sc koriq1TCz9tBsTm3DTH70Yuhm2nGvJ3g+mM1cQHasFg6+Mgn7WA7d6WbMjc3tYLx /PLGYhWCsMuVZU+gTviO95uM9zoqwXaTDdHBG3X6U9C+UANAg3NT/yn17AK6HusP v+68Vcd7v9ks9OOVf+bemnHPoIJJluZDsHlIhh0vDb7pPrGLVv2N6oDi6pXey5x4 JW2Yj5IgamAEJjo8nMJsPOU3GmpMv1jRiq4jPWke7G7lnbdXal7GbPnAGKgAZ17E UpK7DfHckY7owZqco2Yh9Ip8ryF0DCqqC1tLoJCIPB1uIPzPA0MVdh7Jjz/hpnJn lj+1CA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c47qv8g4h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 16:38:41 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8946c23cf90so81846d6.1 for ; Wed, 04 Feb 2026 08:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770223120; x=1770827920; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jsCZryUoKWz/GFMWTjKZofaphaorw+gC2G7jmNnM19w=; b=BiVh19d7rLeTa01Qyb6cgNRjGaiMAh+wKj1yM6petq3Juip7P39lgX5hhePwQBIIe5 0/ubkz8Wu4gyVRhDzS9H1c2C593erdnv1Bn7oXqKYZFTWyk9LaEQcGdRho0ElHe3QpIH z8c27IMIXEcdWHg0RzIHjOGN3pzvkvFv2/TRB7OjkNIXkbgKgvYl8RM5PAAPbSmjFoQI oocOiAa+xIBCM+d30tkV6yKmuFt3Snvex610jsYbnH0ym0XO30jZcHfCcyhrBjasw34t xV/0yHtICdmyaaTLqV0w2GRTDFkkts55++4Lm+cVJpXtDuNmuJ9jlGdQzUqYWUjyPaxm Yxsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770223120; x=1770827920; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jsCZryUoKWz/GFMWTjKZofaphaorw+gC2G7jmNnM19w=; b=mG76vpS84DqFDRWjXy99r8yaeXdK9GZeONU97NJh7go0OK+sGR3llteahhChhk/SWb 1/7v/bOpt0Rc2wltPD4pluNRm+HMzjKzkLcJeVsJDqRRRI2JQHDwAQZ0DtnAOqHKrC9D D2QNypMWtOWn7efjbRhYX2nrWJiRjq+4rPNg2AlRhcZAmOivaPVp8Xfzn7IhAjANt9lv 6lNuI73LmowAPYCwSh/Ew3/5MdbSQ4LCoBAarFLVk4PsRsLqGcdsRJUduqGNJCNo9Rdz +iiIZEPp6a+Mt8dabriwJpg7Ef2Xtf/in8QF7vW5bomcIJOl/QbcB9tvftJS365oN7e6 lbDA== X-Forwarded-Encrypted: i=1; AJvYcCUUdX5dGwtg11f9vOVw7ihJTh+NkNxq3lKxB7F8Ex1C/AldsnegNE1p04pAKq2iG1rq/7dzBpJjmVP8QW8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2FQexXEffQ0tSNpOfu5H+xe1ch6TaEIzzaP5mVVBqxVNnV9wU erC2nGtrNGPSOOsP8aW/LQisZLVFVnWveJXnZ13pT6IyzLKYAnulcXNIyW1Gb9sWwX5IVakQYWC 4hrUHVVL7IeH3H6dRpZPgz4igYctOjbYG6qR3B9f/Eks//oehnn5z5TdiBBCb5guy+DiZx1gEJI I= X-Gm-Gg: AZuq6aLv3uMESjHcPeoMO0mQ52ZFC84JqkpZwW1hIeknDBW9xQNkWPbpfhcBQs4RLeO swH8wmTMb0Sl+Je+81ED+lmyaPiZvEngBq8tNfuG7KHhTmsy2+tlRY+i49ZxToR7vAPPC3HJoAU tp2wersttOE0//smC5bYP5LDRz3by5OgannjpQZovpDTSx3mqgEzT4YldHDc6Pq07NCaGWq7Wtv +V6rtaBFefVHZKYjl9auTxjxJp5z/pMaCSWmEGispwN3GAcBdnLQwVgahWlpzjudBDYSJYueSgf dq+/bF/yusCf6xhoNQ6M4XHrZYeYTHEd+6siFDzJOtiH2of0yMWnfvqb2zRPUjtc8fZmqVJpHXJ a+xqbxTc9JkmYU4UHsFiypBgat5RbTDaxk4WtvRjvynqUw1hvnBqwkJz3WPeld6zmotU= X-Received: by 2002:a05:620a:468a:b0:8b2:e346:de7b with SMTP id af79cd13be357-8ca3303d992mr262612485a.1.1770223119750; Wed, 04 Feb 2026 08:38:39 -0800 (PST) X-Received: by 2002:a05:620a:468a:b0:8b2:e346:de7b with SMTP id af79cd13be357-8ca3303d992mr262608685a.1.1770223119258; Wed, 04 Feb 2026 08:38:39 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e9fd4a85asm138314366b.31.2026.02.04.08.38.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 08:38:38 -0800 (PST) Message-ID: <8119913b-c7bf-4de3-b731-dec128e65a7d@oss.qualcomm.com> Date: Wed, 4 Feb 2026 17:38:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] spi: geni-qcom: Improve target mode allocation by using proper allocation functions To: Praveen Talari , Mark Brown , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260204162854.1206323-1-praveen.talari@oss.qualcomm.com> <20260204162854.1206323-2-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260204162854.1206323-2-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GaEaXAXL c=1 sm=1 tr=0 ts=69837611 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=zEteQ-CndN1-B6i79MQA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: h_LzILp3UCIgkaKEl919llee1vTf0F_j X-Proofpoint-ORIG-GUID: h_LzILp3UCIgkaKEl919llee1vTf0F_j X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDEyNiBTYWx0ZWRfX22Q/SNvNrlDV /o9WX80Fr6wfAfEp6pY9H+9DmWqjeo4rYXDAceI+VzSSde5iIypZzbx2PsVdG0QE7joyPiZmvdg /pkr/91VYYDbtePNlFKpgp/AXzV3BQi9JsU6/wK+FGl76iIOUTYE6CPiJxFBMRsq6fjDEMkfisZ MzQcVoPo1bZuK247ipHd/nCmeWFX79jSb3Q0nXqUqc8+SFYUIh4JGY21fsI+Dsb8NJd/DguBRJi gqsjG/m0DCExvWaMwZqcHfYw4hDpxtNK5RKKx0e7NW3oVM2rXZ3BguWMyL3BpVa9zzW2hLIXBZe yUUo1jQYJkzPK00OzYNfqtjKHokKzmNPOzjG1/5WSdpelJggtH1+UKeejtxMswmXfEeRHBrxlGz R3dMeVAC+2kyJwIw6DVztMu/KIPU3GLmuYFLNxm19X1ulzjrM8rZw4fGXdh4N19WKoWEyk94ddB IqVMaHmO4srQ2f4bSLg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_05,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040126 On 2/4/26 5:28 PM, Praveen Talari wrote: > The current implementation always allocates a host controller and sets the > target flag later when the "spi-slave" device tree property is present. > This approach is suboptimal as it doesn't utilize the dedicated allocation > functions designed for target mode. > > Use devm_spi_alloc_target() when "spi-slave" device tree property is > present, otherwise use devm_spi_alloc_host(). This replaces the previous > approach of always allocating a host controller and setting target flag > later. > > Signed-off-by: Praveen Talari > --- Reviewed-by: Konrad Dybcio Konrad