From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B355F29B211 for ; Fri, 11 Apr 2025 12:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744373445; cv=none; b=XcYUEqkq6QiVn4uYhslFyjP1BuFzF7YnjXqji8DCNSlh6JCCLr1T2igiDc/A/c1U2P/0EjfrUlcT5CsiSlKkJLqZkxIBF8FbdcGgjOTh4bz5w+Rv7TtkDvb7BoDoTvZFYiVguLYJcYKQcdykijeg97VsKNNEk925P2rpiCyn95k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744373445; c=relaxed/simple; bh=dGHld92vUVbOFD/u6AtKaP9uEUe1RGPsRpaLDsrOO/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qrM4/fR6/w6tPAqd56dSIeGzH7lPITVMZO2hbAmDNA5OSSuMGs2gf+3XZ96ZDJLenPwh2qTyg0lgUvy2xzjHTiFVphFdCowKKk3jdQXIRFMMBA3aru7b02T37ywVeKFPB/XghOmn85wniIVGx7wU7TLpyyrTxe0XpmgKGUztHlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lz+qo4Gn; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lz+qo4Gn" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43d0359b1fcso13103125e9.0 for ; Fri, 11 Apr 2025 05:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744373441; x=1744978241; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/5LlnegqhXWYoYcLoLagqAZu+k870W60Ciw5agd+TQE=; b=lz+qo4Gn3kxsri5qolrG9V6egeFebKxqHNRtcxRp6fWCmzfW4FAoajq3UGpmgRgng/ 2DLUO1O+zTnXVHC9JjkzCEeQpRhlYw3itR8bft4dkKpWMmAz5AaFF5xIg/zdGdLYyO/+ IXKIZY9G0XYS8Gvkn7uXeWkGRY+2c11haossZo4tfkwEACVhjFgOZFgclUCwDf/aKERp bXTwwmq+Ivnhqj0vk7BWK8q6NuQqxglmoQdel0fvH24TrKVUDpN7/5oV0ejnadY/thc2 eFxrf9dgSXSui6Jnu1CCSVm6YB+dzUf/oJbMsaYtwga/yjf8dBWU0qdS7X8KY1t7r5ZU I+Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744373441; x=1744978241; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/5LlnegqhXWYoYcLoLagqAZu+k870W60Ciw5agd+TQE=; b=tPei6qi8IUAyaViZ5lON2mREuQr7GtkGsiatmSqXE5JDgNVE/267A4c+r/7+9Ij5PZ iVdYDMn6JQRKbTHsZY3BQ4LrfbFSpE66KJb9On1ywBsrIwNN++0q1zIWtmg64I1fyCtm gqueYdjLytPJTQS9z86wFY7svDC1gB+16iw6jS0sdmobt1A8p3v0jFRM3A2BJ4HSYK4a 0HBmsVyFjmKc1/d2WqzW8BJe8+dDHsfDikBwWr3jjYgbK3W3A7XzFidx0fabrQQrcniR Bs8KkO65VDPnN1AAItlRyR8i4FgLKLa2rVYnD/w+LWuErlJ2X1uAoOTWzApNOHPuIF4R WA3A== X-Forwarded-Encrypted: i=1; AJvYcCWaRWVYeSdBEpEMYx6lj/g3GKY3AxBXrCw8nlPAts2wHhnwrMVBavTJOtJkTuUtIZ4Frkei0sTavckJ/64=@vger.kernel.org X-Gm-Message-State: AOJu0YzGtoZAI4mKAAcR7+IiSxPTdyG4qhgA4vj7+XlN14CbcH+EXpXI ZLEStZVewOi+LDQ8Fn/rNAF5EyaoxFJ98kLglu6lf3iH+viWC6YvWa4WxyPdCxI= X-Gm-Gg: ASbGnct1dyNNsGocOm801TdQOMFkFxW9d3AJR1OJO8qhvSVDh+Q+mxMxZCsJxGA22gL 5k1Kcg6VVMaamVMghRD4EAL5an67GeC9xGI5NjlPt+QfZ5NQffSSCudbQQtvoy1/krNpRQzetw2 OCg5ywVFfaDC6BvfyPzWxOzIhqGIqOVP/jPRoFlz+7HhvsOc22IQjvRUN/mDO5C8p+6jBvBOU7x 3dYW1/sV5Zjwl5/smg7CzEuOYx1zh/KgYsSuMO3EtEYPfbs5g1YWSH9YylRKDk42zCOQkJ72NIl cnncMFS1j+oFvTlZudI3qRI07zyVgTeSxxT+fpNKMRHe/TY4FifyODvgh0jha+Evbywdg/j8vIs 7HsHlZg== X-Google-Smtp-Source: AGHT+IHlOq8/ca5REmCpBpkFoqbdN5SzfkW5Ay4uvrR7nOsyWNcTGKb621SxyZxe+WjLiuuz2iXeFA== X-Received: by 2002:a05:600c:4f50:b0:43c:ed33:a500 with SMTP id 5b1f17b1804b1-43f2eb51034mr62138375e9.10.1744373441065; Fri, 11 Apr 2025 05:10:41 -0700 (PDT) Received: from [192.168.0.34] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f233c817dsm80436805e9.23.2025.04.11.05.10.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 05:10:40 -0700 (PDT) Message-ID: <811cd70e-dc27-4ce0-b7da-296fa5926f90@linaro.org> Date: Fri, 11 Apr 2025 13:10:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/20] media: iris: Skip destroying internal buffer if not dequeued To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Stefan Schmidt , Hans Verkuil , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Dmitry Baryshkov , Neil Armstrong , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org References: <20250408-iris-dec-hevc-vp9-v1-0-acd258778bd6@quicinc.com> <20250408-iris-dec-hevc-vp9-v1-1-acd258778bd6@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250408-iris-dec-hevc-vp9-v1-1-acd258778bd6@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/04/2025 16:54, Dikshita Agarwal wrote: > Firmware might hold the DPB buffers for reference in case of sequence > change, so skip destroying buffers for which QUEUED flag is not removed. > > Cc: stable@vger.kernel.org > Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue internal buffers") > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c > index e5c5a564fcb8..75fe63cc2327 100644 > --- a/drivers/media/platform/qcom/iris/iris_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c > @@ -396,6 +396,13 @@ int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane) > for (i = 0; i < len; i++) { > buffers = &inst->buffers[internal_buf_type[i]]; > list_for_each_entry_safe(buf, next, &buffers->list, list) { > + /* > + * skip destroying internal(DPB) buffer if firmware > + * did not return it. > + */ > + if (buf->attr & BUF_ATTR_QUEUED) > + continue; > + > ret = iris_destroy_internal_buffer(inst, buf); > if (ret) > return ret; > iris_destroy_internal_buffers() is called from - iris_vdec_streamon_output - iris_venc_streamon_output - iris_close So if we skip releasing the buffer here, when will the memory be released ? Particularly the kfree() in iris_destroy_internal_buffer() ? iris_close -> iris_destroy_internal_buffers ! -> iris_destroy_buffer Is a leak right ? --- bod