mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "StDenis, Tom" <Tom.StDenis@amd.com>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"dave.hansen@intel.com" <dave.hansen@intel.com>,
	"luto@kernel.org" <luto@kernel.org>
Cc: "x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] x86/mm/cpa: Fix cpa-array TLB invalidation
Date: Fri, 30 Nov 2018 15:08:51 +0000	[thread overview]
Message-ID: <811e7759-40ab-a351-c538-c2b7bde49fd1@amd.com> (raw)
In-Reply-To: <BN6PR12MB180942F2C841FD138A046569F7D30@BN6PR12MB1809.namprd12.prod.outlook.com>

On 2018-11-30 10:07 a.m., Deucher, Alexander wrote:
> Sure, but it might be week or so.  For now can you test against Linus 
> master?  It should be close enough.

I need the bulk move from the our drm-next merge (which isn't yet 
upstream) to trigger the bug though.

I can try to cherry pick it on top of master.

Tom

> 
> 
> Alex
> 
> ------------------------------------------------------------------------
> *From:* StDenis, Tom
> *Sent:* Friday, November 30, 2018 9:52:26 AM
> *To:* Peter Zijlstra; dave.hansen@intel.com; luto@kernel.org
> *Cc:* x86@kernel.org; linux-kernel@vger.kernel.org; Deucher, Alexander
> *Subject:* Re: [PATCH 0/4] x86/mm/cpa: Fix cpa-array TLB invalidation
> Hi Peter,
> 
> Unfortunately I can't apply this on top of our drm-next the first patch
> fails.
> 
> Alex: could we rebase again at some point?
> 
> Tom
> 
> On 2018-11-30 8:44 a.m., Peter Zijlstra wrote:
>> Hi,
>> 
>> Yesterday Tom reported a CPA bug triggered by the AMDGPU team.
>> 
>> It turns out that with commit:
>> 
>>    a7295fd53c39 ("x86/mm/cpa: Use flush_tlb_kernel_range()")
>> 
>> I misread the cpa array code and messed up the TLB invalidations for it. These
>> patches (hopefully) fix the issue while also shrinking the CPA code again.
>> 
>> Tom, would you be so kind as to test again? These patches are significantly
>> different from what I send you yesterday.
>> 
>> ---
>> arch/x86/mm/mm_internal.h |   2 +
>> arch/x86/mm/pageattr.c    | 167 ++++++++++++++++++++--------------------------
>> arch/x86/mm/tlb.c         |   4 +-
>> 3 files changed, 79 insertions(+), 94 deletions(-)
>> 
> 


  parent reply	other threads:[~2018-11-30 15:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 13:44 Peter Zijlstra
2018-11-30 13:44 ` [PATCH 1/4] x86/mm/cpa: Add __cpa_addr() helper Peter Zijlstra
2018-11-30 13:44 ` [PATCH 2/4] x86/mm/cpa: Fix cpa_flush_array() Peter Zijlstra
2018-11-30 17:43   ` Dave Hansen
2018-11-30 13:44 ` [PATCH 3/4] x86/mm/cpa: Fold cpa_flush_range() and cpa_flush_array() Peter Zijlstra
2018-11-30 13:44 ` [PATCH 4/4] x86/mm/cpa: Better use clflushopt Peter Zijlstra
2018-11-30 14:52 ` [PATCH 0/4] x86/mm/cpa: Fix cpa-array TLB invalidation StDenis, Tom
     [not found]   ` <BN6PR12MB180942F2C841FD138A046569F7D30@BN6PR12MB1809.namprd12.prod.outlook.com>
2018-11-30 15:08     ` StDenis, Tom [this message]
2018-11-30 15:09   ` Peter Zijlstra
2018-11-30 15:10     ` StDenis, Tom
2018-11-30 15:14     ` StDenis, Tom
2018-11-30 15:23       ` Peter Zijlstra
2018-11-30 15:27         ` StDenis, Tom
2018-11-30 17:50           ` Peter Zijlstra
2018-11-30 15:31         ` Peter Zijlstra
2018-11-30 16:19           ` StDenis, Tom
2018-11-30 17:48             ` Peter Zijlstra
2018-11-30 17:49               ` StDenis, Tom
2018-11-30 18:06                 ` Peter Zijlstra
2018-12-03 15:41             ` Peter Zijlstra
2018-12-03 19:26               ` StDenis, Tom
2018-12-05 16:24                 ` StDenis, Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=811e7759-40ab-a351-c538-c2b7bde49fd1@amd.com \
    --to=tom.stdenis@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®