From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8D4C4332F for ; Thu, 21 Oct 2021 15:20:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01C6B611BD for ; Thu, 21 Oct 2021 15:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231845AbhJUPWp (ORCPT ); Thu, 21 Oct 2021 11:22:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25515 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbhJUPWk (ORCPT ); Thu, 21 Oct 2021 11:22:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634829624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NOe3cFJFILZdz8eTftQ7v5VvvEiNDk+j+1cks9VzhR8=; b=gSUpt0qVyEqu5fMwP4yRL/fyocdkTnasCkqYpPipU1lBSu6OjX5hGTfWFw6YLaF3sc3dIn FjHW+TPS5nrxUfJy7jwX9MtsX8bb3KKafxfrsdSMTpI9hrPLk/TBPsZuNgAUDE0il1g9gO dvsU1bcoleZjNRMMjly5HQPxULi42Co= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-513-MEapt5AzMD2k14tJyX8N7w-1; Thu, 21 Oct 2021 11:20:22 -0400 X-MC-Unique: MEapt5AzMD2k14tJyX8N7w-1 Received: by mail-ed1-f72.google.com with SMTP id d11-20020a50cd4b000000b003da63711a8aso664120edj.20 for ; Thu, 21 Oct 2021 08:20:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NOe3cFJFILZdz8eTftQ7v5VvvEiNDk+j+1cks9VzhR8=; b=eSZPW9cHO1yqwx3/g3bTFOfx7pcM0rQjmAdbA2E814HUhGDGt3ZYXXWkhmbStCtOu1 85u6MnjjRaSwGSqZgLrmhVLwWdpgfDBQbZvEJi7Klk5BZgUWNFVewHeK8K1WaWpZQMHt jENEJ1fZj9HxEyM5vXUUZJ8FX1EqPe89dw9ubvtZmpxAapAr+PVn+6dGe1Wq25Cv4VLm NDoqagJIn5v54RqIGXlNIW5GSOKN839cmvQVeuFKtk028t0sItOx/ZIcs2a2mCRbqk3x OtnYYq8VWjsvYR+dWNEWGoZTk5rk2pWiyCIHVlQqRl9ylyDLIdijSVJ3wlYf7GJN21aR tEfg== X-Gm-Message-State: AOAM531xEh2yo1ECyjZwpS98q6SS/x1jo2JZ9X9k/yd2t3kfci7oCp6c h3GsrkdSPPBZ3E98c1cXp62aFmEtiSz+HKTxBe7toMePfufVnydmzgl5hJPqlTwupd0orYmfqr0 ZKm9dzp9hLSDvhHcBEoMeXT17 X-Received: by 2002:a17:906:2310:: with SMTP id l16mr8121398eja.118.1634829621442; Thu, 21 Oct 2021 08:20:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjeZqyJXsmAoXhDVP1zKKfZ0Y7fUe4znDsFRJP/2IiYcz3JF2glaBceal0TUeS55/ECM+NVA== X-Received: by 2002:a17:906:2310:: with SMTP id l16mr8121368eja.118.1634829621264; Thu, 21 Oct 2021 08:20:21 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id a1sm3008008edu.43.2021.10.21.08.20.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Oct 2021 08:20:20 -0700 (PDT) Message-ID: <811ec8ba-433e-b167-6a60-cf3b5ceabb63@redhat.com> Date: Thu, 21 Oct 2021 17:20:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [RFC 01/16] KVM: selftests: move vm_phy_pages_alloc() earlier in file Content-Language: en-US To: Michael Roth , Mingwei Zhang Cc: linux-kselftest@vger.kernel.org, kvm , LKML , x86@kernel.org, Nathan Tempelman , Marc Orr , Steve Rutherford , Sean Christopherson , Brijesh Singh , Tom Lendacky , Varad Gautam , Shuah Khan , Vitaly Kuznetsov , David Woodhouse , Ricardo Koller , Jim Mattson , Wanpeng Li , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" References: <20211005234459.430873-1-michael.roth@amd.com> <20211005234459.430873-2-michael.roth@amd.com> <20211021034529.gwv3hz5xhomtvnu7@amd.com> From: Paolo Bonzini In-Reply-To: <20211021034529.gwv3hz5xhomtvnu7@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/10/21 05:45, Michael Roth wrote: >> Why move the function implementation? Maybe just adding a declaration >> at the top of kvm_util.c should suffice. > At least from working on other projects I'd gotten the impression that > forward function declarations should be avoided if they can be solved by > moving the function above the caller. Certainly don't mind taking your > suggestion and dropping this patch if that's not the case here though. I don't mind moving the code, so the patch is fine. Paolo