From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751519AbdJVKSY (ORCPT ); Sun, 22 Oct 2017 06:18:24 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:8971 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbdJVKSU (ORCPT ); Sun, 22 Oct 2017 06:18:20 -0400 Subject: Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type To: "Rafael J. Wysocki" CC: "Rafael J. Wysocki" , Borislav Petkov , "Len Brown" , Tyler Baicar , Will Deacon , Prarit Bhargava , "ACPI Devel Maling List" , Linux Kernel Mailing List References: <1508655253-20785-1-git-send-email-gengdongjiu@huawei.com> From: gengdongjiu Message-ID: <812042fc-bbf2-6bbb-8d5c-be32851005a1@huawei.com> Date: Sun, 22 Oct 2017 18:18:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.68.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.59EC7062.000C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e95cac386ac037b931fa8006998262e2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/10/22 17:38, Rafael J. Wysocki wrote: > On Sun, Oct 22, 2017 at 8:54 AM, Dongjiu Geng wrote: >> For the SEA notification, the two functions ghes_sea_add() and >> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA >> is defined. If not, it will return errors in the ghes_probe() >> and not continue. If the probe is failed, the ghes_sea_remove() >> also has no chance to be called. Hence, remove the unnecessary >> handling when CONFIG_ACPI_APEI_SEA is not defined. >> >> For the NMI notification, it has the same issue as SEA notification, >> so also remove the unused dead-code for it. >> >> Cc: Tyler Baicar >> Cc: James Morse >> Signed-off-by: Dongjiu Geng >> Tested-by: Tyler Baicar >> Reviewed-by: Borislav Petkov > I applied one of the previous iterations. > > Do I need to replace it with this version? Rafael, I checked your applying, your applying is right. so no need to replace. https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=3275fe60d1138e0cb57be9a3f46306b4d031c643 which is already "Reviewed-by: Borislav Petkov " Thanks >