From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8A2C433E3 for ; Fri, 24 Jul 2020 13:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 403DB2065F for ; Fri, 24 Jul 2020 13:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726686AbgGXNUy (ORCPT ); Fri, 24 Jul 2020 09:20:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:41322 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726182AbgGXNUx (ORCPT ); Fri, 24 Jul 2020 09:20:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 80F51AC66; Fri, 24 Jul 2020 13:21:00 +0000 (UTC) Subject: Re: [PATCH v2 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE" To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20200724124241.48208-1-roger.pau@citrix.com> <20200724124241.48208-4-roger.pau@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <81215bc0-6594-239a-9a27-0a3f1f43dfd6@suse.com> Date: Fri, 24 Jul 2020 15:20:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200724124241.48208-4-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.07.20 14:42, Roger Pau Monne wrote: > This reverts commit dfd74a1edfaba5864276a2859190a8d242d18952. > > This has been fixed by commit dca4436d1cf9e0d237c which added the out > of bounds check to __add_memory, so that trying to add blocks past > MAX_PHYSMEM_BITS will fail. > > Note the check in the Xen balloon driver was bogus anyway, as it > checked the start address of the resource, but it should instead test > the end address to assert the whole resource falls below > MAX_PHYSMEM_BITS. > > Signed-off-by: Roger Pau Monné Reviewed-by: Juergen Gross Juergen