From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968806AbdEWW3P (ORCPT ); Tue, 23 May 2017 18:29:15 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:50863 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031126AbdEWUMq (ORCPT ); Tue, 23 May 2017 16:12:46 -0400 Date: Tue, 23 May 2017 22:11:55 +0200 (CEST) From: Stefan Wahren To: Paul Gortmaker Cc: Linus Walleij , Scott Branden , Ray Jui , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, Florian Fainelli , linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jon Mason , Sherman Yin Message-ID: <812482107.237697.1495570315919@email.1und1.de> In-Reply-To: <20170522205648.23545-4-paul.gortmaker@windriver.com> References: <20170522205648.23545-1-paul.gortmaker@windriver.com> <20170522205648.23545-4-paul.gortmaker@windriver.com> Subject: Re: [PATCH 3/3] pinctrl: bcm: clean up modular vs. non-modular distinctions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.1-Rev34 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K0:OoMUanC0IEaA0DueH7OoHeNjWvKqXw05HrROcrvoQT9yor9nCFU LlnYunCwd6xZKuJ+uaNcc2y9DJWFgYag32g35l98o/MQfOlpuDMT5p7QbvtyAuo95PYSawI OFbWVLkx8dYbKBeX7PFNXUkwO23DPj8HBbTlTYuVVFXGPMLLEsdo//wu4nTlROmiIxiT+dK 0T5/usYyZT3BaKhUti/eA== X-UI-Out-Filterresults: notjunk:1;V01:K0:IVeGf9fjHgQ=:Vdc7EUEDzfCZpEdHZbhpoy knku93eMkskGAR9hK4G5Y/kMBqr0ukq27QUwFRS5A4vn/bqYM1Iw37E6Dsb8sUdqbWzrpH0K9 djvWzw2HeZDS+2Z0akuL/mB9xATjpNvoHBoZCibwxuPGrtu4GwyGmH3G5KP7yQWtHyR6phZTY O3CIMhxKDMkSvhO1Vuh40g1f0CKaDtVqDNbUyVc2AmVtMRL5u11wTh8BhZv+Hg0ew4njlqpbJ 6n+4DB4UE8J66girLAeUspRLDmEMIjcH7CnyQduQ5oyx4Mv0mL7QipvT7bS+vTejwKgZX4A7G JK3vg90+Z4ZzsCSLBqYYXhg/8X3dFL0sCthiz6eROFhZZWlvvEuVS2OzEg5F7J8oKEuBi6MEN 2tDFnD4YSw2FWA4M/WpEj7+ecDxOWw3jEVLJwwORnEssC6DlfKztOJq9EPUuThv2JUi53sr9Y CoP7UZirZEzcJgvfDKuXCMo+m6S32kfc7PkyA99S+PcLtDPdW6kSCQ482ecm8RsEYynOB4hOg a/cTUSiTphbJo81bl9GsnXEFeOc6pp/YAqyJLbD2ykyO4OAnJ2ugGIDKyuj9dEz6YKyPKR74P HI5BCtsyTxhElur9mipQW8Y8WSghIkCuRu1qvEI3AUln1Ysp4Bg0hyTV/yPcKuSgLa22+dBxS d7uGSWDzRw5kaSSBR17MP+pz5UbT52/R2Y1E9Czbwfw22qekH8Tu+bm+6lfKwDplT4ps1BbDH Io0wYKpfR37egJMX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Paul Gortmaker hat am 22. Mai 2017 um 22:56 geschrieben: > > > Fixups here tend to be more of a conglomerate of some of the other > repeated/systematic ones we've seen in the earlier pinctrl cleanups. > > We remove module.h from code that isn't doing anything modular at > all; if they have __init sections, then replace it with init.h > > One driver has a .remove that would be dispatched on module_exit, > and as that code is essentially orphaned, so we remove it. In case > anyone was previously doing the (pointless) unbind to get to that > function, we disable unbind for this one driver as well. > > A couple bool drivers (hence non-modular) are converted over to > to builtin_platform_driver(). > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Eric Anholt > Cc: Florian Fainelli > Cc: Jon Mason > Cc: Linus Walleij > Cc: Ray Jui > Cc: Scott Branden > Cc: Stefan Wahren > Cc: Sherman Yin > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-gpio@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker > --- > drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 16 ++++++++-------- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 20 +++----------------- Tested-by: Stefan Wahren for pinctrl-bcm2835