From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shazad Hussain <quic_shazhuss@quicinc.com>,
andersson@kernel.org, johan@kernel.org
Cc: bmasney@redhat.com, kernel test robot <lkp@intel.com>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] arm64: dts: qcom: sa8540p-ride: enable pcie2a node
Date: Tue, 13 Dec 2022 09:10:41 +0100 [thread overview]
Message-ID: <81265853-6705-861b-2ee5-32adf3c05341@linaro.org> (raw)
In-Reply-To: <09fbf4af-f1c6-828f-3ca6-3f06ff83b5ce@quicinc.com>
On 13/12/2022 09:05, Shazad Hussain wrote:
>
>
> On 12/13/2022 1:31 PM, Krzysztof Kozlowski wrote:
>> On 13/12/2022 06:11, Shazad Hussain wrote:
>>> Add the pcie2a, pcie2a_phy, and respective tlmm
>>> nodes that are needed to get pcie 2a controller
>>> enabled on Qdrive3.
>>>
>>> This patch enables 4GB 64bit memory space for
>>> PCIE_2A to have BAR allocations of 64bit pref mem
>>> needed on this Qdrive3 platform with dual SoCs
>>> for root port and switch NT-EP. Hence this ranges
>>> property is overridden in sa8540p-ride.dts only.
>>>
>>> Signed-off-by: Shazad Hussain <quic_shazhuss@quicinc.com>
>>> Reviewed-by: Brian Masney <bmasney@redhat.com>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> Drop, robot did not report this patch.
>>
>
> You mean I should keep only Kernel test as Reported by ?
No, I mean entire line should be removed. This robot did not report
missing feature/bug thus there is no credit for him for creating this patch.
>
>>> ---
>>> Changes since v3:
>>> - Fix syntax error and add Reported-by (Kernel test robot)
>>
>> So the previous patch was not even build... thus 100% not tested. Is
>> this one at least built?
>>
>
> I built that, but after running checkpatch with --fix, I think it
> dropped the closing brace of tlmm. My bad :|
Please do not send patches with checkpatch --fix, without prior testing
the patch. Not the code, but the patch. By testing patch I mean checking
different mainline branch, applying the mbox/patch (git am) and
comparing with git diff.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-13 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 5:11 Shazad Hussain
2022-12-13 8:01 ` Krzysztof Kozlowski
2022-12-13 8:05 ` Shazad Hussain
2022-12-13 8:10 ` Krzysztof Kozlowski [this message]
2022-12-13 8:19 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81265853-6705-861b-2ee5-32adf3c05341@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=quic_shazhuss@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®