mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Joel Slebodnick <jslebodn@redhat.com>, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, alim.akhtar@samsung.com,
	avri.altman@wdc.com, James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, peter.wang@mediatek.com,
	manivannan.sadhasivam@linaro.org, ahalaney@redhat.com,
	beanhuo@micron.com
Subject: Re: [PATCH] scsi: ufs: core: Free memory allocated for model before reinit
Date: Thu, 13 Jun 2024 12:15:34 -0700	[thread overview]
Message-ID: <812c519a-1a00-4ace-a0f7-d8c587f7e59f@acm.org> (raw)
In-Reply-To: <20240613182728.2521951-1-jslebodn@redhat.com>

On 6/13/24 11:27 AM, Joel Slebodnick wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 0cf07194bbe8..a0407b9213ca 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8787,6 +8787,7 @@ static int ufshcd_probe_hba(struct ufs_hba *hba, bool init_dev_params)
>   	    (hba->quirks & UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH)) {
>   		/* Reset the device and controller before doing reinit */
>   		ufshcd_device_reset(hba);
> +		ufs_put_device_desc(hba);
>   		ufshcd_hba_stop(hba);
>   		ufshcd_vops_reinit_notify(hba);
>   		ret = ufshcd_hba_enable(hba);

Please add Fixes: and Cc: stable tags. Otherwise this patch looks good to me.
Hence:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Thanks,

Bart.

  reply	other threads:[~2024-06-13 19:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13 18:27 Joel Slebodnick
2024-06-13 19:15 ` Bart Van Assche [this message]
2024-06-13 19:34 ` Andrew Halaney
2024-06-13 20:02 ` Joel Slebodnick
2024-06-14  6:27   ` Avri Altman
2024-06-14  6:30   ` Peter Wang (王信友)
2024-06-14  2:23 ` Martin K. Petersen
2024-06-14  8:28 ` Bean Huo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=812c519a-1a00-4ace-a0f7-d8c587f7e59f@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=ahalaney@redhat.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=jslebodn@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®