mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Matthew Ruffell <matthew.ruffell@canonical.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
	Jay Vosburgh <jay.vosburgh@canonical.com>,
	kengyu@lexical.tw, Brian Norris <briannorris@chromium.org>
Subject: Re: [PROBLEM] c5.metal on AWS fails to kexec after "PCI: Explicitly put devices into D0 when initializing"
Date: Tue, 24 Feb 2026 23:42:25 -0600	[thread overview]
Message-ID: <812e84da-6f6d-4600-8f75-f37757288fc8@amd.com> (raw)
In-Reply-To: <CAKAwkKu8wpdvJ2_gUWvNd+1ajU9CpbPpF-UsaGXkk6ciBgDT3w@mail.gmail.com>



On 2/24/2026 11:21 PM, Matthew Ruffell wrote:
> Hi Mario,
> 
>> Matthew,
>>
>> Can you please try with this diff that applies my idea?
>>
>> Thanks,
>>
>> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
>> index 1f6fd7c372932..5955a273c9ba7 100644
>> --- a/drivers/pci/pci.c
>> +++ b/drivers/pci/pci.c
>> @@ -3196,6 +3196,7 @@ void pci_pm_init(struct pci_dev *dev)
>>           }
>>
>>    poweron:
>> +       pci_clear_master(dev);
>>           pci_pm_power_up_and_verify_state(dev);
>>           pm_runtime_forbid(&dev->dev);
> 
> I applied this ontop of current head 7dff99b from 7.0-rc1.
> 
> c5.metal on AWS did not come back from a clean reboot. Looking at the serial
> console shows the exact same behaviour as attempting a kexec. It gets stuck
> trying to locate the rootfs, because the NVMe drive has no bus master bit set.
> 
> That is also maybe not a viable path to take.

OK thanks for checking it.

Could you figure out at which point it hangs?  What confuses me is why 
doesn't the call for pci_set_master() in nvme_pci_enable() help?


> 
> I'm currently working on some instrumentation, will try get my results,
> including a full dmesg capture, soon.
> 
> Thanks,
> Matthew

Could you specifically decorate the calls to nvme_pci_enable() to see if 
the hang is before or after that call to pci_set_master()?

  reply	other threads:[~2026-02-25  5:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19  3:52 Matthew Ruffell
2025-09-19  5:02 ` Mario Limonciello
2025-12-04  5:04   ` Matthew Ruffell
2025-12-04  5:29     ` Mario Limonciello
2025-12-05  3:06       ` Matthew Ruffell
2025-12-05  3:10         ` Matthew Ruffell
2025-12-05  5:31           ` Mario Limonciello
2026-01-06  6:06             ` Mario Limonciello
2026-02-13  5:54               ` Matthew Ruffell
2026-02-13 19:26                 ` Bjorn Helgaas
2026-02-17 14:36                   ` Mario Limonciello
2026-02-23  6:04                     ` Mario Limonciello
2026-02-25  5:21                       ` Matthew Ruffell
2026-02-25  5:42                         ` Mario Limonciello [this message]
2025-12-05  5:28         ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=812e84da-6f6d-4600-8f75-f37757288fc8@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=bhelgaas@google.com \
    --cc=briannorris@chromium.org \
    --cc=helgaas@kernel.org \
    --cc=jay.vosburgh@canonical.com \
    --cc=kengyu@lexical.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew.ruffell@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®