From: Vineet Gupta <vineet.gupta@linux.dev>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mhiramat@kernel.org, mark.rutland@arm.com,
mathieu.desnoyers@efficios.com, andrii@kernel.org,
peterz@infradead.org, linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
kernel-team@meta.com, stable@vger.kernel.org
Subject: Re: [PATCH v4 1/2] tracing: fgraph: allocate shadow stacks inline with GFP_NOWAIT
Date: Tue, 17 Nov 2026 16:00:21 -0800 [thread overview]
Message-ID: <8130b695-c281-46e9-bfdd-e4873046c36d@linux.dev> (raw)
In-Reply-To: <20261117185645.628de864@gandalf.local.home>
On 11/17/26 3:56 PM, Steven Rostedt wrote:
> On Wed, 21 Oct 2026 10:44:05 -0700
> Vineet Gupta <vineet.gupta@linux.dev> wrote:
>
>> smp_store_release() is a drop-in replacement for the smp_wmb() and
>> plain store it replaces.
> This should be added with that, but I can just add it as a separate patch.
Thx for that. Let me know if you need me to do anything.
-Vineet
>
> -- Steve
>
> diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
> index bbf6e4e2da2d..d32160a6b835 100644
> --- a/kernel/trace/fgraph.c
> +++ b/kernel/trace/fgraph.c
> @@ -568,7 +568,11 @@ ftrace_push_return_trace(unsigned long ret, unsigned long func,
> if (unlikely(ftrace_graph_is_dead()))
> return -EBUSY;
>
> - if (!current->ret_stack)
> + /*
> + * We must make sure the ret_stack is tested before we read
> + * anything else (See alloc_retstack_tasklist()).
> + */
> + if (!smp_load_acquire(¤t->ret_stack))
> return -EBUSY;
>
> BUILD_BUG_ON(SHADOW_STACK_SIZE % sizeof(long));
> @@ -576,12 +580,6 @@ ftrace_push_return_trace(unsigned long ret, unsigned long func,
> /* Set val to "reserved" with the delta to the new fgraph frame */
> val = (FGRAPH_TYPE_RESERVED << FGRAPH_TYPE_SHIFT) | FGRAPH_FRAME_OFFSET;
>
> - /*
> - * We must make sure the ret_stack is tested before we read
> - * anything else.
> - */
> - smp_rmb();
> -
> /*
> * Check if there's room on the shadow stack to fit a fraph frame
> * and a bitmap word.
next prev parent reply other threads:[~2026-11-18 0:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 17:44 [PATCH v4 0/2] tracing: fgraph: fix the quadratic shadow stack walk Vineet Gupta
2026-10-21 17:44 ` [PATCH v4 1/2] tracing: fgraph: allocate shadow stacks inline with GFP_NOWAIT Vineet Gupta
2026-10-23 18:13 ` Andrii Nakryiko
2026-10-23 18:38 ` Steven Rostedt
2026-10-23 20:13 ` Vineet Gupta
2026-10-23 22:09 ` Steven Rostedt
2026-10-23 22:25 ` Vineet Gupta
2026-11-08 23:12 ` Vineet Gupta
2026-11-09 7:28 ` Masami Hiramatsu (Google)
2026-11-17 23:56 ` Steven Rostedt
2026-11-18 0:00 ` Vineet Gupta [this message]
2026-10-21 17:44 ` [PATCH v4 2/2] tracing: fgraph: use scoped_guard() for the task list walk Vineet Gupta
2026-11-09 8:27 ` Masami Hiramatsu (Google)
2026-10-21 22:01 ` [PATCH v4 0/2] tracing: fgraph: fix the quadratic shadow stack walk Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8130b695-c281-46e9-bfdd-e4873046c36d@linux.dev \
--to=vineet.gupta@linux.dev \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®