From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E3B97080E for ; Mon, 19 May 2025 13:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747661336; cv=none; b=cMhsufOIECNq0glmU8dhcQoyWgm0z/RrI37Ki1fZFakZx7qcOgxrOl4TMVxqTNdHCcFlZcnUwnqmPKTHWjEGn9yVWbZBk7+fxsBZpfRYxzi8UuaLStnm1g3fkAIhV1twlpB67KAHzwudo5xcQcTEpnAJJuetH42CjVO5ULs0YoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747661336; c=relaxed/simple; bh=gaErXZom/SXbS7oWY3Y26Q3auH/Bb0Nnh+BmJjpjXnQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T7cYABXgCooVzdu2DuutyIxbF01zV1UxODwDWlhNQ6pH9E1vO6x/qzMaISf3fNKlRpR8Y/P+rUM5IwP22rkb70VWcmA2k81NwGanfbdYVWRChVJVIO1VLLmir7Tm9gil+AgHaUA2tjbANlExPSL5B6/i5jZV6nWLxs7OAzM4PKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=W036MQbW; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W036MQbW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747661332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LnZPk51OG5730zmFf6blk68sjraSbAgAbyfB3yfDnXw=; b=W036MQbW64V5XDFs8KbfhNqlesDvLNDcxUzwCbAF7ns675TC/lH89TJZirCZxwJNdRQnc0 piV6Ge0S7haVXX4XMcKW5nCW0VdTdr9amOSUO4ones3ehuznv1FE4v7RCZr3EH9fBT3eL+ FniZW1CDxsvKXRBtRxhuxDy9hRzmV1A= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-a-0Vy7MtN9ew-OiSGKxRtQ-1; Mon, 19 May 2025 09:28:50 -0400 X-MC-Unique: a-0Vy7MtN9ew-OiSGKxRtQ-1 X-Mimecast-MFC-AGG-ID: a-0Vy7MtN9ew-OiSGKxRtQ_1747661330 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-44059976a1fso19529265e9.1 for ; Mon, 19 May 2025 06:28:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747661329; x=1748266129; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LnZPk51OG5730zmFf6blk68sjraSbAgAbyfB3yfDnXw=; b=h6OPFTjhTuPG9W52sWAAtjZRPIJdGPFFC7wUBXOpG3IBC+B03GBQSUiUCMA2Ka+1qQ LqNTzQY+lRRk/ZU1b4gPAHpKf1Tq1fH99Z0UZpmDwrxFq5YPyy4hRDvF1DoKUwnp+OPv UNgFi2I825T3+xmdeBAvmEQLjTfDSNoVqY1JLGGQDRm+V0lpC6uDGNtXSt/3As/fxakV nxxh6pI2jqoDM5h5VUaxFzzL/8gADdasrgJ4tpQdcNGcQO8JHvjPBvu/KamYqWYyFBDv tAYtzX4vMhhYzi4kdVl/l8ObqmZub4f4HoR8fWsSmXB/L+z1klCYO/k9BaQIeUFRPxyf 8tDQ== X-Forwarded-Encrypted: i=1; AJvYcCWS2A1WM8xdSy0lLlfQihQ+OtyMSjldLRzk3plVtd7cM0o2UwZXY4CwD7oLl3jqiI8XnaIPhWvmIPhJIW0=@vger.kernel.org X-Gm-Message-State: AOJu0YxmTimI0kIi+YEnRGcMBVoraAtKf+CEBg/yZjud389oI3jPyF94 5bcMN3djzY2kHKdOuMFYEfSijYGUGyUfEWo7sbdCmMgVXy5KJMFJU7+NuCJcU9NpBMnjLlIthiT bBohFlPCuHWuAMQtNsf3adEmEGPu11u47zGDzYyytVIHGw2mck/8MS1kVNcZBa0e6hg== X-Gm-Gg: ASbGncvV7E+YT/Bpfdu82MiA4X/K/+nudw465tEcRumOIKLn1Qitjs43C0wXnmnuaLw /D/xlPmdPf2T322TYUfMuosExqXtn3vVN8ov4ikzhRg5Ev4psPnBo+S9fX9JzdXN/NMj5haMe4u XJqYvsudyBa5+3134pkTHE169dmh/WPT1gDVdBRZkwu6TTXpbJ8el3ocIX4EcTi/jLJGZOTDL6/ m6G3YCbGU1id5gqaSzNqFTlU8K+ZCYAb3dL11bCJFGrhHptPjNSHHwe7ELkNOd2aEoFGflGfkaw ygMj09xpz+l2BxMcKaQ3JOOfb4l1uF7/VdvUB75SCOc/1L+BAUmbDpg88Lzt5wKJ6l2eCxhElKS 0IF2cj1EPcsPh/9Kvz5yKnFIfpZKqu0hEdr/X8C0= X-Received: by 2002:a05:600c:c0da:b0:43d:ed:ad07 with SMTP id 5b1f17b1804b1-442fe667ec9mr98110445e9.29.1747661329563; Mon, 19 May 2025 06:28:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGv/14e2S6T0zf4P7jwon6xq8VRpY0NANQiw20OZzdDZ81YY+TIomD54n5XNTVyMN7y1wWMJw== X-Received: by 2002:a05:600c:c0da:b0:43d:ed:ad07 with SMTP id 5b1f17b1804b1-442fe667ec9mr98110265e9.29.1747661329140; Mon, 19 May 2025 06:28:49 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442fd583f71sm136833005e9.27.2025.05.19.06.28.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 06:28:48 -0700 (PDT) Message-ID: <8131ce62-0cee-455f-9eeb-e2bbed244402@redhat.com> Date: Mon, 19 May 2025 15:28:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm To: Mark Brown Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org> <58dbef73-6e37-46de-9092-365456306b27@redhat.com> <46d151d7-c04b-4538-9725-dc4f46ac8ac1@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16.05.25 20:07, Mark Brown wrote: > On Fri, May 16, 2025 at 04:12:08PM +0200, David Hildenbrand wrote: >> On 16.05.25 15:09, Mark Brown wrote: > >>>> I'm afraid we have other such tests that report duplicate conditions. cow.c >>>> is likely another candidate (written by me ;) ). > >>> That one's not come up for me (this was one of four different patches >>> for mm selftests I sent the other day cleaning up duplicate test names). > >> $ sudo ./cow > > ... > >> 1..778 >> # [INFO] Anonymous memory tests in private mappings >> # [RUN] Basic COW after fork() ... with base page >> ok 1 No leak from parent into child >> # [RUN] Basic COW after fork() ... with swapped out base page >> ok 2 No leak from parent into child > >> Aren't the duplicate "No leak from parent into child" the problematic bits? >> But maybe I am getting it wrong, what needs to be "unique" :) > > Ah, yes - that's got the same issue. I'm not running that program one > way or another, it's not immediately clear to me why not - I can't see > any sign of it being invoked by the runner script but I also can't see > anything that I'd expect to stop that happening. I'll have to have a > poke at it, thanks for flagging that. > > [Converting to kselftet_harness] >>> That'd certainly work, though doing that is more surgery on the test >>> than I personally have the time/enthusiasm for right now. > >> Same over here. > >> But probably if we touch it, we should just clean it up right away. Well, >> if we decide that that is the right cleanup. (you mention something like that >> in your patch description :) > > OTOH there's something to be said for just making incremental > improvements in the tests where we can, they tend not to get huge > amounts of love in general which means perfect can very much be the > enemy of good. If there's some immediate prospect of someone doing a > bigger refactoring then that'd be amazing, but if not then it seems > useful to make things play better with the automation for now. I would agree if it would be a handful of small changes. But here we are already at 1 file changed, 107 insertions(+), 56 deletions(-) -- Cheers, David / dhildenb