From: "André Almeida" <andrealmeid@igalia.com>
To: Stefan Binding <sbinding@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v1] ASoC: cs35l41: Fix acpi_device_hid() not found
Date: Mon, 10 Feb 2025 13:54:21 -0300 [thread overview]
Message-ID: <8132a592-3e29-485b-9b24-b70ddf819ff9@igalia.com> (raw)
In-Reply-To: <20250210163256.1722350-1-sbinding@opensource.cirrus.com>
On 2/10/25 17:32, Stefan Binding wrote:
> Function acpi_device_hid() is only defined if CONFIG_ACPI is set.
> Use #ifdef CONFIG_ACPI to ensure that cs35l41 driver only calls this
> function is CONFIG_ACPI is define.
>
> Fixes: 1d44a30ae3f9 ("ASoC: cs35l41: Fallback to using HID for system_name if no SUB is available")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502090100.SbXmGFqs-lkp@intel.com/
>
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
>
Reviewed-by: André Almeida <andrealmeid@igalia.com>
next prev parent reply other threads:[~2025-02-10 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 16:32 Stefan Binding
2025-02-10 16:54 ` André Almeida [this message]
2025-02-10 18:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8132a592-3e29-485b-9b24-b70ddf819ff9@igalia.com \
--to=andrealmeid@igalia.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lkp@intel.com \
--cc=patches@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®