From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946AbcDUKRu (ORCPT ); Thu, 21 Apr 2016 06:17:50 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:64152 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751594AbcDUKRs (ORCPT ); Thu, 21 Apr 2016 06:17:48 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Viresh Kumar , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Rafael Wysocki , linux-kernel@vger.kernel.org, Sascha Hauer , arnd.bergmann@linaro.org, Shawn Guo Subject: Re: [PATCH 2/8] cpufreq: imx: Use generic platdev driver Date: Thu, 21 Apr 2016 12:17:07 +0200 Message-ID: <8137134.6Dsv9n3KFK@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160421095032.GD29799@vireshk-i7> References: <18756925.NSB5aJaqC9@wuerfel> <20160421095032.GD29799@vireshk-i7> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Fkeahxak7sAIfVM3NbaUZe1CkCboqrA+CGZ5ACtSqcRMpk5EQGg zF1cc2wdzU+8xuVnd8/G0UJIWYR6K58pswdwWEi5DPS8B/bwJ3Mua3LHRco1/Rt7CrUNikQ AA7Qz3e43mCyiauLgECq12EJ97U3JBXtg+HnZ9AGFgqK9icdY4oYzsFm3w8FypIiZf2x6Gu Qpl1xDGAJsQKLOhRNJvAQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:3dy09KSzhK8=:K60JvRlfwW990WMuyZ5/jW 11uAp0BSbdhlFBbAAprEQTv+sxwfx7kRcYM05qChfWv8izgv02mXIP2qKhVZP02iyKk6CdVck Ldvf148Sbw6LLB+KqsvkCpFiNoJAHibLWnVizOfm5n3/mvbe0Im8YbOfkJ7WiG3CQoOzuoMS3 9K5qTKuHRYzOkutxpnXMsQG5ws6hv6XZomZzgajAIbFP9bvzaRT23mlNU6diTq7ZXtFALI6g8 dZ1YhT2qe9ePtXG32Eak/TClC0eOLsovQ4ANAgIwQKyOT5ccndQqsGKAaqKqPEkw6z38U9aiZ itj58YM99C4YD4kdeD0VIwqt83/x4hPp7+tYV60keqMrq+pvxx55JdqMS39CmY6jQmsrL2Yqc yy6gAlT5dHMU/nMv9joffnOyvBrnBsAUbKEbQT54NRI+fwXIZ2RoTBVYcFhPeGy54hMfQxV1V wZ/Rn15LFnTmQsJSh+uubNGyYhsoB7yxY6ubZlG6ujqzliE06fvygkUK2GDLa/rjzgTmjjcYB vE3RHt7gFvafIRTdBELqB6YRdGNj6j6zATLAVcPn5cA6qYa41qCGhKfKulIL4eq4YLS0Iks4D aw47WHEXU+hR/c8uUzZ4NAWc9qsYn1Wmk+/pqdxwNS5JbYXOTGFJ+qMucVf5xjekrC60XyWsT Zdoe/1nYmnz3egr/pp+5kQucFtd0Yf9xLDbGdp4WFOdkY+PnlU1JqaqREIJt1sJ3BUtOO9Czf lXEOz9au2qCXJ4V+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 21 April 2016 15:20:32 Viresh Kumar wrote: > > > diff --git a/arch/arm/mach-imx/imx27-dt.c b/arch/arm/mach-imx/imx27-dt.c > > > index bd42d1bd10af..90c62bf01f9e 100644 > > > --- a/arch/arm/mach-imx/imx27-dt.c > > > +++ b/arch/arm/mach-imx/imx27-dt.c > > > @@ -20,11 +20,7 @@ > > > > > > static void __init imx27_dt_init(void) > > > { > > > - struct platform_device_info devinfo = { .name = "cpufreq-dt", }; > > > - > > > of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > > > - > > > - platform_device_register_full(&devinfo); > > > } > > > > > > > Please remove the entire function now, a NULL .init_machine machine > > callback pointer has the same effect as the remaining line. > > > > The rest of the patch is fine. > > Perhaps that should be done in a separate patch I feel. Will do so after this is > merged. > I would do it in the same patch, just like you remove some of the .init_late() callbacks elsewhere, but it clearly works either way, so do as you like unless Shawn or Sascha have a strong opinion on the matter. Arnd