mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Question regarding MAX_ARG_STRLEN with execve()
Date: Fri, 30 Jun 2017 11:59:37 +0530	[thread overview]
Message-ID: <8138c533-dae2-6a6a-fabd-d090b72d4d99@linux.vnet.ibm.com> (raw)

Hello,

execve() system call should support argument length of
MAX_ARG_STRLEN (PAGE_SIZE * 32). On 64K page size systems, we
are not able to pass 32 * PAGE_SIZE arguments into the execve()
system call because of the following reasons.

* struct linux_binprm's vma starts with a size of PAGE_SIZE

	vma->vm_end = STACK_TOP_MAX;
	vma->vm_start = vma->vm_end - PAGE_SIZE;

* The VMA expands as much depending upon the argument size. So
  for 32 * PAGE_SIZE argument, it becomes 33 * PAGE_SIZE.

* 33 * PAGE_SIZE with 64K pages fails the following test in
  get_arg_page() function. 33 * PAGE_SIZE is more than 2MB
  (8 MB /4) with 64K page size.

   if (size > READ_ONCE(rlim[RLIMIT_STACK].rlim_cur) / 4)

* Right now RLIMIT_STACK is hard coded 8MB which does not take
  PAGE_SIZE into account. 

Wondering what should be the solution for this problem ?

* Change the default stack size from 8MB ?
* Change the ratio test from 1/4th ?

Thoughts ?

Regards
Anshuman

             reply	other threads:[~2017-06-30  6:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30  6:29 Anshuman Khandual [this message]
2017-06-30 14:22 ` Michal Hocko
2017-07-03  8:28   ` Anshuman Khandual
2017-07-03  9:21     ` Michal Hocko
2017-07-04 11:06       ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8138c533-dae2-6a6a-fabd-d090b72d4d99@linux.vnet.ibm.com \
    --to=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®