From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753648AbdGSNR5 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Jul 2017 09:17:57 -0400
Received: from mx2.suse.de ([195.135.220.15]:54845 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1753189AbdGSNR4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Jul 2017 09:17:56 -0400
Subject: Re: [PATCH] xen: xen-pciback: remove DRIVER_ATTR() usage
To: Greg KH <gregkh@linuxfoundation.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20170719125817.GD17776@kroah.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <813c3691-d8d0-28f0-6f49-c2b450a07c42@suse.com>
Date: Wed, 19 Jul 2017 15:17:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170719125817.GD17776@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19/07/17 14:58, Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> It's better to be explicit and use the DRIVER_ATTR_RW() and
> DRIVER_ATTR_RO() macros when defining a driver's sysfs file.
> 
> Bonus is this fixes up a checkpatch.pl warning.
> 
> This is part of a series to drop DRIVER_ATTR() from the tree entirely.
> 
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> ---
>  drivers/xen/xen-pciback/pci_stub.c |   44 ++++++++++++++++---------------------
>  1 file changed, 20 insertions(+), 24 deletions(-)
> 
> 
> --- a/drivers/xen/xen-pciback/pci_stub.c
> +++ b/drivers/xen/xen-pciback/pci_stub.c
> @@ -1172,8 +1172,8 @@ out:
>  	return err;
>  }
>  
> -static ssize_t pcistub_slot_add(struct device_driver *drv, const char *buf,
> -				size_t count)
> +static ssize_t new_slot_store(struct device_driver *drv, const char *buf,
> +			      size_t count)
>  {
>  	int domain, bus, slot, func;
>  	int err;
> @@ -1189,10 +1189,10 @@ out:
>  		err = count;
>  	return err;
>  }
> -static DRIVER_ATTR(new_slot, S_IWUSR, NULL, pcistub_slot_add);
> +static DRIVER_ATTR_WO(new_slot);
>  
> -static ssize_t pcistub_slot_remove(struct device_driver *drv, const char *buf,
> -				   size_t count)
> +static ssize_t remove_slot_store(struct device_driver *drv, const char *buf,
> +				 size_t count)
>  {
>  	int domain, bus, slot, func;
>  	int err;
> @@ -1208,9 +1208,9 @@ out:
>  		err = count;
>  	return err;
>  }
> -static DRIVER_ATTR(remove_slot, S_IWUSR, NULL, pcistub_slot_remove);
> +static DRIVER_ATTR_WO(remove_slot);
>  
> -static ssize_t pcistub_slot_show(struct device_driver *drv, char *buf)
> +static ssize_t slots_show(struct device_driver *drv, char *buf)
>  {
>  	struct pcistub_device_id *pci_dev_id;
>  	size_t count = 0;
> @@ -1231,9 +1231,9 @@ static ssize_t pcistub_slot_show(struct
>  
>  	return count;
>  }
> -static DRIVER_ATTR(slots, S_IRUSR, pcistub_slot_show, NULL);
> +static DRIVER_ATTR_RO(slots);
>  
> -static ssize_t pcistub_irq_handler_show(struct device_driver *drv, char *buf)
> +static ssize_t irq_handlers_show(struct device_driver *drv, char *buf)
>  {
>  	struct pcistub_device *psdev;
>  	struct xen_pcibk_dev_data *dev_data;
> @@ -1260,11 +1260,10 @@ static ssize_t pcistub_irq_handler_show(
>  	spin_unlock_irqrestore(&pcistub_devices_lock, flags);
>  	return count;
>  }
> -static DRIVER_ATTR(irq_handlers, S_IRUSR, pcistub_irq_handler_show, NULL);
> +static DRIVER_ATTR_RO(irq_handlers);
>  
> -static ssize_t pcistub_irq_handler_switch(struct device_driver *drv,
> -					  const char *buf,
> -					  size_t count)
> +static ssize_t irq_handler_state_store(struct device_driver *drv,
> +				       const char *buf, size_t count)
>  {
>  	struct pcistub_device *psdev;
>  	struct xen_pcibk_dev_data *dev_data;
> @@ -1301,11 +1300,10 @@ out:
>  		err = count;
>  	return err;
>  }
> -static DRIVER_ATTR(irq_handler_state, S_IWUSR, NULL,
> -		   pcistub_irq_handler_switch);
> +static DRIVER_ATTR_WO(irq_handler_state);
>  
> -static ssize_t pcistub_quirk_add(struct device_driver *drv, const char *buf,
> -				 size_t count)
> +static ssize_t quirks_add(struct device_driver *drv, const char *buf,
> +			  size_t count)

Shouldn't this be named quirks_store()?


Juergen