From: Maksym Planeta <maksym@exostellar.io>
To: Dave Hansen <dave.hansen@intel.com>,
Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Grab mm lock before grabbing pt lock
Date: Mon, 9 Dec 2024 13:39:30 +0100 [thread overview]
Message-ID: <813d9908-48e4-46ce-87c9-7414170e6a6e@exostellar.io> (raw)
In-Reply-To: <24b8d4a0-36c3-4404-98aa-7d8e2c67ac95@intel.com>
On 05/12/2024 19:52, Dave Hansen wrote:
> I have the _feeling_ it's just a big hack and this code throws caution
> tot the wind because of:
>
>> * Expected to be called in stop_machine() ("equivalent to taking
>> * every spinlock in the system"), so the locking doesn't really
>> * matter all that much.
>
> So the patch here kinda doubles down on the hack and continues the theme
> because "locking doesn't really matter all that much."
>
> If so, it's not super satisfying, but it is consistent with the existing
> code.
>
I indeed could not find reasons why locking would be strictly necessary for correctness here. On the other hand a
clearly benign warning should not be triggered, especially considering that panic_on_warn may be on on some systems.
next prev parent reply other threads:[~2024-12-09 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 10:35 Maksym Planeta
2024-12-05 18:52 ` Dave Hansen
2024-12-09 12:39 ` Maksym Planeta [this message]
2024-12-12 8:34 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=813d9908-48e4-46ce-87c9-7414170e6a6e@exostellar.io \
--to=maksym@exostellar.io \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®