From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4331311948 for ; Fri, 19 Dec 2025 11:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766143597; cv=none; b=NBOSvBUjqGmlkX7grKRHt7ytYVzgFlYOx4ybxvSOc0/rzKtLEoiOcHvNJEgfxjRIe3hFS94xY2MhHu+hiqkFLYiDt22aJcRijw0oUo/qSOVaJTwG4nuQjXoOQqln+q18XxzKXCj6wjUg2eyWlBvyXzbBSb2dXRR9SldGZWrGLTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766143597; c=relaxed/simple; bh=OjKMLBMWvXBLsRQ+Ku+b35IsH0szsjD/FESaTra+1sE=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=FRpqGpxmlS42PA6adPRRjaH/KdFxZoIK3Jl7t3WG9hR2W7lFvTX33iSeDkEQ+JQRDC7I0ag1Yjx1DvW2r0f8iU6AR3FIl9XwbZpmZogSGCv/KftOK4MZsVcjLwd//oYrcIY+LxmnhUzAu5oYnl7fWiVwwuosLWtFGq3U5NkmB7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SSrKrAiY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SSrKrAiY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766143594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DNkySk2gooQskMWGcML4EcBFjuRdoagkUJErjio2lVE=; b=SSrKrAiYkvDY27cMRas0vvMJL/omCSKFAkTe48cA5Vw1qa4AwWK0Igdw8u7mqd7rzUPtb8 ZxZlTaqzEGi/+YaM32K5x3xkFP37oLGBArLtWZrQAZXXvMPJpLyd8GejxXW9wnmT42jc1w qvR4XL29QDr7nJOX1Skg1KzfXyFCL0o= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-VECoU5aiMvyqXc5WYRp_Hg-1; Fri, 19 Dec 2025 06:26:29 -0500 X-MC-Unique: VECoU5aiMvyqXc5WYRp_Hg-1 X-Mimecast-MFC-AGG-ID: VECoU5aiMvyqXc5WYRp_Hg_1766143588 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D35CF1956053; Fri, 19 Dec 2025 11:26:26 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 90E3819560B4; Fri, 19 Dec 2025 11:26:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20251210-virtio_trans_iter-v1-1-92eee6d8b6db@codewreck.org> To: asmadeus@codewreck.org Cc: dhowells@redhat.com, Christoph Hellwig , Eric Van Hensbergen , Latchesar Ionkov , Christian Schoenebeck , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, Matthew Wilcox , linux-fsdevel@vger.kernel.org, Chris Arges Subject: Re: [PATCH] 9p/virtio: restrict page pinning to user_backed_iter() iovec Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <814007.1766143582.1@warthog.procyon.org.uk> Date: Fri, 19 Dec 2025 11:26:22 +0000 Message-ID: <814008.1766143582@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 asmadeus@codewreck.org wrote: > FWIW, the comment at the top of extract_iter_to_sg() says: > > The iov_iter_extract_mode() function should be used to query how cleanup > but I couldn't find any such function (even back when this comment was > added to netfs code in 2023...), the two copies of this comment probably > could use updating... David? Ah, the function got renamed to iov_iter_extract_will_pin() instead. I need to fix the comment. David