Re: [PATCH net-next v10 2/4] net: dsa: motorcomm: Split SMI module

[Andrew Lunn <andrew@lunn.ch>]

> > > +int yt921x_reg_read(struct yt921x_priv *priv, u32 reg, u32 *valp)
> > > +{
> > > +     WARN_ON(!mutex_is_locked(&priv->reg_lock));
> > > +
> > > +     return priv->reg_ops->read(priv->reg_ctx, reg, valp);
> > > +}
> > > +
> > > +int yt921x_reg_write(struct yt921x_priv *priv, u32 reg, u32 val)
> > > +{
> > > +     WARN_ON(!mutex_is_locked(&priv->reg_lock));
> > > +
> > > +     return priv->reg_ops->write(priv->reg_ctx, reg, val);
> > > +}
> >
> > [Severity: Low]
> > This is a pre-existing issue and not introduced by this patch, since these
> > two lines are moved verbatim out of chip.c.
> 
> It would be better to address it in another commit. Also it's the AI
> who suggests not to include such changes.

Since it is pre-existing, a new patch would be good.

      Andrew