From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751380AbdIMWls (ORCPT ); Wed, 13 Sep 2017 18:41:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40286 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdIMWlr (ORCPT ); Wed, 13 Sep 2017 18:41:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3380280461 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com From: Josh Poimboeuf To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [PATCH] tools: objtool: fix memory leak in elf_create_rela_section() Date: Wed, 13 Sep 2017 17:41:39 -0500 Message-Id: <8143a814a7c4ed2d099ee2c520f20ff30d2b3e17.1505342451.git.jpoimboe@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 13 Sep 2017 22:41:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Martin Kepplinger Let's free the allocated char array relaname before returning in order to avoid leaking memory. Signed-off-by: Martin Kepplinger Signed-off-by: Josh Poimboeuf --- tools/objtool/elf.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6e9f980a7d26..6aacbc31316d 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base) strcat(relaname, base->name); sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0); - if (!sec) + if (!sec) { + free(relaname); return NULL; + } + + free(relaname); base->rela = sec; sec->base = base; -- 2.13.5