From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB48433E35D for ; Thu, 4 Dec 2025 12:26:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764851181; cv=none; b=MxZue9+244cFw8dXoQ5pC6NGMwz45bjQXGDYTw9za8XQAg1fhSTe0gXpZkLq4JTTHKzSNPM5in2ZA19S4XPQRxLQvV/XFxA2JRTRRPjIK4KfSI0M5L7djO4tevQCVKyx4Bsbh+FqVR4pOeprikaCiHjj1fzJg3rUluH7a/QMBSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764851181; c=relaxed/simple; bh=3o+R5O8QHWnEDHIV5u57tBpCe6kjiRLF1YogdvMbEzc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bJHTKWH/kbCcrm0L3jk/lGhMjOiqDGkY/PulFs80ncLKK7XyUc7y8HVnP/6wFcVJctEbIOTxNGzprt9QKpIGJJCcRbrRyEGzoulOlMfNHSXtOyuXJcs8z54XQ0KxAx7CR8eRCIBk8gwCeVgCpUdct4HrBmLhoKqWujxauT0AdOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I6pDtZPw; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Cdainu/i; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I6pDtZPw"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Cdainu/i" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764851177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ntrkK5ngwL04sLtoW4Sv8APHLop043OBw9D0nKKE4pM=; b=I6pDtZPws4bVhnm0U8/v+ICRr703P3rjVS/LtjIVWvwgLjWEPn/x472FAR3AFfIig4crFI 1hexXPNcHPjEH2zDl87RT4eZeas6sqFsLvgIRPtHQArnA/TW2e42QwkhPbQq32YECFkIwT yoI8WHRyi3A107mO7H3ktdPrsCrG1lk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-365-TutunUK1Oueun0r6QJ4pyg-1; Thu, 04 Dec 2025 07:26:15 -0500 X-MC-Unique: TutunUK1Oueun0r6QJ4pyg-1 X-Mimecast-MFC-AGG-ID: TutunUK1Oueun0r6QJ4pyg_1764851174 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-42b2f79759bso581041f8f.2 for ; Thu, 04 Dec 2025 04:26:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764851174; x=1765455974; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ntrkK5ngwL04sLtoW4Sv8APHLop043OBw9D0nKKE4pM=; b=Cdainu/idJPbPDreL5SDXAOkG/NMQfaTM7Dq+LehPetYjJemQrzQmKSBH3oQG7Q3K6 7sToxglozW7xgVDO57zWrrULtQCUICENNRoYr2StcAaur2mpWIld7bvu/rgriTPzH8JA T0CmA9juRJqaft/gag6B49hRnYM8ND0HhbdVHBfBo810FLuqplH8+lwReBYKFUVLhJLD 4BaAYJtzz75/YBV/SoUyReXXSM+NbtwlwgKdvNJ+OkIrJ0QTth+T7qE+ysgB8AqYGwZ5 M31BreMjk9SmyNAL5sojoralPNeQaCgWwNSFbxQfWZoChJO7nrX+UYczNRPLPE6LKk2a 8G2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764851174; x=1765455974; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ntrkK5ngwL04sLtoW4Sv8APHLop043OBw9D0nKKE4pM=; b=Y8XnAmNqFNutI7DEJ/5eSNokT8RHon4y8t4ixqAP2X3iGTpFG4f91edte89TSXXd9W cSbBkNt7zZWByxhnznAaWE0VjqulhAov56elwFYhfEeQWq+fBm+jPc8CEZUZ2472cAqN fEcdOQbzj+glZd/IRCz/HbqUkGZwdWqwcYopUaHfh06G39W+GTYHyK8Z1BrDaKCWWuHx 0TbvejXmKZOmjejhIa/b0h4NK/SjvV9tcUWtv0DSv9RhK1xM5Ivd6gWYSOkvnYrMVZy8 AK1O8k56vxRXnah3+q3mmQ8YS1BuaPkog1XqlKLmW5PhvNbTt445SevBGE6LzBwSId4+ 0VnA== X-Forwarded-Encrypted: i=1; AJvYcCVoOI6UswqWKvHlkk4NhJwXTE3eMLD61fMgclQkY8wEtDDzBhEeIVC8R45IpvgEtujg7C4wzfFzqGYfOE8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkh9WtPdjnRLD6IorcSNv0UOP4GPGwBflK2RjG3hYCmkILn7eG jCwwPs4Gg32GMvPrJPaQY3w7EHLjGTTkjAHA3/pctjs01nfPCWs9r3vBCyu3ELBLMXocDtXd4zD BDSw7KidR4eD67xIjGqLvnPpuhd3Xf/8iOwkzQhn0QESA86IwxIyCRyIXWmfPmj87oA== X-Gm-Gg: ASbGnctkY/g1NTu38DZ6MNoPm/9SySNP3blDcNy19GhP85yCc1ztFct3H+5/wqUUJhD SaW+ENWCitSLcTWz9sU0oju9zMC+WTHb9xo6FDgUbHSHpXRLQw17vHRyta9dD4xWY9v8c6JRLHK X76EJR+/UizMYpxQ530SMQyA5ldmjqg4BGsNPUfN7g/1fujES5qwCU7Z2PT6ut0EeHozzF6QsKz w3MIKrvwLYo9tsdQ5l7JMljS/YCG30pZ+C17fhJYq6jgqWZmCwuzuAFx0vXdDgVfRiBPavaq3pj NSTzC5q6xKzewxRdULG4OXD6qtK45UK7tPReiBcLb651fMXQTexsbLKvMpckXYlqV5b2T5eFeLq IkAkWanZMPqbC X-Received: by 2002:a05:6000:2c07:b0:42b:3ed2:c079 with SMTP id ffacd0b85a97d-42f731a2fccmr6636003f8f.48.1764851174429; Thu, 04 Dec 2025 04:26:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6gmno3wWmw/T0ba/JcUdJo3RTAy+j1I7RB2376m0GMm4A3gdkyRtvDjK4Ir85kEN7eqyU1w== X-Received: by 2002:a05:6000:2c07:b0:42b:3ed2:c079 with SMTP id ffacd0b85a97d-42f731a2fccmr6635966f8f.48.1764851173922; Thu, 04 Dec 2025 04:26:13 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d222506sm3442295f8f.28.2025.12.04.04.26.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 04:26:13 -0800 (PST) Message-ID: <81491196-2872-4fd3-a1f3-f27ce0bb998b@redhat.com> Date: Thu, 4 Dec 2025 13:26:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: stmmac: fix oops when split header is enabled To: Jie Zhang , netdev@vger.kernel.org Cc: Jie Zhang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Maxime Coquelin , Alexandre Torgue , "Russell King (Oracle)" , Furong Xu <0x1207@gmail.com>, Kunihiko Hayashi , Vladimir Oltean , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251202025421.4560-1-jie.zhang@analog.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251202025421.4560-1-jie.zhang@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit n 12/2/25 3:54 AM, Jie Zhang wrote: > For GMAC4, when split header is enabled, in some rare cases, the > hardware does not fill buf2 of the first descriptor with payload. > Thus we cannot assume buf2 is always fully filled if it is not > the last descriptor. Otherwise, the length of buf2 of the second > descriptor will be calculated wrong and cause an oops: > > Unable to handle kernel paging request at virtual address ffff00019246bfc0 > Mem abort info: > ESR = 0x0000000096000145 > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x05: level 1 translation fault > Data abort info: > ISV = 0, ISS = 0x00000145, ISS2 = 0x00000000 > CM = 1, WnR = 1, TnD = 0, TagAccess = 0 > GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 > swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000090d8b000 > [ffff00019246bfc0] pgd=180000009dfff403, p4d=180000009dfff403, pud=0000000000000000 > Internal error: Oops: 0000000096000145 [#1] SMP > Modules linked in: > CPU: 0 UID: 0 PID: 157 Comm: iperf3 Not tainted 6.18.0-rc6 #1 PREEMPT > Hardware name: ADI 64-bit SC598 SOM EZ Kit (DT) > pstate: 00400009 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : dcache_inval_poc+0x28/0x58 > lr : arch_sync_dma_for_cpu+0x28/0x34 > sp : ffff800080dcbc40 > x29: ffff800080dcbc40 x28: 0000000000000008 x27: ffff000091c50980 > x26: ffff000091c50980 x25: 0000000000000000 x24: ffff000092a5fb00 > x23: ffff000092768f28 x22: 000000009246c000 x21: 0000000000000002 > x20: 00000000ffffffdc x19: ffff000091844c10 x18: 0000000000000000 > x17: ffff80001d308000 x16: ffff800080dc8000 x15: ffff0000929fb034 > x14: 70f709157374dd21 x13: ffff000092812ec0 x12: 0000000000000000 > x11: 000000000000dd86 x10: 0000000000000040 x9 : 0000000000000600 > x8 : ffff000092a5fbac x7 : 0000000000000001 x6 : 0000000000004240 > x5 : 000000009246c000 x4 : ffff000091844c10 x3 : 000000000000003f > x2 : 0000000000000040 x1 : ffff00019246bfc0 x0 : ffff00009246c000 > Call trace: > dcache_inval_poc+0x28/0x58 (P) > dma_direct_sync_single_for_cpu+0x38/0x6c > __dma_sync_single_for_cpu+0x34/0x6c > stmmac_napi_poll_rx+0x8f0/0xb60 > __napi_poll.constprop.0+0x30/0x144 > net_rx_action+0x160/0x274 > handle_softirqs+0x1b8/0x1fc > __do_softirq+0x10/0x18 > ____do_softirq+0xc/0x14 > call_on_irq_stack+0x30/0x48 > do_softirq_own_stack+0x18/0x20 > __irq_exit_rcu+0x64/0xe8 > irq_exit_rcu+0xc/0x14 > el1_interrupt+0x3c/0x58 > el1h_64_irq_handler+0x14/0x1c > el1h_64_irq+0x6c/0x70 > __arch_copy_to_user+0xbc/0x240 (P) > simple_copy_to_iter+0x28/0x30 > __skb_datagram_iter+0x1bc/0x268 > skb_copy_datagram_iter+0x1c/0x24 > tcp_recvmsg_locked+0x3ec/0x778 > tcp_recvmsg+0x10c/0x194 > inet_recvmsg+0x64/0xa0 > sock_recvmsg_nosec+0x1c/0x24 > sock_read_iter+0x8c/0xdc > vfs_read+0x144/0x1a0 > ksys_read+0x74/0xdc > __arm64_sys_read+0x14/0x1c > invoke_syscall+0x60/0xe4 > el0_svc_common.constprop.0+0xb0/0xcc > do_el0_svc+0x18/0x20 > el0_svc+0x80/0xc8 > el0t_64_sync_handler+0x58/0x134 > el0t_64_sync+0x170/0x174 > Code: d1000443 ea03003f 8a230021 54000040 (d50b7e21) > ---[ end trace 0000000000000000 ]--- > Kernel panic - not syncing: Oops: Fatal exception in interrupt > Kernel Offset: disabled > CPU features: 0x080000,00008000,08006281,0400520b > Memory Limit: none > ---[ end Kernel panic - not syncing: Oops: Fatal exception in interrupt ]--- Please avoid including the last 6 lines in the commit message, the '---' separator could foul git when applying the patch and truncate the commit message. > To fix this, the PL bit-field in RDES3 register is used for all > descriptors, whether it is the last descriptor or not. > > Signed-off-by: Jie Zhang Looks like a fixes suitable for net; a fix tag is required and you should include the target tree into the subj prefix, see: https://elixir.bootlin.com/linux/v6.18/source/Documentation/process/maintainer-netdev.rst#L64The patch does not apply to 'net' anymore, please rebase and resubmit. You can retain Jacob's ack. /P