From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011063.outbound.protection.outlook.com [40.93.194.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E382326ED28 for ; Mon, 19 Jan 2026 06:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.63 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768804870; cv=fail; b=lxffVzEeCuMBvwIoGqD8XJC2WO5SetD3L/7CHnZ+J+SeNvnkqVRQO7h3vlMQ66C+llSaSppfOh8qxRLbMEz//ptNE4pZsDNTKN+N1ofZ2HMHJD6Uwb8I0WVleQsfvFjR6+CmkU3vLtuXKxme9TYxm3WjSGOlsD/vDN2oXH6/tfg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768804870; c=relaxed/simple; bh=iUCC0Zlb3ehisD7Fm6Y0rMMG9BbZVZInYfie/ScUiVo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=t5Z3DuqyLVvlazfygv4vXj1bX1zvP1mxvD2+4Qt5wpS251wf0UO5p+MWjoyvU7nyV4zCiyIvMphvka9kHffKsuHE59Jjxfua/8RNctJi83y2rWVAllEeiW9J2vH3YTb31DoJkMFYBj3HcrNKTlThjmhY3z04WZjBff98/GPb9Oc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fb0Hy0cN; arc=fail smtp.client-ip=40.93.194.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fb0Hy0cN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hv/adcM3X/1IGbVLiA9XXEhUasuhdkShiMURsWUkniJVU3AgF/Moc+KLenJyOWb4kML3YcWY3LafY9vFkANceolRz1ZKDSC8fTQmot2pEbAezZTqZz/+6epzKkliwJN/wFX5ZkXss9yqRpAy2w8bhwOM/bNgmqz4ufXWFxPSF2HbpzcXGMxkydDWH3Pbf5cRiURAZ8fYI8MBLLLS7j/Ignz4NY89NeBppqaDRmiihWpDOf0Cvq0TyYq03j/6FfedcU4cD00IIau359ZJHVwTnYi3CM7h85p9jqdhiUOBxbbr9QC3lBDIEz3Czr+B11IupI+LmHk84q603d1F+Zy/4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4NvF1AlHCIJagF1xz+5bAZZiJ+uMUzPE7EZImvtGuwA=; b=AwLHna2o6yz08kf6k3ZXFVyR7dYOJTL+y3hC7H06W64ovM1DbkP8hUg81k7ClInx2giTkhpjwNeYWejlu1B8xpFeE7DCOO2NVNQ39zA38hcL//R7ck0W5HVUuXyjiJ3jF6YGsbqusfeIzKY5wb1ul7iBgEWtjGGI90UMJBepzA9jchZIAdXjNype5/Tuf6eWHInDEkaftQ/gFIEsGcCcWKytH9FTUUhTWJctGYAt6MvShg/trYYlDRdJFnilVm5FNt5b0JHx/EtPhwrmNkXYF86+MNuSaC0AmzsW1pYZmax9WZyAxJ7PptQciEM2cCDrQEJfmhuJFe33YDTCx0yAqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ncsu.edu smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4NvF1AlHCIJagF1xz+5bAZZiJ+uMUzPE7EZImvtGuwA=; b=fb0Hy0cNi4CbdIrbVyRpOX0Ymp6Bk2OiVnW4OhM/p3i153Pw8Lbu5DQdX7vGDGpbndAnHZqfCMTz1VRyaIDn5Cem1zjrQKuzjvqKQcIFKK3SyhwXm5ZQcdGGzstd7pBCiFB7M1WR8iFLQfBIpoXmftTdT8TffoxIcym1/EsIz9I= Received: from DM6PR07CA0056.namprd07.prod.outlook.com (2603:10b6:5:74::33) by DS7PR12MB6311.namprd12.prod.outlook.com (2603:10b6:8:94::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.11; Mon, 19 Jan 2026 06:41:05 +0000 Received: from CH3PEPF00000014.namprd21.prod.outlook.com (2603:10b6:5:74:cafe::6d) by DM6PR07CA0056.outlook.office365.com (2603:10b6:5:74::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9499.7 via Frontend Transport; Mon, 19 Jan 2026 06:41:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000014.mail.protection.outlook.com (10.167.244.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.0 via Frontend Transport; Mon, 19 Jan 2026 06:41:05 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 19 Jan 2026 00:41:03 -0600 Received: from [10.85.36.78] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 19 Jan 2026 00:40:58 -0600 Message-ID: <814a7bca-c5c7-446f-a67a-c09dab397f9b@amd.com> Date: Mon, 19 Jan 2026 12:10:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/3] sched/fair: Co-locate cfs_rq and sched_entity in cfs_tg_state To: Zecheng Li , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Rik van Riel , Chris Mason , Madadi Vineeth Reddy , Xu Liu , Blake Jones , Josh Don , Nilay Vaish , , Zecheng Li References: <20260118033431.158464-1-zli94@ncsu.edu> <20260118033431.158464-2-zli94@ncsu.edu> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260118033431.158464-2-zli94@ncsu.edu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000014:EE_|DS7PR12MB6311:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d79ce88-93c5-4fa2-0cd3-08de5725b877 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QUxUUnh0SHExQ05Od2UwZU1WZ1lOZEt2RjJncy9FVlI2aFVWMVJJUWlwektq?= =?utf-8?B?ZzRwRndkd0hxL2NIUnMxa1BTTkNaeFY5VFg0N2Fjdkgya2hhK01sSk1HSUxD?= =?utf-8?B?Vms0bmZOOFI1VmdQd294MWFDQ2ViWTgrSGMydUFwZmZpMU1GOXdqbFlmb0d5?= =?utf-8?B?WFptMDBtSTY4ellVZkRPWkRIQ3daWFB5ekRwRW94SU41Z3BCWHpzclB3QWdR?= =?utf-8?B?Uk9wUjB4STJtZXdlZVBoVWoxWlV1OGZaQmUwK3ZCSEFNb0crNUtJajg4SVZE?= =?utf-8?B?Qm5vdlkyeUUxdG9tSEdmWnFQcUZSMnZxV1Q0MVZBZFhSQ2FNb0dLUXRjak1K?= =?utf-8?B?UXptcmV6eXUwNFErTEc4NnFSaDFIUkh3TXJicjdBSDAxZVZ3ZnQ5Y1hPMlRa?= =?utf-8?B?WUlqMytEejYzZmZ1OHR5eGZsdXQvZXF2TWd5bHh0eG9Tb2lFSisvSEswcDNI?= =?utf-8?B?VnY4aWxsZFl6bVZmYWhsbU1BNTRSRUF2VC91djlmZ2RTWWp1SFFsaFhSOUdG?= =?utf-8?B?Ynh4dnJQUXFMK2hOSTJ4VmpJWWxyK2pCWEkzS0hzV3NFWmNxMFJQSE5mRi9P?= =?utf-8?B?elBlcStabTNrYXN0eDhYcUU5eFd2QTZPWGZzdk1kcGxCdUhvOHM2L2ZQYUho?= =?utf-8?B?TGJsT3VoNHVRZENWMHFObGE5SkJocmdVWThXbkJ5a1pwUUg3U1VFTHhCOGIy?= =?utf-8?B?d050Y3Qya2l0MlkyZnRiMXNycGpyb1BhT3BVTUxBMml4VkcvNTIrNnBPN0Yw?= =?utf-8?B?WGdyR1E0Wkt1ZUErMC8xTmUwWDA5OEU5a1dBa0dGMlROczhqeFZCYThRQjZp?= =?utf-8?B?K3Vsc0Fibllodm5BMUxFc1VuQWNjaXM4Zmc3S0VkVFZSVGJ5bDJNUE12ZWxs?= =?utf-8?B?OUFKWDEzc1U3M2FDNUdrWERXZytBWCsrc0ZqOCsvWjRndkhLMG51YklKSWFt?= =?utf-8?B?REsrdWx2eVJyblAvSTgzMTFiMEFETnlNbXVUMVNlNW04cHp4aFBOeWN1c2s5?= =?utf-8?B?VjhEOEorNDRXZnBYbk1Yc0YvblNjalZ3VnI0M0k5QStxaFU3d1ZOQkI3akhu?= =?utf-8?B?OU0yL0VWK29yN3pHWThCR28rRkhuWGFMVlU5NENnVDRYa1hZcEEvZ2ZVSGRi?= =?utf-8?B?MmRWdVpwUml0emxmOVpKYzM4cXRXTW45ZWVJUnFZREkxYVlJM2dVZ1hOV0x2?= =?utf-8?B?ekd1QnZzUllTVFRNdmNZdTVRdDdsQjZ2ejBBWTFjcUF2Q0hPT1FOM3VZRkJi?= =?utf-8?B?NnBpRmROa1d5T0xuRUdudzJWbmZudE90L0FGZDJJcVNsa3dPQ21nVzF3N2xj?= =?utf-8?B?aXZqL00vWXVjbVl3ajd3VVV4Vlo5ZEF2aWJWWHl5L3dabFJ1SFBQaERHZHV6?= =?utf-8?B?eXpuRVJ4V3BOZ1ppY2h0RTZab2V0azIrRG53Ujk3Q01xMG5tMnZvU1kyd3VN?= =?utf-8?B?TFk2a3pid3d1S09YVElTdXVITTZSYmdFWE44SEp0YTdtdUk5YWVtdXd6c3d3?= =?utf-8?B?VlJWazVGYytRZS92OEh5K011MDFjQ0NQUXZzSUhKWENJVkJvaVhsTjEveGF2?= =?utf-8?B?UVFMZUMrdCtrMElLMVZrdjZaTlVEWm0wSXg0NVcyNHlNQ3VzR0tmbGYvT055?= =?utf-8?B?T3VwVm56cjg3UG1LSUx3QVhFVWxIRm01V3VIR011MGpVWk04TWdOdkJsU25G?= =?utf-8?B?MGo1RmhRRkNaaVFqVm82dUlFbVRVNGtHN1dzYUNlS2JkVS9aK283Z2dkMkRy?= =?utf-8?B?NkF2enhsV3U3S3hSNUNBdnkwNDIxVGRtTGVMTG5nb0VwUjFZc291YndNcjRB?= =?utf-8?B?MmVEMFVrc1ZTQWVkSTVQVE91UVIwOXBJaDZLN2VtdGxVQWlVYkIwODNXN0lK?= =?utf-8?B?THZ0dU1hc0ZqUjJXQkwxTDB6RXVrZzhRY2hRM0VSNGxZQ1VwMTU1RTdFUHJL?= =?utf-8?B?UWgweXJqMUdVeFgxQkV2MVZVaElrODUwK2RyenpLTFpFVnFYaitKbmczNUxO?= =?utf-8?B?WGY2V1c5TXRwTms4L2k5NTlPUGx5NkF0SlM5cnovUzBDZzZlcHFGRkZvWHRj?= =?utf-8?B?TVN2QkowL2QrMk5VN2NzRlZMckNTQjNraE1RU1VGSVN5ZkJvTW5OT1NZcFI3?= =?utf-8?B?Wm0wOXl3OFI4R0FmRFMzSHZJakxHSFhIQXlGVE9BTWVuY0N1NnpXMEt2ejMx?= =?utf-8?B?cnoyRFFRU0RaWmNEMnRBZkY4OHI1MTg3QjJiL3JHUk9USXUwMVJNMmRheTF1?= =?utf-8?B?ZTdXWjFuMDZTckhqMUp1V1F5VnB3PT0=?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2026 06:41:05.3083 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d79ce88-93c5-4fa2-0cd3-08de5725b877 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000014.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6311 Hello Zecheng, On 1/18/2026 9:04 AM, Zecheng Li wrote: > @@ -13617,10 +13617,11 @@ void free_fair_sched_group(struct task_group *tg) > int i; > > for_each_possible_cpu(i) { > - if (tg->cfs_rq) > - kfree(tg->cfs_rq[i]); > - if (tg->se) > - kfree(tg->se[i]); > + if (tg->cfs_rq && tg->cfs_rq[i]) { nit. Since the cfs_tg_state uses __no_randomize_layout now and, "cfs_rq" is the first member, you can just do kfree(tg->cfs_rq[i]) since it is the beginning of cfs_tg_state too. This is how kfree() on tg->se[i] would have freed the entire "sched_entity_stats" previously. I know this is a transient change since later you switch to using free_percpu() but it would still be nice to have a simplified hunk here. > + struct cfs_tg_state *state = > + container_of(tg->cfs_rq[i], struct cfs_tg_state, cfs_rq); > + kfree(state); > + } > } > > kfree(tg->cfs_rq); -- Thanks and Regards, Prateek