From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162990AbdAFNH1 (ORCPT ); Fri, 6 Jan 2017 08:07:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49782 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032392AbdAFNGE (ORCPT ); Fri, 6 Jan 2017 08:06:04 -0500 Subject: Re: [PATCH v6 01/18] iommu/dma: Allow MSI-only cookies To: Robin Murphy , eric.auger.pro@gmail.com References: <1483643086-2883-1-git-send-email-eric.auger@redhat.com> <1483643086-2883-2-git-send-email-eric.auger@redhat.com> <20170106105945.GK17255@8bytes.org> Cc: Joerg Roedel , christoffer.dall@linaro.org, marc.zyngier@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com, gpkulkarni@gmail.com, shankerd@codeaurora.org, bharat.bhushan@nxp.com, geethasowjanya.akula@gmail.com From: Auger Eric Message-ID: <814f9798-dbd9-8e41-8e87-20a517c28c71@redhat.com> Date: Fri, 6 Jan 2017 14:05:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 06 Jan 2017 13:05:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, On 06/01/2017 13:12, Robin Murphy wrote: > On 06/01/17 11:46, Auger Eric wrote: >> >> >> On 06/01/2017 11:59, Joerg Roedel wrote: >>> On Thu, Jan 05, 2017 at 07:04:29PM +0000, Eric Auger wrote: >>>> struct iommu_dma_cookie { >>>> - struct iova_domain iovad; >>>> - struct list_head msi_page_list; >>>> - spinlock_t msi_lock; >>>> + union { >>>> + struct iova_domain iovad; >>>> + dma_addr_t msi_iova; >>>> + }; >>>> + struct list_head msi_page_list; >>>> + spinlock_t msi_lock; >>>> + enum iommu_dma_cookie_type type; >>> >>> Please move the type to the beginning of the struct and add a comment >>> how the type relates to the union. >> >> Sure >> >> Thank you for the review. > > FWIW I already had a cleaned up version of this patch, I just hadn't > mentioned it. I've pushed out an update with that change added too[1]. > > Robin. > > [1]:http://linux-arm.org/git?p=linux-rm.git;a=shortlog;h=refs/heads/iommu/misc Great, thanks! Eric > >> >> Best regards >> >> Eric >>> >>> >>> >>> Joerg >>> > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >