From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754622AbdCNA5t (ORCPT ); Mon, 13 Mar 2017 20:57:49 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36844 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753841AbdCNA5q (ORCPT ); Mon, 13 Mar 2017 20:57:46 -0400 Subject: Re: [PATCH net-next 08/12] net: bcmgenet: correct return value of __bcmgenet_tx_reclaim To: Doug Berger References: <20170314004142.4746-1-opendmb@gmail.com> <20170314004142.4746-9-opendmb@gmail.com> Cc: robh+dt@kernel.org, mark.rutland@arm.com, davem@davemloft.net, rafal@milecki.pl, xow@google.com, joel@jms.id.au, jon.mason@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, pgynther@google.com, jaedon.shin@gmail.com From: Florian Fainelli Message-ID: <81581ab7-8c75-d020-f31b-60829c3f089b@gmail.com> Date: Mon, 13 Mar 2017 17:57:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170314004142.4746-9-opendmb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2017 05:41 PM, Doug Berger wrote: > The reclaim function should return the number of buffer descriptors > reclaimed, not just the number corresponding to skb packets. > > Also, remove the unnecessary computation when updating the consumer > index. > > While this is not a functional problem it could degrade performance > of napi in a fragmented transmit stream. > > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian