From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DECD74BE1 for ; Sun, 24 May 2026 17:45:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779644721; cv=none; b=PI3K15+blNU86/98pF2fv38E7iNGQDRjKqD8VzBp5fvIKbYcZZ/4JvNMNjW/uSmS9ulbxjtxCcW2im0HpZ3kPMTXkdXjFCMXXxSyYLKzJzfLDbt+xyJeVaDedV2MEaBTu7sAFCOhpSH7jBCmtm+QDD5H6qyWKoibe326jfrf1r4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779644721; c=relaxed/simple; bh=GK1nD3ajcY2pPggLmMRttJYSQZrKVjfNRrsOW4guF3E=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=C6E8YfcIFJf7RAAnUlpSR0r4VtJUxZhzontk72BeE5b6VdKjy4HX6g+mG+cBy6W4tQbTcdwfjGD2NVgciRJPoUXTjmxdi+gfQXX3xwAvg3wXQxzQyMcD3Lm+uUE6Sz0X03rXZYKp4yygFTsrQh+sdZkf20RVJ/W9e0NM2qkDyDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ABWIYGlu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ABWIYGlu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BED251F00A3C; Sun, 24 May 2026 17:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779644719; bh=8Csb39+q5PVvsjPEw/Rh4ECCPvM0CI5p6rMb8tuDyjw=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=ABWIYGluxpLwZWOlqtE+nUc3k1DPPMXEN5AkzVKjht02XTsIt+3pwAkmIK0KqhsFr 5EB5LZaip3/jzoDe5z0qClaRTQSQLoTDyt+0y47gADaXEo5Wp/Ht4xid4Sm3gWu/AJ 5iuiXE8H0puJWFOm8L9PqjzFDaN+6pfhP134Em04r13kj9cWd14p3TOetasaIJvm/X UH03p3SntdYCGPTfM7R60GM4qw3uequANno5Hf2AUk2GuzkV1V6J0kZgaZPkNe8e1G QBM47Xx17wrRnNUKEoBQNYhnyU+HS/9QlhSSXKspzX2gHJzqCUpdnNwBulpx0B30zd id2Pi037Y9wvg== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id DAE64F40072; Sun, 24 May 2026 13:45:17 -0400 (EDT) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Sun, 24 May 2026 13:45:17 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduheeiheeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedfvehhuhgt khcunfgvvhgvrhdfuceotggvlheskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrh hnpefhffekffeftdfgheeiveekudeuhfdvjedvfedvueduvdegleekgeetgfduhfefleen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegthhhutg hklhgvvhgvrhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudeifeegleel leehledqfedvleekgeegvdefqdgtvghlpeepkhgvrhhnvghlrdhorhhgsehfrghsthhmrg hilhdrtghomhdpnhgspghrtghpthhtohepkedpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtohepnhgvihhlsegsrhhofihnrdhnrghmvgdprhgtphhtthhopehjlhgrhihtohhnse hkvghrnhgvlhdrohhrghdprhgtphhtthhopegurghirdhnghhosehorhgrtghlvgdrtgho mhdprhgtphhtthhopegthhhutghkrdhlvghvvghrsehorhgrtghlvgdrtghomhdprhgtph htthhopehokhhorhhnihgvvhesrhgvughhrghtrdgtohhmpdhrtghpthhtohepthhomhes thgrlhhpvgihrdgtohhmpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrh drkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqnhhfshesvhhgvghrrdhk vghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 3B777780070; Sun, 24 May 2026 13:45:17 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AiOgYnK8JZko Date: Sun, 24 May 2026 13:44:57 -0400 From: "Chuck Lever" To: "Jeff Layton" , "Chuck Lever" , NeilBrown , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <815a405e-b1da-4887-ba10-c0b435131325@app.fastmail.com> In-Reply-To: <1d7dda4d0181f60362ca27c3404dc55710bca775.camel@kernel.org> References: <20260523-dir-deleg-fixes-v1-0-142c884f85ce@kernel.org> <20260523-dir-deleg-fixes-v1-4-142c884f85ce@kernel.org> <1d7dda4d0181f60362ca27c3404dc55710bca775.camel@kernel.org> Subject: Re: [PATCH 4/4] nfsd: fix ino_t format specifier in nfsd_handle_dir_event tracepoint Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sun, May 24, 2026, at 8:09 AM, Jeff Layton wrote: > On Sat, 2026-05-23 at 12:17 -0400, Jeff Layton wrote: >> inode->i_ino is now a u64. Use the same size for the tracepoint. >> >> Signed-off-by: Jeff Layton >> --- >> fs/nfsd/trace.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h >> index 3d0f0bd30d90..1d5d11f914f2 100644 >> --- a/fs/nfsd/trace.h >> +++ b/fs/nfsd/trace.h >> @@ -1384,7 +1384,7 @@ TRACE_EVENT(nfsd_handle_dir_event, >> TP_STRUCT__entry( >> __field(u32, mask) >> __field(dev_t, s_dev) >> - __field(ino_t, i_ino) >> + __field(ino_t, u64) > > My apologies. This should read: > > __field(u64, i_ino) > > I had the fix in my tree and forgot to commit it before sending. Would > you like me to resend this one, or do you just want to fix it up? > >> __string_len(name, name ? name->name : NULL, >> name ? name->len : 0) >> ), I fixed this in place and pushed out the update to nfsd-testing. -- Chuck Lever