From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6293DC433EF for ; Fri, 11 Feb 2022 10:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348804AbiBKKJK (ORCPT ); Fri, 11 Feb 2022 05:09:10 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:44192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348792AbiBKKJI (ORCPT ); Fri, 11 Feb 2022 05:09:08 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1FB672D3 for ; Fri, 11 Feb 2022 02:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644574147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tuiIVhVMPKV1txAZFtZEl8nRNpH9lSxIAqZntDpj/IQ=; b=CaHCgfnAb2MAHwsPsFcP5pe3DSmfJKkS4ITNinOodZDx2Qvkelk2966ASY0+TqkHC8srcF O4eh7Y7N9BMIcFjH3y8HVUDnM0aJNgCndzXq2+MHYN7PIXxO7rbGHEvAbicmO/Owj1kGRs ciVdWhedBwoi+ubWHTMymp2DrX75ksQ= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-652-9xshQa3jMJ2bP4crDiYclA-1; Fri, 11 Feb 2022 05:09:06 -0500 X-MC-Unique: 9xshQa3jMJ2bP4crDiYclA-1 Received: by mail-ed1-f72.google.com with SMTP id m11-20020a056402430b00b00410678d119eso627648edc.21 for ; Fri, 11 Feb 2022 02:09:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tuiIVhVMPKV1txAZFtZEl8nRNpH9lSxIAqZntDpj/IQ=; b=sGl/nuWfJVxFnJmQOMUY9E8XqjIHGw7D9dx9BpF1+f49RyzOnfzlMf5HoyFSxclSwG OA52GfFAnBJLhEndDUqe0LUJHV6gee7MscUChn9xx8d2fyFF7UvOF/ffHl7SzYfSssh+ +hWFhipLpnCKCga2F94l+nWu2ri6AbkzAYgizvl0oP7YSTerVAsYBm47RBlX0FIUuRps lF6yuNOEq5jDgVLSPZCFA18zw9PKUJmuH6S7pmdU4wbDRZLg6nuS3bUi0yGnTkp93J87 WEV1RHftTiThGwsOnqUItLhZwEUmGgH0xjipYnksNFiqB2l2AKApo2zb5Dw4//hB90bL 4B9g== X-Gm-Message-State: AOAM532q9xH8k5BMnKEt4anzX2pPQUrmXyNLePnoOAL4dVdiggdXybO/ Oozympc5Q/Grb1mQ9ZVPeCUdlZHO5JuEUqjZZ0bTIA3SZrd4QBWRPQ8AalqFeZ/EOXmeknuJYxf L5IwZydp1+Gdhn63nAV6JkuH8 X-Received: by 2002:a17:906:63ca:: with SMTP id u10mr721478ejk.27.1644574144818; Fri, 11 Feb 2022 02:09:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJiCVPR/PhVFhZlERTWpkY0KgTzv1yI2acAM7/6eoKbrC4C+TCHrgFSv7rZsfxmkQtCqs6nA== X-Received: by 2002:a17:906:63ca:: with SMTP id u10mr721456ejk.27.1644574144641; Fri, 11 Feb 2022 02:09:04 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id z8sm4776958ejf.108.2022.02.11.02.09.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 02:09:03 -0800 (PST) Message-ID: <8160cf73-537a-9cd7-bb61-cca29fb0ebcb@redhat.com> Date: Fri, 11 Feb 2022 11:09:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 09/12] KVM: MMU: look for a cached PGD when going from 32-bit to 64-bit Content-Language: en-US To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, vkuznets@redhat.com, mlevitsk@redhat.com, dmatlack@google.com References: <20220209170020.1775368-1-pbonzini@redhat.com> <20220209170020.1775368-10-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/22 02:37, Sean Christopherson wrote: > >> if (VALID_PAGE(mmu->root.hpa) && mmu->root.hpa == __pa(mmu->pae_root)) > Gah, that's wrong too, it will allow the pml4_root case.*sigh* I'm fine punting > this until the special roots are less special, pml5_root is completely broken > anyways. Ok, I'll look at your comments on Jiangshan's series. Paolo