From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 188BBC2D1; Sat, 11 Oct 2025 00:35:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760142914; cv=none; b=QyUpEZo6Uh38OZ2UH9UHihk+4NQ7dzjOKkmt+9c2tKQujmpSoIQfGrt9h2mx7l0fzfyqkCoTSfkLOvcuoQNRwKjo2de7/E6W0nRJPi/7pRrAzjeBb+iytNX+rS5dbjbm1TOYEsP2dhMIBvvqr6YTOd37ky/LXazDJfdznxqSGDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760142914; c=relaxed/simple; bh=3OyLCE+iQFMC+1mcabus+EbXvFOpagivzcQXhJ/TYVs=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=I1NZ4SWAaZcJheWc+RmRx6HlfyR4+bhxDi1BweXBntp8urFgCTUsRT6wzH7/3unknVBr+5SFFT06sTXyBiqhbsNpedCZE86L9ahSF1VCnIV9NwDNjDlMz5QWlMYIAQjSE3L2P7DZscsPXDU4ncsQ9IQs6CmgQnLtgzJN62Bzjv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Vc0kXCQ5; arc=none smtp.client-ip=198.47.19.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Vc0kXCQ5" Received: from lelvem-sh02.itg.ti.com ([10.180.78.226]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTP id 59B0YtIi794953; Fri, 10 Oct 2025 19:34:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1760142895; bh=lIlfbEXPKt6sFk0wdJ6sW30Wwfmnzd3I5ezJv51ZMpc=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=Vc0kXCQ5Rz1TVfpOAJpHmtbvKNWhQUlguWbHupq5Bxjf95E5vmI/dP6zXPfDQ6JNV or5C1Q/6jEX3QlvnzVb7tvEx4CTWvieGCqa6CUuwBunGQ6v2ZQkZq7+/vhcZhrXhZa cNPgLEC2HQeBhiLz9V1+Mo7EYFPuzHPPlpRCqwlU= Received: from DLEE213.ent.ti.com (dlee213.ent.ti.com [157.170.170.116]) by lelvem-sh02.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 59B0Ytwi2048387 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Oct 2025 19:34:55 -0500 Received: from lewvowa02.ent.ti.com (10.180.75.80) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.20; Fri, 10 Oct 2025 19:34:54 -0500 Received: from DLEE203.ent.ti.com (157.170.170.78) by lewvowa02.ent.ti.com (10.180.75.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.55; Fri, 10 Oct 2025 19:34:54 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE203.ent.ti.com (157.170.170.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Fri, 10 Oct 2025 19:34:54 -0500 Received: from [10.249.42.149] ([10.249.42.149]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 59B0Ysdu2442119; Fri, 10 Oct 2025 19:34:54 -0500 Message-ID: <8161147a-532c-403c-bc29-05ce39987c8d@ti.com> Date: Fri, 10 Oct 2025 19:34:54 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] remoteproc: core: Remove unused export of rproc_va_to_pa To: Peng Fan , Bjorn Andersson , Mathieu Poirier , Arnaud Pouliquen , Daniel Baluta , "Maxime Coquelin" , Alexandre Torgue CC: , , , References: <20251010-remoteproc-cleanup-v2-0-7cecf1bfd81c@nxp.com> <20251010-remoteproc-cleanup-v2-5-7cecf1bfd81c@nxp.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <20251010-remoteproc-cleanup-v2-5-7cecf1bfd81c@nxp.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 10/10/25 7:24 AM, Peng Fan wrote: > commit 086d08725d34 ("remoteproc: create vdev subdevice with specific dma > memory pool") added an export for rproc_va_to_pa. However, since its > introduction, this symbol has not been used by any loadable modules. It > remains only referenced within remoteproc_virtio.c, which is always built > together with remoteproc_core.c. > > As such, exporting rproc_va_to_pa is unnecessary, so remove the export. > > No functional changes. > > Signed-off-by: Peng Fan > --- Acked-by: Andrew Davis > drivers/remoteproc/remoteproc_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index dd859378f6ff6dec2728980cc82d31687aa7a3dc..383479d624c89da1c481adc956a169c03b793bcc 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -156,7 +156,6 @@ phys_addr_t rproc_va_to_pa(void *cpu_addr) > WARN_ON(!virt_addr_valid(cpu_addr)); > return virt_to_phys(cpu_addr); > } > -EXPORT_SYMBOL(rproc_va_to_pa); > > /** > * rproc_da_to_va() - lookup the kernel virtual address for a remoteproc address >