mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Zhang, Rui" <rui.zhang@intel.com>
To: "Hansen, Dave" <dave.hansen@intel.com>,
	"rafael@kernel.org" <rafael@kernel.org>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"thorsten.blum@toblux.com" <thorsten.blum@toblux.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"yuntao.wang@linux.dev" <yuntao.wang@linux.dev>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"bp@alien8.de" <bp@alien8.de>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"Brown, Len" <len.brown@intel.com>,
	"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH V2] x86/apic: Stop the TSC Deadline timer during lapic timer shutdown
Date: Fri, 11 Oct 2024 02:04:38 +0000	[thread overview]
Message-ID: <8161ce3f9c874539195c53feb34a5cee421abf96.camel@intel.com> (raw)
In-Reply-To: <edb18687-9cd7-439e-b526-0eda6585e386@intel.com>

Hi, Dave,

On Thu, 2024-10-10 at 17:43 -0700, Dave Hansen wrote:
> How about something like the completely untested attached patch?
> 
> IMNHO, it improves on what was posted here because it draws a
> parallel
> with an AMD erratum and also avoids writes to APIC_TMICT that would
> get
> ignored anyway.

Thanks a lot for the rewrite. The patch looks great to me.

I will test it on our test boxes to make sure skipping the APIC_TMICT
write in TSC deadline mode does not bring unexpected impact to the old
machines.

thanks,
rui


  reply	other threads:[~2024-10-11  2:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09  7:20 Zhang Rui
2024-10-09 11:24 ` Rafael J. Wysocki
2024-10-09 16:41   ` Dave Hansen
2024-10-09 17:03     ` Rafael J. Wysocki
2024-10-09 16:33 ` Ricardo Neri
2024-10-09 17:20   ` Rafael J. Wysocki
2024-10-09 16:49 ` Dave Hansen
2024-10-09 17:19   ` Rafael J. Wysocki
2024-10-09 17:47 ` Dave Hansen
2024-10-09 18:43   ` Rafael J. Wysocki
2024-10-11  0:43     ` Dave Hansen
2024-10-11  2:04       ` Zhang, Rui [this message]
2024-10-11 10:25       ` Rafael J. Wysocki
2024-10-11 14:51         ` Pandruvada, Srinivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8161ce3f9c874539195c53feb34a5cee421abf96.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rafael@kernel.org \
    --cc=srinivas.pandruvada@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thorsten.blum@toblux.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yuntao.wang@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®