From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759265AbcIXQcm (ORCPT <rfc822;w@1wt.eu>);
        Sat, 24 Sep 2016 12:32:42 -0400
Received: from mout.web.de ([212.227.17.12]:50996 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757480AbcIXQcj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 24 Sep 2016 12:32:39 -0400
Subject: Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by
 pr_info() in joydump_connect()
To: Joe Perches <joe@perches.com>
References: <d8da8333-d83a-ca61-b887-7fd7528c63a4@users.sourceforge.net>
 <f486d64d-0759-9cd6-1e4e-df723acb6fea@users.sourceforge.net>
 <1474733610.23838.2.camel@perches.com>
Cc: linux-input@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net>
Date: Sat, 24 Sep 2016 18:32:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1474733610.23838.2.camel@perches.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:mS/NxGtsKLOpiVHpkWd56d2mt4xbmPuwtf/A0N3jK/FTYOu2Hdr
 zZabhhbtE+5bzQqGdE/qK8EP+EACaaXAoBR6iYylJRsL2x1W8MaNfzXNUpE8ZCC6PILV4Gm
 QKMUY/bKlQT16/jjKbhE2KdvJCJ2weeBjdjoQEvEtbqglFkxCQiSLKkzWSuR9fM+F0O+WpX
 7f2yEE++WKe2CxjgN8w9w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ojOxiVDjpgY=:YSQTx4vYUrt2pOjOlroB2r
 WQWWnHTEgeXLWc11/jEW0FveLJ+ceJZxlenm2nRSHynBK8YB8FumpZhAH2roc7cu/ZPWtnYTz
 DifQUp1AVJIT85WHI13g7hP2ZrRD47BVhS/S/fGvv1xnichWBO9rPoebzXjre/GgyXlq7fGtH
 Z8HU//PZvKZlqcANfS4D/FfyTdF01dYaHi4Vpwwo19WJCA11PUoqN2CEAvX6zb/vmBeCo8h5L
 SNawb6bLFDzcOwcCMPL1FvIFRhCFmU/udfTZC2RnGgNrujEnI3F/cGaGMmdYCotwDXk+Y76RF
 jgz2L6SAVFqATzdHIgiPOfZBUOzKoF2WUhTKtvjIUyRnpITiVQY/c9FW4ksggMS+F4YuuPADB
 AmIdEF7IfaV9kvs6SD22avWCur1JKB3sk4kwLyKIboeX1ykYG/Dv0lxSVA1ZvTOE0nyryxFKl
 eXV8+dAE/4QMuf14XTujk4CEjsvxUfosZ/ftE44pA0f914UB9dApK1etWHadv4aVLzQQi5cya
 CcRVugC/JMrCb5SJGo66uo771S4MWpNrheqRpRAApUAfuQYhh/QZ2l5x6Bj8h8xUEPDL3J8S3
 Gd+9UHQByJWJauxVxinuo/fsT0CbFsBJgVbTb2yQRaWXgE+y9TudMFUq6VK6v7mUQUrPMXc2t
 kXYIGDNL2g570k3vu+8JKAnfsWgL9k+aVtpGMMGBre1hg9bipFa5lWIy1ncQ/rjY3dPj6L4L5
 R3IMJq8jSWUZYTQA+e1NayPGfvUk7ABmFn6YjU+uXBQXgVxdWcTv5OlOjfI4oPGv3Z/Ya6NFj
 ndqdCZy
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr
>>>  	unsigned long flags;
>>>  	unsigned char u;
>>  
>>> -	printk(KERN_INFO "joydump: ,------------------ START ----------------.\n");
>>> -	printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys);
>>> -	printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed);
>>> +	pr_info(",------------------ START ----------------.\n"
>>> +		"| Dumping: %30s |\n"
>>> +		"| Speed: %28d kHz |\n",
>>> +		gameport->phys,
>>> +		gameport->speed);
> 
> Not the same output.

Should the desired output be the same when the relevant data are passed by a single function call
(instead of three as before)?

Regards,
Markus