From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752303AbdEPMvi (ORCPT <rfc822;w@1wt.eu>);
        Tue, 16 May 2017 08:51:38 -0400
Received: from mail-qt0-f196.google.com ([209.85.216.196]:33897 "EHLO
        mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751219AbdEPMvh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 May 2017 08:51:37 -0400
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: [patch v2 6/6] staging: speakup: flush tty buffers and ensure hardware flow control
From: Okash Khawaja <okash.khawaja@gmail.com>
X-Mailer: iPhone Mail (11A501)
In-Reply-To: <20170516122828.GA30371@kroah.com>
Date: Tue, 16 May 2017 13:51:35 +0100
Cc: Jiri Slaby <jslaby@suse.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        Kirk Reiser <kirk@reisers.ca>,
        "Speakup is a screen review system for Linux." 
        <speakup@linux-speakup.org>,
        John Covici <covici@ccs.covici.com>,
        Chris Brannon <chris@the-brannons.com>
Message-Id: <8167C459-F35F-44DA-83E4-3BFEF05FC2F0@gmail.com>
References: <20170515174531.968330974@gmail.com> <20170515175627.391877481@gmail.com> <20170516120038.GA5813@kroah.com> <CAOtcWM3_W2N1hJmxGsjtQU7zN7-EH4K79rs1g4ajsjyWVjqk=Q@mail.gmail.com> <20170516122828.GA30371@kroah.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4GCpkTl002117


> On 16 May 2017, at 13:28, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
>> On Tue, May 16, 2017 at 01:19:10PM +0100, Okash Khawaja wrote:
>> Hi,
>> 
>> On Tue, May 16, 2017 at 1:00 PM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>>> On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote:
>>>> This patch fixes the issue where TTY-migrated synths would take a while to shut up after hitting numpad enter key. When calling synth_flush, even though XOFF character is sent as high priority, data buffered in TTY layer is still sent to the synth. This patch flushes that buffered data when synth_flush is called.
>>> 
>>> Minor nit, please line-wrap your changelog text at 72 columns so that I
>>> don't have to do it "by hand".
>> Sure, will do.
>> 
>>> 
>>>> 
>>>> It also tries to ensure that hardware flow control is enabled, by setting CRTSCTS using tty's termios.
>>>> 
>>>> Reported-by: John Covici <covici@ccs.covici.com>
>>>> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
>>>> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>>>> 
>>>> Index: linux-staging/drivers/staging/speakup/serialio.c
>>>> ===================================================================
>>> 
>>> Are you using git?  These lines are odd...
>> They come from quilt. Haven't checked yet if there is an option to
>> turn them off.
> 
> There is, here's what is in my .quiltrc:
> 
> QUILT_REFRESH_ARGS="--diffstat --strip-trailing-whitespace --no-timestamps --no-index --sort -p1 -p ab"
> QUILT_DIFF_ARGS="--no-timestamps --no-index --sort --color=auto -p ab"
> QUILT_DIFF_OPTS="-p"
> 
> That will give you the diffstat in the patch as well, which is always
> helpful to reviewers.

Thanks very much. Will update mine.