From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425050AbcFHMZM (ORCPT ); Wed, 8 Jun 2016 08:25:12 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:34921 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422880AbcFHMZK (ORCPT ); Wed, 8 Jun 2016 08:25:10 -0400 Subject: Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_CE791053-0881-4B74-BAF9-C2209BCD03CB"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.6b2 From: Parth Sane In-Reply-To: <57580C8B.6040204@osg.samsung.com> Date: Wed, 8 Jun 2016 17:55:02 +0530 Cc: Greg KH , Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, punitvara@gmail.com, stillcompiling@gmail.com, bhaktipriya96@gmail.com, "open list:STAGING SUBSYSTEM" , linux-kernel@vger.kernel.org Message-Id: <816BF5CB-9548-4F76-97A3-E3344CAA07CD@gmail.com> References: <1465385265-25558-1-git-send-email-laerdevstudios@gmail.com> <57580227.2080400@osg.samsung.com> <6BD25BE6-1767-43A8-9E48-FC4417ADCE4F@gmail.com> <5758064E.6080709@osg.samsung.com> <1031EAFC-1A5D-4A35-A152-1439EE005108@gmail.com> <57580C8B.6040204@osg.samsung.com> To: Luis de Bethencourt X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Apple-Mail=_CE791053-0881-4B74-BAF9-C2209BCD03CB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 No mate, that aint just cutting it. I tried putting it, maybe i=92m doing something wrong? Regards, Parth > On 08-Jun-2016, at 5:46 PM, Luis de Bethencourt = wrote: >=20 > On 08/06/16 12:58, Parth Sane wrote: >> I=92m trying to fix line 224 but its simply not happening. Can you = help me with this? >> Regards, >> Parth >>> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt = wrote: >>>=20 >>> On 08/06/16 12:37, Parth Sane wrote: >>>>=20 >>>>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt = wrote: >>>>>=20 >>>>> On 08/06/16 12:27, Parth Sane wrote: >>>>>> Multiple parenthesis alignment warnings were thrown by checkpatch = in ieee80211.c >>>>>> This patch effectively fixes that. >>>>>>=20 >>>>>> Signed-off-by: Parth Sane >>>>>>=20 >>>>>> --- >>>>>> drivers/staging/rtl8712/ieee80211.c | 25 = ++++++++++++------------- >>>>>> 1 file changed, 12 insertions(+), 13 deletions(-) >>>>>=20 >>>>> Some of the lines you change are over 80 characters. You could fix = those as well in >>>>> a second patch :) >>>>>=20 >>>>> Thanks, >>>>> Luis >>>>>=20 >>>>=20 >>>> You=92re right on that regard. Maybe once this is accepted I can = come back to other warnings. I will submit other patches meanwhile. >>>> I seriously want to see this driver in the next release! >>>> Regards, >>>> Parth >>>>=20 >>>=20 >>> You can resend this patch and the one fixing the 80 char limit with = the subject >>> prefix [RESEND PATCH v2 x/2]. >>>=20 >>> AFAIK this driver is already in the release, check menuconfig under >>> "Device Drivers > Staging drivers > Realtek RTL8172" >>>=20 >>> Thanks, >>> Luis >>=20 >=20 > Sure. >=20 > You want something like this: > - if (memcmp((pbuf + 2), wpa_oui_type, = sizeof(wpa_oui_type))) > + if (memcmp((pbuf + 2), wpa_oui_type, > + sizeof(wpa_oui_type))) >=20 > You could check for references of how other parts of the code have = solved it > by doing: > git grep memcpy * | grep -v ";" >=20 > I hope that helps. > Luis >=20 >=20 >=20 > Reviewed-by: Luis de Bethencourt --Apple-Mail=_CE791053-0881-4B74-BAF9-C2209BCD03CB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXWA6fAAoJEOzxm4XTqyFiUMQP/0G5D9y9HTiyauOYMtl/LGJs CA+G7go37Ud0e9wDMVPYq42Ds/ND8h4/jCMXalrtgVl+5SKciInmjhSmgtjbfj3K 4qdOvFzWAKQCYIVazoiab1VgtiRkTRyJJkbyoSlRZRFS9XNeRGbft4XnosOVZk/n +Uij+JtNx1PfWd0SwUNF8k+vqZuVtbBySIdh45Lf3nnTM9cajrK87HVMtZQZwl2C tCAzwjqMh3FoMpyT/p3JHwJqdVYI2y7P+hJ0xExd7gC+X25HI0sHf5OaGgej3Q5z r79HMZLopgFUaOSgCeaf3GjFKEr3GzJg8kNpfCawSUYlO8oRx7tfkz8Z760OnKEW 3GHOcoVLBS8HUpcbgGT6FTB28Vqr8N1eyjMc3n/84TRt5cpCjz5qO8Q0S3H4xPB3 FQZZ74KCc/a7EQEVHjtxEILiBPR/k+iLL1KZz+Ig9d/SEDpl9TJvuIn47SZI29ad Xu0DZittYj1bZq2Lh2y6v2qOq9hdk6ZLaSIjblQDI9Il8msHU43nV3gFHwTVdUl8 2h3tehSW58WnbByhLun22SrEQ/rtZL/1GGhVldDXdbxqnqtPVQIDq9VbE46fG0VO zZLjeO8AAbaWoT4yxKn8jw7XGjsz8Pg4zCX6bkigpKVqtXelJAP/pkkQgEK5q69O 1QJ/f1YDVOj7mDTSEdxf =ZUbi -----END PGP SIGNATURE----- --Apple-Mail=_CE791053-0881-4B74-BAF9-C2209BCD03CB--