mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Mario.Limonciello@dell.com>
To: <mika.westerberg@linux.intel.com>, <linux-usb@vger.kernel.org>
Cc: <andreas.noever@gmail.com>, <michael.jamet@intel.com>,
	<YehezkelShB@gmail.com>, <rajmohan.mani@intel.com>,
	<nicholas.johnson-opensource@outlook.com.au>, <lukas@wunner.de>,
	<gregkh@linuxfoundation.org>, <stern@rowland.harvard.edu>,
	<anthony.wong@canonical.com>, <oneukum@suse.com>,
	<ckellner@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 00/25] thunderbolt: Add support for USB4
Date: Wed, 23 Oct 2019 15:55:48 +0000	[thread overview]
Message-ID: <816be093556b466ebb4c645c9933bbc3@AUSX13MPC105.AMER.DELL.COM> (raw)
In-Reply-To: <20191023112154.64235-1-mika.westerberg@linux.intel.com>

> 
> I did not yet add the hw_vendor_id and hw_product_id attributes because I
> clocked that 'dd if=nvm_activeX/nvmem of=/dev/null bs=64 count=2' (that's
> what fwupd does) takes typically less than 10 ms when the controller is powered
> on. That should not slow down fwupd. We can add them later if it is really a
> problem (I'm just trying to avoid adding too much attributes that we need to
> maintain forever).

Maybe the controller going into D3 is the key to why it measured slow for me when
I checked.

> 
> I think patches 1 to 17 can be applied for v5.5 already since they are pretty much
> about adding support for existing Thunderbolt 3 devices to the software
> connection manager. This allows Apple systems with Alpine or Titan Ridge
> controller to work without need to start the firmware. Please let me know if
> there are objections.
> 
> USB4 support patches 18 - 25 have been tested on development hardware but
> since it is rather early stage hardware we have not been able to properly test all
> features such as power management (which is why it is currently missing in this
> series).
> 
> Mika Westerberg (22):
>   thunderbolt: Introduce tb_switch_is_icm()
>   thunderbolt: Log switch route string on config read/write timeout
>   thunderbolt: Log error if adding switch fails
>   thunderbolt: Convert basic adapter register names to follow the USB4 spec
>   thunderbolt: Convert PCIe adapter register names to follow the USB4 spec
>   thunderbolt: Convert DP adapter register names to follow the USB4 spec
>   thunderbolt: Make tb_sw_write() take const parameter
>   thunderbolt: Add helper macro to iterate over switch ports
>   thunderbolt: Refactor add_switch() into two functions
>   thunderbolt: Add support for lane bonding
>   thunderbolt: Add default linking between lane adapters if not provided by
> DROM
>   thunderbolt: Expand controller name in tb_switch_is_xy()
>   thunderbolt: Add downstream PCIe port mappings for Alpine and Titan Ridge
>   thunderbolt: Add Display Port CM handshake for Titan Ridge devices
>   thunderbolt: Add Display Port adapter pairing and resource management
>   thunderbolt: Add bandwidth management for Display Port tunnels
>   thunderbolt: Do not start firmware unless asked by the user
>   thunderbolt: Make tb_find_port() available to other files
>   thunderbolt: Call tb_eeprom_get_drom_offset() from tb_eeprom_read_n()
>   thunderbolt: Add initial support for USB4
>   thunderbolt: Update Kconfig entry to USB4
>   thunderbolt: Update documentation with the USB4 information
> 
> Rajmohan Mani (3):
>   thunderbolt: Make tb_switch_find_cap() available to other files
>   thunderbolt: Add support for Time Management Unit
>   thunderbolt: Add support for USB 3.x tunnels
> 
>  .../ABI/testing/sysfs-bus-thunderbolt         |  28 +
>  Documentation/admin-guide/thunderbolt.rst     |  25 +-
>  drivers/Makefile                              |   2 +-
>  drivers/net/Kconfig                           |   2 +-
>  drivers/thunderbolt/Kconfig                   |  11 +-
>  drivers/thunderbolt/Makefile                  |   4 +-
>  drivers/thunderbolt/cap.c                     |  17 +-
>  drivers/thunderbolt/ctl.c                     |   8 +-
>  drivers/thunderbolt/eeprom.c                  | 146 +--
>  drivers/thunderbolt/icm.c                     | 157 +--
>  drivers/thunderbolt/lc.c                      | 193 +++-
>  drivers/thunderbolt/nhi.c                     |   3 +
>  drivers/thunderbolt/nhi.h                     |   2 +
>  drivers/thunderbolt/path.c                    |  52 +-
>  drivers/thunderbolt/switch.c                  | 943 +++++++++++++++---
>  drivers/thunderbolt/tb.c                      | 536 ++++++++--
>  drivers/thunderbolt/tb.h                      | 182 +++-
>  drivers/thunderbolt/tb_msgs.h                 |   2 +
>  drivers/thunderbolt/tb_regs.h                 | 160 ++-
>  drivers/thunderbolt/tmu.c                     | 383 +++++++
>  drivers/thunderbolt/tunnel.c                  | 527 +++++++++-
>  drivers/thunderbolt/tunnel.h                  |  19 +-
>  drivers/thunderbolt/usb4.c                    | 763 ++++++++++++++
>  drivers/thunderbolt/xdomain.c                 |  11 +-
>  24 files changed, 3718 insertions(+), 458 deletions(-)  create mode 100644
> drivers/thunderbolt/tmu.c  create mode 100644 drivers/thunderbolt/usb4.c
> 
> --
> 2.23.0


  parent reply	other threads:[~2019-10-23 15:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 11:21 Mika Westerberg
2019-10-23 11:21 ` [PATCH 01/25] thunderbolt: Introduce tb_switch_is_icm() Mika Westerberg
2019-10-23 11:21 ` [PATCH 02/25] thunderbolt: Log switch route string on config read/write timeout Mika Westerberg
2019-10-23 11:21 ` [PATCH 03/25] thunderbolt: Log error if adding switch fails Mika Westerberg
2019-10-23 11:21 ` [PATCH 04/25] thunderbolt: Convert basic adapter register names to follow the USB4 spec Mika Westerberg
2019-10-23 11:21 ` [PATCH 05/25] thunderbolt: Convert PCIe " Mika Westerberg
2019-10-23 11:21 ` [PATCH 06/25] thunderbolt: Convert DP " Mika Westerberg
2019-10-23 11:21 ` [PATCH 07/25] thunderbolt: Make tb_sw_write() take const parameter Mika Westerberg
2019-10-23 11:21 ` [PATCH 08/25] thunderbolt: Add helper macro to iterate over switch ports Mika Westerberg
2019-10-23 11:21 ` [PATCH 09/25] thunderbolt: Refactor add_switch() into two functions Mika Westerberg
2019-10-23 11:21 ` [PATCH 10/25] thunderbolt: Add support for lane bonding Mika Westerberg
2019-10-23 11:21 ` [PATCH 11/25] thunderbolt: Add default linking between lane adapters if not provided by DROM Mika Westerberg
2019-10-23 11:21 ` [PATCH 12/25] thunderbolt: Expand controller name in tb_switch_is_xy() Mika Westerberg
2019-10-23 11:21 ` [PATCH 13/25] thunderbolt: Add downstream PCIe port mappings for Alpine and Titan Ridge Mika Westerberg
2019-10-23 11:21 ` [PATCH 14/25] thunderbolt: Add Display Port CM handshake for Titan Ridge devices Mika Westerberg
2019-10-23 11:21 ` [PATCH 15/25] thunderbolt: Add Display Port adapter pairing and resource management Mika Westerberg
2019-10-23 11:21 ` [PATCH 16/25] thunderbolt: Add bandwidth management for Display Port tunnels Mika Westerberg
2019-10-23 11:21 ` [PATCH 17/25] thunderbolt: Do not start firmware unless asked by the user Mika Westerberg
2019-10-23 11:21 ` [PATCH 18/25] thunderbolt: Make tb_find_port() available to other files Mika Westerberg
2019-10-23 11:21 ` [PATCH 19/25] thunderbolt: Call tb_eeprom_get_drom_offset() from tb_eeprom_read_n() Mika Westerberg
2019-10-23 11:21 ` [PATCH 20/25] thunderbolt: Add initial support for USB4 Mika Westerberg
2019-10-23 11:21 ` [PATCH 21/25] thunderbolt: Update Kconfig entry to USB4 Mika Westerberg
2019-10-23 11:21 ` [PATCH 22/25] thunderbolt: Make tb_switch_find_cap() available to other files Mika Westerberg
2019-10-23 11:21 ` [PATCH 23/25] thunderbolt: Add support for Time Management Unit Mika Westerberg
2019-10-23 11:21 ` [PATCH 24/25] thunderbolt: Add support for USB 3.x tunnels Mika Westerberg
2019-10-23 11:21 ` [PATCH 25/25] thunderbolt: Update documentation with the USB4 information Mika Westerberg
2019-10-23 15:55 ` Mario.Limonciello [this message]
2019-10-23 16:18   ` [PATCH 00/25] thunderbolt: Add support for USB4 Mika Westerberg
2019-11-01 11:43 ` Mika Westerberg
2019-11-04 14:31   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=816be093556b466ebb4c645c9933bbc3@AUSX13MPC105.AMER.DELL.COM \
    --to=mario.limonciello@dell.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=anthony.wong@canonical.com \
    --cc=ckellner@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=nicholas.johnson-opensource@outlook.com.au \
    --cc=oneukum@suse.com \
    --cc=rajmohan.mani@intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®