mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hanjun Guo <guohanjun@huawei.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/4] ACPI: processor: Get rid of ACPICA message printing
Date: Thu, 25 Feb 2021 22:17:40 +0800	[thread overview]
Message-ID: <816edceb-983b-03d7-4a96-d325658417fd@huawei.com> (raw)
In-Reply-To: <CAJZ5v0hwouj_1KpZ_RrC3r50RxngvinBBJVgNhQkwA3bw0oXag@mail.gmail.com>

On 2021/2/25 2:06, Rafael J. Wysocki wrote:
> On Tue, Feb 23, 2021 at 3:45 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>
>> On Tue, Feb 23, 2021 at 12:31 PM Hanjun Guo <guohanjun@huawei.com> wrote:
>>>
>>> On 2021/2/23 2:59, Rafael J. Wysocki wrote:
>>>> Index: linux-pm/drivers/acpi/processor_idle.c
>>>> ===================================================================
>>>> --- linux-pm.orig/drivers/acpi/processor_idle.c
>>>> +++ linux-pm/drivers/acpi/processor_idle.c
>>>
>>> In this file, function acpi_processor_cstate_first_run_checks()
>>> has a wrong pr_notice():
>>>
>>> pr_notice("ACPI: processor limited to max C-state %d\n",
>>>                  max_cstate);
>>>
>>> Since we have pr_fmt() for this file, "ACPI:" is duplicate,
>>> we'd better cleanup this as below:
>>>
>>> pr_notice("processor limited to max C-state %d\n", max_cstate);
>>
>> Thanks for pointing this out, I'll make this change when applying the patch.
> 
> Actually, this issue is not strictly related to the patch here, so I'm
> going to send a separate patch to fix it.

Make sense to me as well.

Thanks
Hanjun

  reply	other threads:[~2021-02-25 14:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 18:57 [PATCH v1 0/4] ACPI: Get rid of ACPICA message printing from core Rafael J. Wysocki
2021-02-22 18:59 ` [PATCH v1 1/4] ACPI: processor: Get rid of ACPICA message printing Rafael J. Wysocki
2021-02-23 11:30   ` Hanjun Guo
2021-02-23 14:45     ` Rafael J. Wysocki
2021-02-24 18:06       ` Rafael J. Wysocki
2021-02-25 14:17         ` Hanjun Guo [this message]
2021-02-22 18:59 ` [PATCH v1 2/4] ACPI: sysfs: " Rafael J. Wysocki
2021-02-22 19:00 ` [PATCH v1 3/4] ACPI: Drop unused ACPI_*_COMPONENT definitions and update documentation Rafael J. Wysocki
2021-02-22 19:01 ` [PATCH v1 4/4] ACPI: HED: Drop unused ACPI_MODULE_NAME() definition Rafael J. Wysocki
2021-02-23 11:50 ` [PATCH v1 0/4] ACPI: Get rid of ACPICA message printing from core Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=816edceb-983b-03d7-4a96-d325658417fd@huawei.com \
    --to=guohanjun@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®