From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5676031327D for ; Mon, 8 Jun 2026 10:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780914271; cv=none; b=iUArILV4JZtSawxo6Y2JZcn0zY0dj52Dl579zS3hbt+Tclw6Btje+fYgqi1n4ISYdB6VP6TYsj03+elGRSHYyETwgkOIgZcyWA3rSr/Pt971/KawLZEflrJLsziLtSiUCULknFKdcPe/ND8oX30uzsVmZtrDH2SqespRC/Ug/fQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780914271; c=relaxed/simple; bh=ry0/wyfJvjHyRLLbRU3tqt5QD+4LC8uoNFaeEFr/D0U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tp4Z2GDs1AdIeh7KKhufAEpHCT9YKyhIKVm9V8EjULfvfWfapL/eGxXpkzVpbDg6jbeZKsOTrrYzgWIkno0MWKoEVseqv1A+Bd+JuYNkaPD+oikfxZDTyn8MbdPQ3cQ5bZIYOgbcyEJZWa1XAThdR/UsaOSVhQtoKUSPqCKX9PY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MoWRIXR9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CJSzLX1J; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MoWRIXR9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CJSzLX1J" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586PkIv2733114 for ; Mon, 8 Jun 2026 10:24:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xl18tt9uabj/nguluA4JVVRo9uAXjAMzBlxUvfENfq0=; b=MoWRIXR9JaXxt15l iYNkPZum6uBiwgomMuT3IxFz+D1u3ygV1S1vG4NhmYqD1Wafxwi07nIAA2MGGEVb apuK262xH6yiKTW1nCfTWqsBKO3cUZF2HsEYCauEbxdyWDuVaT/M18aet7PzC3fm DczfJ5qcXgdCfjFrHM+IrE4+DM+eYo89KwsLChZNNNGtie++brQfOkHxCuBwTjOn OSyqz2oKJM3UPa/KCGpujWMdmq2aA7V6OF7HO1Ao8+tHQgsHqW8NxcOQq2PlBdPu PGImVGsuL4XeKNjtCpehcaIRYFb6DnF9qbuoNMgwKrIbJNURlp/rs/rIN5Fd6YT3 sy6aNg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4emavf7ecf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 10:24:29 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2bf3636d6c0so45034435ad.2 for ; Mon, 08 Jun 2026 03:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780914268; x=1781519068; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xl18tt9uabj/nguluA4JVVRo9uAXjAMzBlxUvfENfq0=; b=CJSzLX1JXDoxYPQVuSj9oV0lbVkKCwLqdCf+99GpjnDxwEpl92BdZIidK6B3I1CTYJ SJioQb/lUjZEqVcm6A0RuGfIO9njS2f0Y5NR9SyRbz6u2ENhL+5m21MzpXtklodTm9S1 +epzkTfz/0LR0tphCvSIv9NlYz2i9C6W6xaGxxBRCeYfbK+T4lenrURvbyCDsf6Z8bL1 jgXi8P80nEZ0NxHDWEnf5i2SupYSdrkUcPf0kvu0uVe9EU4lYCPNJ0DpIUJ4FsbtbbV3 O7YBaq13Pk+vQvvMuyHC1twMCllgXokegk35fQYasuHRGdLQYr0SYsOE+IiiLZyARWOL jmqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780914268; x=1781519068; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xl18tt9uabj/nguluA4JVVRo9uAXjAMzBlxUvfENfq0=; b=EEGNMAWZOoQ3FZnOSEsdQtRIublEHHel9HttdeaEpFho0MXrvY08wg36DcObfl19Lw aotyT7nGMwrBltJAYjNkArPe7MCVugMfKUc/vnG7EsvGHeOtnS1FuerlD9ujLn7zLJ8O AJFZOOIuZ0cqNhGUTUXlN2s1TN1QJQK1uyxHvjogZP1ifkgia/+DsHEgemJ6e+K8V/FO SXJm/7ttznhL68InbK9crNXdkW5deNuqyohKErm7yHYSpkbbige3EDdNCP7bO5N+DjPb s0CyoWD7yIJjqfifZN3ZveMh0PEj7JqC8JS/OaMDeTaEat0ADls4puXWZ9ECVC56Oz+v KS8A== X-Forwarded-Encrypted: i=1; AFNElJ8RcT2KLGo0pa/j0svAcTy0qOVyXLVIv/ljEjtNAztZsAbk0FoTCbxx2nNw+tUO0+sC6Ji8Cn6NShs+W1I=@vger.kernel.org X-Gm-Message-State: AOJu0Yyq/esn3OP6/B/OYII+fm+9jSmGLpzte+XSJyB0o65SuFAhz9B2 qo+qvZ9CHLTMlq7HBWTM30YNpjPlOUH9GwQMoyXYvHS7K8ouu6sz2KQ9aTh3/vl4Jl9//52w9Qe x2wO5ykIHCrKKsMzq08Re6cDp02V/WpaCBRlO5U4tE8p8DgYZFC9DS2oYgqzstZjZVnU= X-Gm-Gg: Acq92OHyNqzZKzM/g5ig5Rkxb8swD0gJspntdAt1TOrPH+9HmBt79Y89qAoYhAL65Fd uAilupL5Xo98SzTv4irji2cZkC4zzoKfut6vnx/vYkffIAib4jgHt0CmjDUxDK9WwOK94jm6Qo0 VhhJqMKIJ+yQ+PSP9Fj4BWGePqw7tchauzfauSPYtMY+/fYyjZVn32GLBcRKmcLkjtp+1AhirC4 /MYsE5M1csY73h5QR9nHwjBjvIPxU2JfdhIaLGDGT8EiWKrKduSdH7eEq/FR5T7u02ysaHSociL FP5gZo6xOOwU/F9Wob7cjB6V1T2aoWIG9GbrLjOPw6eD0CUoAppETAlv/Egdv7zWQxvcIM9HhQi KRdCoN18PpMaB8KkUQV/OV55Q7YQ+hZAYClseByE+uIBg71qafR12udIdS67ABA== X-Received: by 2002:a17:903:faf:b0:2c0:ca99:3d73 with SMTP id d9443c01a7336-2c1e7b2f203mr167666795ad.8.1780914268104; Mon, 08 Jun 2026 03:24:28 -0700 (PDT) X-Received: by 2002:a17:903:faf:b0:2c0:ca99:3d73 with SMTP id d9443c01a7336-2c1e7b2f203mr167666315ad.8.1780914267621; Mon, 08 Jun 2026 03:24:27 -0700 (PDT) Received: from [10.206.100.243] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d37esm237322705ad.9.2026.06.08.03.24.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 03:24:26 -0700 (PDT) Message-ID: <81724048-0cb1-4305-b613-374c14df87d5@oss.qualcomm.com> Date: Mon, 8 Jun 2026 15:54:20 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7807S panel controller To: Dmitry Baryshkov Cc: Krzysztof Kozlowski , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ayushi Makhija , rajeevny@qti.qualcomm.com References: <20260518-ili7807s-panel-v1-0-d7b048163b1c@oss.qualcomm.com> <20260518-ili7807s-panel-v1-1-d7b048163b1c@oss.qualcomm.com> <20260519-curly-courageous-sturgeon-2facfe@quoll> Content-Language: en-US From: Arpit Saini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I4JVgtgg c=1 sm=1 tr=0 ts=6a26985d cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=IV4c8OSHAAAA:8 a=OE-cVudxAAAA:8 a=8Tz7o-WSTiqKbu9PhaEA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=Q6n48rkgcAvIKCAITAMI:22 a=xpPxSgvXB0Ioxg6u-DGP:22 X-Proofpoint-ORIG-GUID: LeutjmrNk-BAodFYuGuhlkJNbBw3HwgL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA5NyBTYWx0ZWRfXwP805pV66F5b MWEQ4QmeKmJBV5tUtBl8XX6fG7F/8u8uZrszfz/N5xhCKWaqT1kh4+nK5ljp2rHmnrOyyQONEt1 AHU5czA+5hex7Jm8N4RFHJV1nNS22DO8zO3LmKE+/TI9QzckE/EpIcSz0VpwBVvQGi9+dY7S41q fBdGEBpF8tPwVMki2t3+P/UqxPCFF2+T/QMoTCtONIqLiYao14IoowveS1dOBXhlADhqzTHfgXx Gfkn1TYtNDhdZeBtZ0cybanogkMWks2MOT8PaPd82zdNF6DiZ0+rHjAE+xA68TANG0BygjxzHPb PWF/vPvNk6os1bG357myX6jAF1qLOvJEVkpr0oGp9Nv3JC8+ilu/3jq9+w9r4cu3hkgApAwKP6d s2T9ebMBQPEoPJKhiNUR+VCVWoS0BZQpOT0fdLY/y4NvcgRHxtTuzxq+fABc4v13k5rkLFCnMxw v/0lKTT5vOz8Z0O0Xxw== X-Proofpoint-GUID: LeutjmrNk-BAodFYuGuhlkJNbBw3HwgL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080097 Hi Krzysztof , Dmitry On 6/6/2026 5:43 PM, Dmitry Baryshkov wrote: > On Tue, May 26, 2026 at 04:02:45PM +0530, Arpit Saini wrote: >> Hi Krzysztof , Dmitry >> >> On 5/20/2026 6:56 PM, Dmitry Baryshkov wrote: >>> On Wed, May 20, 2026 at 06:10:57PM +0530, Arpit Saini wrote: >>>> Hi Krzysztof , Dmitry >>>> >>>> On 5/19/2026 4:02 PM, Krzysztof Kozlowski wrote: >>>>> On Mon, May 18, 2026 at 04:34:12PM +0530, Arpit Saini wrote: >>>>>> ILI7807S is a DSI display controller used to drive MIPI-DSI panels. >>>>>> The DLC DLC0697 1080x1920 LCD panel is based on this controller. >>> >>> I can't find this panel on the DLC website. Do you have a pointer to the >>> product page? >>> >> https://v4.cecdn.yun300.cn/100001_2012175013/DLC0697AAL21MF-1.pdf > > "Invalid referrer" > I should have shared the full part No. DLC0697AAL21MF https://www.dlcdisplay.com/Resources/1760134404595535872-435-15.html >>>>>> >>>>>> The panel requires a reset GPIO, backlight enable GPIO, I/O voltage >>>>> >>>>> If panel requires it, so should the binding. >>>>> >>>> Ack, I will update. >>>>> ... >>>>> >>>>>> + reg: >>>>>> + maxItems: 1 >>>>>> + description: DSI virtual channel >>>>>> + >>>>>> + reset-gpios: true >>>>>> + >>>>>> + backlight-en-gpios: >>>>>> + description: Backlight enable GPIO (active high) >>>>> >>>>> What is the name of the pin in ili7807s device? >>>>> >>>> Display daughter card has WLED driver as well as LCD bias driver. >>> >>> What is the display daughter card here? Is it a Qualcomm board or is it >>> a part of the panel? >>> >>> Also you wrote a lot of text, but you didn't really answer either of the >>> quesitons. Is there a GPIO on the panel connector that enables the >>> backlight? If not, this is some external supply on your (assumingly) >>> daughter card. And it should be modelled accordingly. > > Still unanswered. > Display daughter card is Qualcomm board. I misunderstood it, I shouldn't added the backlight-en-gpios in my dt-bindings, I apologize for not answering clearly earlier. The backlight enable GPIO is on the Qualcomm daughter card, not on the panel connector. I will remove backlight-en-gpios from the panel binding and model the backlight enable gpio at the board level. >>> >>>> >>>> The WLED driver's Enable is coming from WLED_P1_EN and PWM is coming from >>>> LCD_CABC output of the panel. >>>> >>>> DISPLAY0_BACKLIGHT_ENABLE (GPIO 91) of ITP baseband card ==> WLED_P1_EN of >>>> Display Daughter Card (DC) >>>> >>>> In the display daughter card of Shikra ITP platform, we are not using the >>>> external PWM for WLED driver. But connected the CABC output of the panel to >>>> the WLED driver. Backlight update is happening using MIPI DCS command which >>>> is driving the CABC output (i.e., PWM for WLED). >>>> >>>> Because of above HW configuration, we need to enable the MIPI DCS brightness >>>> update on this panel. The below command of dlc0697_init_sequence() is >>>> enabling this. >>>> mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x24); >>> >>> So, this should be then dependent on the presence of the backlight in >>> the DT. Either it is a panel-internal one, or an external one. >>> >>>> >>>> >>>> After checking this, I realized that this panel can be used without the DCS >>>> backlight as well when it's using PWM based backlight control. >>>> >>>> I can add `has_dcs_backlight` in panel_desc and set it true for dlc0697. I >>>> will update bindings and add backlight as optional property. >>> >>> Why? Use backlight property instead. It's already there. Anyway, you >>> really, really need to describe the panel in the bidings. Not your >>> daughter card. >>> >> This `has_dcs_backlight` in panel_desc will serves both the purpose, as for >> our current platform constraint , we need to create our own backlight. >> But this panel can be used without the DCS >> backlight as well when it's using PWM based backlight control. >> >> So in this case I need to implement the backlight as implemented in >> panel-novatek-nt36523.c, panel-himax-hx83121a.c. >> >> with this implementation ,I will remove the backlight from the dt-bindings. > > Much easier. Call drm_panel_of_backlight() and if there is no error and > panel->backlight is still NULL, then create your own backlight device. > okay I understood, I will not use the has_dcs_backlight. will proceed as you told. >> >> Please let me know,if I am missing something. >> >> Thanks, >> Arpit >> >> >