From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D3ECE79CE for ; Wed, 20 Sep 2023 12:27:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235739AbjITM1a (ORCPT ); Wed, 20 Sep 2023 08:27:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235894AbjITM1X (ORCPT ); Wed, 20 Sep 2023 08:27:23 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39AC0E6 for ; Wed, 20 Sep 2023 05:27:17 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-530e180ffcbso4543405a12.1 for ; Wed, 20 Sep 2023 05:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695212835; x=1695817635; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Hv2thh1H9tA97kPGliYAF+DpZy/mFhBKmC18f7g/H+8=; b=gTBJ71bQIeIVolDEZJIODZhuDnrWLqps9SijgyLrQpTQpXNDl9CsRDpdrRglaEzyXt ekH0Q8wd2rJ4Owa7f9X2BbRnw/qbqbDOsaumPnTlh/g4zKTuSCenS0zQ14CWkARLV/Uk 0EYW7KYQ051zL1sXCEDJCdLP124OkKiOiJtwLwDkHvM9vLx9wkUve5bR19cRE0YTCypp YJwpbky8d4Vh2Q/Bs0m06gPnjkZNIg69iSKvc5e9zCVdyvrfkakTOjt8xM+aclIPoqif IKs/KvlvQHpXnJjGkI41sWdEgDtY4LwEgnsKFNbSqi1SpxN1aUbuu51YzbAhIrYDE21V NmSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695212835; x=1695817635; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hv2thh1H9tA97kPGliYAF+DpZy/mFhBKmC18f7g/H+8=; b=BWIvlW60e/3sBkB3fTBWub/JhT0W8EtMEh7IVy0kD5ztN0rb7fjcn35/LIugHdc4bv 01St59+R6J9tNOF5FDP+liEryBhy77yzMfofudvvf819Diq4j+Zq7dJMlBxVtlDXrBzi BxsnWGq780qLZ7fDiafk3x5C/QLlgDAribf3NvG2brZkWD8GTQfuoX6RFHfjvJV/eu7q KmoDrf1jJrn3G7IEo5KbZBzqg51nd/lhSSFG3dk7zvbTLzSc6qaBgS8Bh28kC9IqJF8F oCdz6w3e25qAMgfT/lYDGavXg+ekX6WxSC7osPQPuM2gZ88tWGDC56B4l142V4mAa2Df aKoA== X-Gm-Message-State: AOJu0YxJmQC+lGf133H7JchNXnzX2OXlFqv9qrqi+rbA8pwvWqDFaYZv ldmk6w90290YUfNnp91XZRVbOGl1yhZskN1EXMwJ8w== X-Google-Smtp-Source: AGHT+IGhilnDj/sus5JakUZtSo3PYNc+I+MMntBHtlUMM1+I1hu3v/I4zTxsAW6rKgXqdzXJYZ8m6w== X-Received: by 2002:a17:906:2ce:b0:9a5:846d:d81f with SMTP id 14-20020a17090602ce00b009a5846dd81fmr1726172ejk.17.1695212835687; Wed, 20 Sep 2023 05:27:15 -0700 (PDT) Received: from [172.20.24.238] (static-212-193-78-212.thenetworkfactory.nl. [212.78.193.212]) by smtp.gmail.com with ESMTPSA id z18-20020a1709060ad200b009887f4e0291sm9210859ejf.27.2023.09.20.05.27.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 05:27:14 -0700 (PDT) Message-ID: <817a2b0c-cc90-e109-0b8d-4283f0ac2610@linaro.org> Date: Wed, 20 Sep 2023 14:27:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 3/3] media: exynos4-is: fimc-is: replace duplicate pmu node with phandle Content-Language: en-US To: Sylwester Nawrocki , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230815060739.30160-1-krzysztof.kozlowski@linaro.org> <20230815060739.30160-3-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230815060739.30160-3-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/2023 08:07, Krzysztof Kozlowski wrote: > Devicetree for the FIMC IS camera included duplicated PMU node as its > child like: > > soc@0 { > system-controller@10020000 { ... }; // Real PMU > > camera@11800000 { > fimc-is@12000000 { > // FIMC IS camera node > pmu@10020000 { > reg = <0x10020000 0x3000>; // Fake PMU node > }; > }; > }; > }; > > This is not a correct representation of the hardware. Mapping the PMU > (Power Management Unit) IO memory should be via syscon-like phandle > (samsung,pmu-syscon, already used for other drivers), not by duplicating > "pmu" Devicetree node inside the FIMC IS. Backward compatibility is > preserved. Hey Mauro, This patchset is waiting a bit. Patchwork: https://patchwork.linuxtv.org/project/linux-media/list/?series=11051 This is a cleanup which blocks further DTS cleanup changes. Any comments from your side? Best regards, Krzysztof