From: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
To: Namjae Jeon <linkinjeon@kernel.org>,
Sung Byeongchan <tjdqudcks0424@naver.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Tom Talpey <tom@talpey.com>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ksmbd: validate share path for batch oplock reconnects
Date: Thu, 8 Oct 2026 11:58:41 +0800 [thread overview]
Message-ID: <817aca1f-5e17-418c-9bd9-c2a0180ca9f1@chenxiaosong.com> (raw)
In-Reply-To: <CAKYAXd9sNGp8G8N0D=4a_SX89L7zGGGcH_kN0r7WUhvur=fc=g@mail.gmail.com>
On 10/7/2026 10:51 PM, Namjae Jeon wrote:
>> @@ -2489,9 +2489,10 @@ int smb2_check_durable_oplock(struct ksmbd_conn *conn,
>> if (opinfo->level != SMB2_OPLOCK_LEVEL_BATCH) {
>> pr_err("oplock level is not equal to SMB2_OPLOCK_LEVEL_BATCH\n");
>> ret = -EBADF;
>> + goto out;
>> }
>>
>> - goto out;
>> + goto validate_name;
> SMB specification(MS-SMB2) explicitly skip path name validation. The
> filename mismatch check applies only to lease-based opens
> (opinfo->is_lease in ksmbd). This violates the reconnect semantics.
Yes, see MS-SMB2 3.3.5.9.7
--
ChenXiaoSong <chenxiaosong@chenxiaosong.com>
Chinese Homepage: https://chenxiaosong.com
English Homepage: https://chenxiaosong.com/en
prev parent reply other threads:[~2026-10-08 3:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 7:44 Sung Byeongchan
2026-10-07 14:51 ` Namjae Jeon
2026-10-08 3:58 ` ChenXiaoSong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=817aca1f-5e17-418c-9bd9-c2a0180ca9f1@chenxiaosong.com \
--to=chenxiaosong@chenxiaosong.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=tjdqudcks0424@naver.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®