From: Shaoqin Huang <shahuang@redhat.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: Marc Zyngier <maz@kernel.org>,
kvmarm@lists.linux.dev, Mark Brown <broonie@kernel.org>,
Eric Auger <eauger@redhat.com>, Sebastian Ott <sebott@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] KVM: arm64: Disable fields that KVM doesn't know how to handle in ID_AA64PFR1_EL1
Date: Thu, 18 Jul 2024 14:58:20 +0800 [thread overview]
Message-ID: <817b5f2b-ec69-4a66-ad7b-ea8c8b9d0f24@redhat.com> (raw)
In-Reply-To: <ZpixhBjsqhWTpEQH@linux.dev>
Hi Oliver,
On 7/18/24 14:09, Oliver Upton wrote:
> Hi Shaoqin,
>
> On Wed, Jul 17, 2024 at 11:50:14PM -0400, Shaoqin Huang wrote:
>> For some of the fields in the ID_AA64PFR1_EL1 register, KVM doesn't know
>> how to handle them right now. So explicitly disable them in the register
>> accessor, then those fields value will be masked to 0 even if on the
>> hardware the field value is 1.
>
> It is probably important to note that the only reason this is safe to do
> from a UAPI POV is that read_sanitised_ftr_reg() doesn't yet return a
> nonzero value for any of these fields.
(Reply again by the plain text)
Yeah. That would be more clear if I tell the reader this information.
Will add this when updating.
Thanks,
Shaoqin
>
--
Shaoqin
next prev parent reply other threads:[~2024-07-18 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 3:50 [PATCH v4 0/3] Allow userspace to change ID_AA64PFR1_EL1 Shaoqin Huang
2024-07-18 3:50 ` [PATCH v4 1/3] KVM: arm64: Disable fields that KVM doesn't know how to handle in ID_AA64PFR1_EL1 Shaoqin Huang
2024-07-18 6:09 ` Oliver Upton
2024-07-18 6:58 ` Shaoqin Huang [this message]
2024-07-18 3:50 ` [PATCH v4 2/3] KVM: arm64: Allow userspace to change ID_AA64PFR1_EL1 Shaoqin Huang
2024-07-18 6:35 ` Oliver Upton
2024-07-18 8:21 ` Shaoqin Huang
2024-07-18 3:50 ` [PATCH v4 3/3] KVM: selftests: aarch64: Add writable test for ID_AA64PFR1_EL1 Shaoqin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=817b5f2b-ec69-4a66-ad7b-ea8c8b9d0f24@redhat.com \
--to=shahuang@redhat.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cohuck@redhat.com \
--cc=eauger@redhat.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=sebott@redhat.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®