From: Siarhei Liakh <sliakh.lkml@gmail.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-next@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
James Morris <jmorris@namei.org>,
Andrew Morton <akpm@linux-foundation.org>, Andi Kleen <ak@muc.de>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Dave Jones <davej@redhat.com>
Subject: Re: [PATCH v8] RO/NX protection for loadable kernel modules
Date: Mon, 1 Feb 2010 11:22:45 -0500 [thread overview]
Message-ID: <817ecb6f1002010822j769ccda6wfc39c0dbd42420cd@mail.gmail.com> (raw)
In-Reply-To: <201002011209.13540.rusty@rustcorp.com.au>
> Needs more brackets around arguments, otherwise someone calling it with
> a complex expression will get very upset.
[...]
Done.
> The core_text_size test should be enough here.
Done.
>> + begin_pfn = PFN_DOWN((unsigned long)mod->module_core);
>> + end_pfn = PFN_DOWN((unsigned long)mod->module_core +
>> + mod->core_text_size);
>> + if (end_pfn > begin_pfn)
>> + set_memory_rw(begin_pfn << PAGE_SHIFT,
>> + end_pfn - begin_pfn);
>
> Much of this code might be neater if you created a helper:
Done.
> But these are minor: patch looks good!
Thanks for your feedback!
next prev parent reply other threads:[~2010-02-01 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 23:22 Siarhei Liakh
2010-02-01 1:39 ` Rusty Russell
2010-02-01 16:22 ` Siarhei Liakh [this message]
2010-02-02 23:05 ` Andi Kleen
2010-02-03 4:07 ` Siarhei Liakh
2010-02-08 1:45 ` Rusty Russell
2010-02-08 1:54 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=817ecb6f1002010822j769ccda6wfc39c0dbd42420cd@mail.gmail.com \
--to=sliakh.lkml@gmail.com \
--cc=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®