From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B6132F28FC for ; Fri, 15 May 2026 01:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778808720; cv=none; b=eVwrur/0XxVLUsKv6AEeLGkEfvRTozqHnULjhv5V1tEc7p+17miWj1+3LbrYw97hhJGlLk2FGInriZuh8lTz2RvqBpExQnmDjQRAoiPnOF/nFU3u8XG9ECD3qx1fAN0wiVcx+VKvAnsUQxoeUqSTClv49kOgxdsAzFVyRlhI+QQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778808720; c=relaxed/simple; bh=usEwnKkEaTPE+yU5TGR0oURw8nv72W+T5MSwsVZgYLE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R1vNV9f6lVrdD9UYrJcqMJIXiGjvl2cQ6nRbTFUgy2RXbJHG46qBYh2An/UC18qCQHiBp6k0KKXKnZWHilP+OysIm2GwKKxuiYgzYcPK8oRttHMdyBI4L8HRqn6o31Twiu5Tc7zPHXoHMayosUdQylVBxcsOxruBKuNPD2tldPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cBhnEuQ0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NnbWlBNO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cBhnEuQ0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NnbWlBNO" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64EIpgxN3512955 for ; Fri, 15 May 2026 01:31:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HxJXpfYBS7mpaWwbnqYYsS+05m4PCWFY64z260Mm9fM=; b=cBhnEuQ0Yie0TnAK ERP5nO11N4a6rv1v443pUEQeOIvJNTeSB+U/1IIHjNRqGwplsJegcwpCjkkTDewn 2wtiyff9ZRDB0oC+8HLS/V0GBHVksQdQnUHzhioXaNopAWQoi9lVInwwdYdpcnQm +gq/+WiuOlqzUA+vofQPAueWWx8YHQZwSVU56+OQLrG30Ao83W9tthtIWeYVNGU3 IFIYNpFW08vYFTxBkz7bAomDrDQMoSLF8nrhtbSJIiNlbU6kRq9/na80VYGPQt+p T7Ep6Xgr7SgZ7pUiK8q9rudAGVn3fv6de9pX1Chx0QtyuatsztnI+Me50mwrQ1Sj Fto94w== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1v91a7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 01:31:57 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2babbeff9e4so4441895ad.0 for ; Thu, 14 May 2026 18:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778808717; x=1779413517; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HxJXpfYBS7mpaWwbnqYYsS+05m4PCWFY64z260Mm9fM=; b=NnbWlBNOEbudVYwcjMnnf1tvDQC49sD+xCBoK7f6hwQeCjGitL7m8RHR4JvYRnPh9H WZFIc7ZNOxkiqJ91DIDmAqXlinyGJonz6CXxxIJvSf1aXWk/DoD7RF4GDwtj6qLmNExp UtCqzurrJsj/kmOeg6TYE42d6aUQvwQnGMatW/46qaJXm999yD94blD7CR99JRR2TJjt 4nPGCg+MDt5NylSVVjaNs5ELbA+QDHUjLhCkdpCFlhOgV497dzRDnQVJqeB0TpvEvhTf gMuw7sRfDZdoCSgXN5EAJf6udymC1Xti7BsH8WzoDtBpLoF6pU6NjtlKJwk794J55H1I zZvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778808717; x=1779413517; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HxJXpfYBS7mpaWwbnqYYsS+05m4PCWFY64z260Mm9fM=; b=nP96hf/G5v3SOF+OdRs8M27X2S+5j7SHqXKwA9tp09xO8uKuztbDOElBkvfjPJX74K 8qK6eyaJkLiPtlvhq2QjlroO6d9k/h2rNVZn8gSbpCVU5YZFgLsv5TKoEeJi7aKKFfPe a/HGfJYm/vFXPs1MfzpDBfqSkpKVgPdyyBACWtYW6DWBcWep3OR7Bo0JcdaG3vhnBDAR aCpw6ek4h9xRM5hh4GFPncr/S79jog+BLTqQp6U4TK/WrQhRVxNu/MbIbtJhjBjaG8zX pTPzfO+riUlQYsFlNdzaAESdKRcc22eXxDexPiuNCGqtK46ta8EJSKjGhPjQ1nCdg4P7 mZzA== X-Forwarded-Encrypted: i=1; AFNElJ+Ny5FMzPTywV1szrrBK9xbJXyqJ18FHYuMqjwhfuhuoNM1wsKBlQOGIwod3H4+5jmFFQcGyrBdwLMJBZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzC2O3T5gjyWXL9mcAe25XmIi44dAeIOX0mSIfQSfSWIQKb9YZc S+SDQ/Sqjd2KoT14GIc56kIk+alAl/DN7sahvcqQWlL/dch0a6Myolm3vRwvLZKIrQdDQ6rSOcT r11CYY3LHhfD+xGuP9xHDx987zdO+luFX/N2/XKwTEXz/oOfvlw5tz8SaTqlqVOgk0w== X-Gm-Gg: Acq92OEcVOVRmyQQNGtXgfXVQVV0Jl1eMatRJfgosgF2wQaZ2GMn4GM4Jkpo+0/SLvn AwJoVAprvxsaC+kv0Tf03KvrBYNfCroovIZBfx+H4hE+KpSNOiAz3TZ/VXSXnbWFI+MsBwaPeog 2DztNIt5Y+jNgjNPV53l+zpbEIE7uw8rElxmH1HofmUxOptdw8WxUd25yjlSYvVPj2+DCFhe0os 0v5tch53F4M50mLOVtiH7qhsbsYAayhKI36DIYeKZXyJqZgYpxCOnUDe2PgMKbeZ/nG5hBLa906 k534mBvpV7aM8ceKWXrl+bX1WNm56jOIC1c3TKPPG2zus1UwjU4F02rcvrvvRtWjd5bcWEB7ZIp gA1MQvOs7sx36//PKgc+UqK99CvsFM87MWoBCFy6XosSQWIw47zXFcXvzlVwvVuFHofe1RAfTC2 jbkpv1VS406B9tkE9evwI= X-Received: by 2002:a17:903:2ecd:b0:2bd:3c21:a053 with SMTP id d9443c01a7336-2bd5283e0c5mr51230035ad.24.1778808716721; Thu, 14 May 2026 18:31:56 -0700 (PDT) X-Received: by 2002:a17:903:2ecd:b0:2bd:3c21:a053 with SMTP id d9443c01a7336-2bd5283e0c5mr51229835ad.24.1778808716140; Thu, 14 May 2026 18:31:56 -0700 (PDT) Received: from [192.168.0.74] (n1-41-240-65.bla22.nsw.optusnet.com.au. [1.41.240.65]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd7e8e5904sm10360535ad.64.2026.05.14.18.31.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2026 18:31:55 -0700 (PDT) Message-ID: <8182784b-b6c2-4136-af8d-3aea4f5a4662@oss.qualcomm.com> Date: Fri, 15 May 2026 11:31:50 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tee: qcomtee: add missing va_end in early return qcomtee_object_user_init() To: Robertus Diawan Chris , jens.wiklander@linaro.org, sumit.garg@kernel.org Cc: linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com References: <20260513091031.145826-1-robertusdchris@gmail.com> Content-Language: en-US From: Amirreza Zarrabi In-Reply-To: <20260513091031.145826-1-robertusdchris@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDAxMiBTYWx0ZWRfXx5U5FadU04+1 jE6OwBNk7FixRjl5l2L1xzEXAzoMzJ7j6U0BWfiPR3x/YwWohdDeKi4kgwhxNKculULGIKq2F1n JFy68mQqszTXl4Ov0ZCsXGA9A6QIxp6i+M/G2cVx0Ux+yYG6pspvaIqVhpURLjqTZ+zvzRD6/nm +V5XOQB90+IYlO8KNB8SoYt/pCqhEq5ulKhE09ISEwD5zTbFArY/GN0zXNMqtDFQwosDQIyIveq GcsoOoYJnOENwwgblmk8BrGFaRKWhrWE2gkfIJZToR5o8CyQOwpdj46h5gnxQLFw/zDPDKz7o+u nF5jFWcznyiJOXUy9bygH8L/2LmNBZdrat7krRICBM9lAXC5y2chTK4YTw0t4Ev1GxH/sH4jkYx 3Kbwv4OSzfNqtsLWNLMLB0swDVFxbJZW2oinqbIHBojmFjR3Z/0L9qtyulM3pzJqtCMgqQmVplC KiDBaRDQ1VDZgXKKuEQ== X-Proofpoint-GUID: rGYgRpoqGK66SlNIeoFLLQ-i4BPgXkPz X-Proofpoint-ORIG-GUID: rGYgRpoqGK66SlNIeoFLLQ-i4BPgXkPz X-Authority-Analysis: v=2.4 cv=BvqtB4X5 c=1 sm=1 tr=0 ts=6a06778d cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=hi51d+lTLNy/RbqRqnOomQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=pGLkceISAAAA:8 a=A39jgTEGnKEs4j151ysA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_06,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150012 Hi, Forgot to mention: how about using a break instead of a goto. Then feel free to add Reviewed-by. Thanks, Amir On 5/13/2026 7:10 PM, Robertus Diawan Chris wrote: > qcomtee_object_user_init() is a variadic function and when the function > return because there's no dispatch callback in QCOMTEE_OBJECT_TYPE_CB > case, there's no va_end to cleanup "ap" object initialized by va_start > and that can cause undefined behavior. So make sure to use va_end before > returning the error code when there's no dispatch callback. > > This is reported by Coverity Scan as "Missing varargs init or cleanup". > > Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") > Signed-off-by: Robertus Diawan Chris > --- > I don't have the device, so I am not sure how to test this change. > Thank you. > > drivers/tee/qcomtee/core.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c > index b1cb50e434f0..901a31e8201f 100644 > --- a/drivers/tee/qcomtee/core.c > +++ b/drivers/tee/qcomtee/core.c > @@ -306,8 +306,10 @@ int qcomtee_object_user_init(struct qcomtee_object *object, > break; > case QCOMTEE_OBJECT_TYPE_CB: > object->ops = ops; > - if (!object->ops->dispatch) > - return -EINVAL; > + if (!object->ops->dispatch) { > + ret = -EINVAL; > + goto out; > + } > > /* If failed, "no-name". */ > object->name = kvasprintf_const(GFP_KERNEL, fmt, ap); > @@ -320,6 +322,8 @@ int qcomtee_object_user_init(struct qcomtee_object *object, > default: > ret = -EINVAL; > } > + > +out: > va_end(ap); > > return ret; > > base-commit: 5d6919055dec134de3c40167a490f33c74c12581