From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Odelu Kukatla <quic_okukatla@quicinc.com>, djakov@kernel.org
Cc: rafael@kernel.org, corbet@lwn.net, linux-pm@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_viveka@quicinc.com, peterz@infradead.org,
quic_mdtipton@quicinc.com, linux-arm-msm@vger.kernel.org,
krzysztof.kozlowski@linaro.org
Subject: Re: [PATCH v2 0/4] Add support for QoS configuration
Date: Tue, 6 Feb 2024 10:07:07 +0100 [thread overview]
Message-ID: <8189e50a-290c-494d-af42-a954a5d231ea@linaro.org> (raw)
In-Reply-To: <20240205145606.16936-1-quic_okukatla@quicinc.com>
On 2/5/24 15:56, Odelu Kukatla wrote:
> This series adds QoS support for QNOC type device which can be found on
> SC7280 platform. It adds support for programming priority,
> priority forward disable and urgency forwarding. This helps in
> priortizing the traffic originating from different interconnect masters
> at NOC(Network On Chip).
>
> Changes in v2:
> - Updated regmap_update to make use GENMASK and FIELD_PREP.
> - Removed the regmap structure from qcom_icc_node.
> - Made qcom_icc_rpmh_configure_qos() static
> - Removed qcom_icc_rpmh_map() API, inlined the code in probe
> function.
> - Updated declarations to reverse christmas tree fashion.
You ignored some of my previous review comments without a response.
Konrad
next prev parent reply other threads:[~2024-02-06 9:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 14:56 Odelu Kukatla
2024-02-05 14:56 ` [PATCH v2 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support Odelu Kukatla
2024-02-05 15:08 ` Dmitry Baryshkov
2024-02-22 10:46 ` Odelu Kukatla
2024-02-06 7:55 ` kernel test robot
2024-02-05 14:56 ` [PATCH v2 2/4] interconnect: qcom: sc7280: enable QoS configuration Odelu Kukatla
2024-02-05 15:12 ` Krzysztof Kozlowski
2024-02-22 10:50 ` Odelu Kukatla
2024-02-05 14:56 ` [PATCH v2 3/4] dt-bindings: interconnect: add clock property to configure QoS on SC7280 Odelu Kukatla
2024-02-05 15:10 ` Krzysztof Kozlowski
2024-02-22 10:50 ` Odelu Kukatla
2024-02-05 14:56 ` [PATCH v2 4/4] arm64: dts: qcom: sc7280: Add clocks for QoS configuration Odelu Kukatla
2024-02-06 9:07 ` Konrad Dybcio [this message]
2024-02-22 10:54 ` [PATCH v2 0/4] Add support " Odelu Kukatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8189e50a-290c-494d-af42-a954a5d231ea@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=corbet@lwn.net \
--cc=djakov@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_viveka@quicinc.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®