From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD0F82CCC0 for ; Thu, 28 Nov 2024 12:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732795625; cv=none; b=phLXqKtwkmmmWCSJJlmaxhHb59HWauM43Nw4Wx+WACmOweRx2Tw+rQUVfo6oIVGRTPVnQakLj3aGA1/jE2gQU6tjWGHMRWCstjo03qacChKTIh96c5n8Y6t4yl6Y5bVhp0sWbg8oETAmhrFhQfInFycGxSAIlMFO0yPXQpFmgNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732795625; c=relaxed/simple; bh=fQqYngYQaBH4nRkWFH+2RCIgNp656eo5Cdwm61nRK/g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g74d3PE4W27fQMStnaFJqj/8vOOYI2mZLvaulWMHKgllsVJLplig3PDODDwdlGxLkPf2m3kNxaNCmPSXqnuCoN8Gvfn2RIAE2FCRjymXXSSuHGY2381MOWKdOgalsSYrqqq1eGg6d6aRJJmkF0aT8+kPRkGeN4ui3K4WYaaMBkc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L0eL6tqo; arc=none smtp.client-ip=209.85.167.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L0eL6tqo" Received: by mail-lf1-f66.google.com with SMTP id 2adb3069b0e04-53dce975a9cso98517e87.2 for ; Thu, 28 Nov 2024 04:07:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732795622; x=1733400422; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7SF5OHl6Q6ZggZKWiO6IZg02nSrf/YPTh7wLw9TpiFw=; b=L0eL6tqoED56UuVeo8BUpvq1uVWouDW7OAGiMvAB7S3Qg/xg2bAEVQmwkXiVO6RUI7 lhqRpp3YSyldoEWXue9piEioO6lLycrzfJeIhXDku9wVclYckX9KfmfkCSfa/HWsgOqv YbmDb/UJa8CAXKmrWBcDdOpmainzuDJXdQ2Hw1kKoaBpRUUWQpWcQGP1yBQsDcVm12Vw UbVYcTE68LRE6fBp8XO2Im/iQQ9hx6bGjO1+uBHxgOMv2j/2bkfKfdlOl7QQfYYjxDbb K+uwLg3QWfNRCIjIqoIt9xOhJAXLWCwCloZ1GUm7V77ZoUVC/Sub2Vsis9/P9XJ6AILR mXZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732795622; x=1733400422; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7SF5OHl6Q6ZggZKWiO6IZg02nSrf/YPTh7wLw9TpiFw=; b=FYCLGi55eRUfWlz16S5i1+QqFKQ+icDwdejm3zykeSym+AZdn+OPBxRSwTMZf4PIKB Rtp+7uOdiYKkyLNqjK5QKZmEvOPN3xLhL+rADkOPOXA1pqmERa1VKqKPOwjINi7KBMXJ 3x5xXwWHwh61yAkj5T6DgQy8yeIDhxtqETy6OWX5tlksTaGMQi1wuiCjkpQwk8kk/fz0 Z3KKA3VYx9HBWNMoCyRGchbWugPc2lmbZ5bxd37Gok6lGMmsI8tY+0y/TxrGjHyuzu0m 8QhHuUNCe6BKy/2bOnM9p4bHcufEzqrMjD8uXZzBmGhhkCSY+amsAWd2TWnUxLpBI1cB gQNA== X-Forwarded-Encrypted: i=1; AJvYcCUYQfgyJA9MMbsJ+F5rcBQVKn+kEQP7wsX8BtGzPbv01fhnrMsdt1zRZxj8HVLdbKSUVwTOkqJc004m3Q4=@vger.kernel.org X-Gm-Message-State: AOJu0YwYFFttHQ4IRqlJYp1NzJA/kGS0VnVo/HQ1onI9ya89alSY0kOb Y8AWMNU4jixFUs+H13IvvrEPaUd+2lYBJHFHnnjVaRui2I6t3D2nijHLx+/Mydc= X-Gm-Gg: ASbGncuJi7wrLLCG1hAUFVqPstodDtuaGPllRtwOHB0m+kM/DlN4ZJAF8EPJwCeXRnn wuv80mZLkkHI43KTqk5lCBiq1ynP6PovHMHEnsf/3OpdJyIhMDGfqoLQhMOfHZUxygLaQCMdvjV FG/9urpDELQXcOvc1mDFxF57TpnYyGJyKAC6Rpuupwi0XFTUCeF5gKDMjFzwHOxD9za8ZxIHwcJ nuwKLaYJ6EAi4aTAEr45Xm+fgp2epFeihGMdfomKHq27WQ6LCxUabA4H40Im/QSOKwW4MvT0hSn zL5hGBCF5gPCKWwVNggpyKqbYLXU X-Google-Smtp-Source: AGHT+IHsfbfQFGYieKwKAf8ZPiuL2mZxi4Zqttbg2UBokuZg6RjtXSHIhC857ys4GHZZnwz2KVhYng== X-Received: by 2002:a05:651c:b21:b0:2f7:5c23:98fb with SMTP id 38308e7fff4ca-2ffd60dbc52mr8337221fa.10.1732795621780; Thu, 28 Nov 2024 04:07:01 -0800 (PST) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ffdfc097c3sm1756931fa.54.2024.11.28.04.07.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2024 04:07:01 -0800 (PST) Message-ID: <8189fe4a-b6f5-43a6-9f7f-1abddc366ada@linaro.org> Date: Thu, 28 Nov 2024 14:07:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] clk: qcom: common: Add support for power-domain attachment Content-Language: en-US To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-0-836dad33521a@linaro.org> <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-2-836dad33521a@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-2-836dad33521a@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Bryan. On 11/27/24 01:44, Bryan O'Donoghue wrote: > Right now we support one power-domain per clock controller. > These single power-domains are switched on by the driver platform logic. > > However when we have multiple power-domains attached to a clock-controller > that list of power-domains must be handled outside of driver platform > logic. > > Use devm_pm_domain_attach_list() to automatically hook the list of given > power-domains in the dtsi for the clock-controller driver. > > Signed-off-by: Bryan O'Donoghue > --- > drivers/clk/qcom/common.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > Is there any particular reason why my review comment was ignored? https://lore.kernel.org/all/8a33c0ff-0c6d-4995-b239-023d2a2c2af5@linaro.org/ There is no signs of the change improvement, unfortunately. -- Best wishes, Vladimir