From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbdJCQw0 (ORCPT ); Tue, 3 Oct 2017 12:52:26 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:52479 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdJCQwY (ORCPT ); Tue, 3 Oct 2017 12:52:24 -0400 Subject: Re: [RESEND PATCH] gpio: omap: Fix lost edge interrupts To: Santosh Shilimkar CC: Linus Walleij , Tony Lindgren , Santosh Shilimkar , , , , Ladislav Michl References: <20171003161705.23398-1-grygorii.strashko@ti.com> <7b8f3c6a-0f4b-98ed-3887-91a01ed6cdbb@oracle.com> From: Grygorii Strashko Message-ID: <81906eda-58ac-38e3-bc0a-8ead2b6aa8df@ti.com> Date: Tue, 3 Oct 2017 11:52:01 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <7b8f3c6a-0f4b-98ed-3887-91a01ed6cdbb@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [128.247.59.147] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Santosh, On 10/03/2017 11:41 AM, Santosh Shilimkar wrote: > > > On 10/3/2017 9:17 AM, Grygorii Strashko wrote: >> Now acking of edge irqs happens the following way: >> - omap_gpio_irq_handler >>    - "isr" = read irq status >>    - omap_clear_gpio_irqbank(bank, isr_saved & ~level_mask); >>     ^ clear edge status, so irq can be accepted >>    - loop while "isr" >>     generic_handle_irq() >>      - handle_edge_irq() >>         - desc->irq_data.chip->irq_ack(&desc->irq_data); >>         - omap_gpio_ack_irq() >> it might be that at this moment edge IRQ was triggered again and it >> will be >> cleared and IRQ will be lost. >> >> Use handle_simple_irq and clear edge interrupts early without >> disabling them in >> omap_gpio_irq_handler to avoid loosing interrupts. >> >> [1] >> https://urldefense.proofpoint.com/v2/url?u=https-3A__marc.info_-3Fl-3Dlinux-2Domap-26m-3D149004465313534-26w-3D2&d=DwIBAg&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=XBn1JQGPwR8CsE7xpP3wPlG6DQU7qw8ym65xieNZ4hY&m=-JZAaXlsRBFYNqtZ-2KOemoupa4pL7ka9D3wKn6hX9o&s=c-1XuQUl3_1uYedoNhmY70xCO3fAftWB7cmFxgyC3j4&e= >> >> Signed-off-by: Grygorii Strashko >> Signed-off-by: Ladislav Michl >> --- >> Resend with proper cc list. >> > This was one of the concern I was thinking when GPIO IRQ conversion > was done. Grygorii since you did that conversion, can you please > check since I see now that the irq code is becoming increasingly > complex. This patch was developed in coop with Ladislav and he intensively tested it and this patch actually simplifies IRQ handling. Also, OMAP driver parts which this patch touches are ancient. -- regards, -grygorii