From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66EA4280325 for ; Tue, 17 Mar 2026 15:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773760540; cv=none; b=oIQiwcRDgmFuAqiUbTGeWCf3uTIGocxfT9PLu4DI2UrOryh9kNDXqINatw6TR7cqXKoNX7GT4WPMzLeNNrtWfnL6ONhobzgto9tmHgH5HqgYzURnz3UPBMe1v1U48cQ0Q2gERky+6KxZhMK/BDxMfjYuzvfcH2YYU0nPpKCPspk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773760540; c=relaxed/simple; bh=6sdcazFUryTBKsuRPFN5wjrrWuU0HsHxU7jrtkFPNF4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LCpspPs6Um0dcuJBUKLhieZ1mY4iCX+mVB9C+bgvK44aFjb1GLX+d1XrfMNsmc4FBU+vt/Pf+ZjFXi948kuyJLX8qUwRlN4Udixx5MRVuTYY43BW5Jnjr9wW0KAE/b/V5tq0cG8pe5AXKRw0+KOJHxrQ9pMidX47wIY9zuSSe1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FQpT3lK/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fGy4Ipcz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FQpT3lK/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fGy4Ipcz" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62HDuxIi2905953 for ; Tue, 17 Mar 2026 15:15:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fMR9FXb2w1XHhNRACMs78U1P/DrTrvf5IMOEXAMSVeA=; b=FQpT3lK/1mbNZSe1 26O9C63c6NpRZRxelXB1NttVK4DR+RHHvkIK/8ksVIh/eLGn0nVgAe1J1Ip2CgY9 u+GzLrVahS34+RHFrjNYx0O6PdkhHq3AhTuKUME5QppFqh1aKsfGaQfT4lkdQXlS tDNMx2lUqPbArG2iuovFg7QXi/+u4ekDeMUITzo13FS4HA1aDFc2fpWBNmrTu/DU EHdZKCYauBFIW493ECgVnhlJT/TB+GhMS73qeVWqgKDM/RMejaI8eZ9JloJwUBk9 3bw/vA9xO54Qk3pUZvhgXioxQOYnBu3OvfpYYUUdPlsI9KJh9l2WKdznNDMw7+iq Vgfipg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy2jxhqya-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 15:15:38 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd722c1a69so508999985a.0 for ; Tue, 17 Mar 2026 08:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773760537; x=1774365337; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=fMR9FXb2w1XHhNRACMs78U1P/DrTrvf5IMOEXAMSVeA=; b=fGy4IpczouCRx2o1zzOdyeKaai94AkCiQ+9ewtR7IQ2wDMKV/dHW049GN9nUtUPqbS Z0xdiVqrR3yxT6lpPYTk9vg4+YZZ2jyDMRD+lcLEvx6wUS6Ve65E3Mph0esLOQ5TTZFr 68eR53GHUmYy+Er2tTtmEwdVoH/uYcWjsDrZdtsORhQENO3BtFI29NVuJW6owyoWUwxW Hvhepi+hZm05bJSVz3YITL71QZxwJb3NxPD0rhk4+ZtXhRWzquF0eKHrSRYTsDtfZl4Z p6cEM1H+G++hhuVNDJLbOnoqeJhv9xySQux0nEVysdHijYDV2EjMnSD4yPWReuKPv2Nm YL4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773760537; x=1774365337; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fMR9FXb2w1XHhNRACMs78U1P/DrTrvf5IMOEXAMSVeA=; b=JJiSCrg3RiyQPpxMNLg05+dYuGfSv5zArM+5YhFv7W0kvv5uvh9Yz7T3I24OLj2OCD SQa7qi4r06RR4pjNjuL+UbaDye9Rj7W1VcelKhfNFxGA5bmoHZdx9vkJu8yK5mMmMwzq k5se26rm/BJRQg9/w4uPuRiuvszxqJPq11o2/3xL+hX9Nyyby9GOTEKkroCpTubaKmzG YzmCoDBDtBXzqoPcTPHz4pr2NFUjqqyJzjR//724a1qPew09I+G5i+sI4eiCOq4L3oN4 qv5Gr7z2ntFkIiilRpqKhYpWgRtBym69RZUcnvq7qpkUCtqsHR52afFVgZi5+0KhpEFX Q7TA== X-Forwarded-Encrypted: i=1; AJvYcCXvlTkqy+qVpSV01zMm6RnXCk9R3YIFiymKWVG0f2ztLNk7u474lyEWgXVHHCNoJwvndRAp/nUtywZOuq8=@vger.kernel.org X-Gm-Message-State: AOJu0YzsjDg/XREPSVc24gQWMYhRFOTffXkhDX/Ay4PWbLbED7IY6fQr fSQxwnpmmHRpU3yVppuPFgX8VIi4w9O6+NsBJ22sghvo0DeCcdaocSfol6q32VEgAw0a6XXkJKQ HeSZjkFpyv5B6Nqd2v5+y8i7GT7hxXmPLnOgaLoh1YjN7/xOrrqgxJQVkl6Jrm0W0Pps= X-Gm-Gg: ATEYQzwVM+QzjDHq34d+J65Gw/adoIoNVpPpVZYHNRN3qaS/X3MLJSPXPWLB2N6PbZQ +/7jQrJtJmFzUul1SnlOXq1vFTHt2NkVyXg2X0Vql2mUhDSTYxH4/KHFjnZRpkKwP5G0/BfgFVC i0R1p3YzRiSnNuq/+7XbRjExzAf6QxoqH0xcLMuVie8fzW8GD9H8TpReVntAOs6S8OFWQZNNalz 9FPRqx6R13RNZgOG8QYPtRidJku6gDtDzqCSzraqqFqjNdxiHAPhlpRGTPMA7RlJBkV+bnmQpuO MexuK0DwGVH6YlXaE/MQqjTbziaX1q49vym1bZeg4yebJYKrKx3Zw+kqhGb0fQaD8GM7mNDDU9s rtI6sAa444O4Yje0BUu8o2WB3neTTuQq+EYWSvSk1cSWPTLnO X-Received: by 2002:a05:620a:24d:b0:8cd:c077:40d3 with SMTP id af79cd13be357-8cdc0774143mr1394538185a.25.1773760536123; Tue, 17 Mar 2026 08:15:36 -0700 (PDT) X-Received: by 2002:a05:620a:24d:b0:8cd:c077:40d3 with SMTP id af79cd13be357-8cdc0774143mr1394528885a.25.1773760535318; Tue, 17 Mar 2026 08:15:35 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-667aecbcc9fsm47009a12.6.2026.03.17.08.15.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 08:15:34 -0700 (PDT) Message-ID: <81927ccd-c28b-4f7e-aa91-78edf7a98456@oss.qualcomm.com> Date: Tue, 17 Mar 2026 16:15:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH] mux: mmio: Zero the allocated memory To: Greg Kroah-Hartman Cc: Peter Rosin , linux-kernel@vger.kernel.org References: <20260317124826.233006-2-krzysztof.kozlowski@oss.qualcomm.com> <2026031710-implicit-hungrily-3b47@gregkh> <4e93db73-20d2-436c-b9e4-4b41e5c237fa@oss.qualcomm.com> <2026031721-fable-creative-74fb@gregkh> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: <2026031721-fable-creative-74fb@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: K9ayB11ELgZtT39dOoyItso3M-qFS4PG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDEzNCBTYWx0ZWRfX3io4Lx426eSf 7eh98PrtK6CSob2z52ePYkLFjpagnMlI/S4OqK9qzziQUMYR63BSnXSAfGkw7igoasUVcBxlUn1 XK0z4k7hJenr2N0KoWKHPXS1qnXKtcdIEiJvALwDVi8rwA1L75ElkcCPemgy9Jnapg5yJjpJ+aI mIngkiByUxgsRyd46VuFUu3XR7gkbNUcq92pVdn/gdTS8wLU16F73eBY9SgbABbPjfPvRFm0ecL 2VihFX47SwXazYS6em51sh8Lxkkc3zw9Xf/GNnU/sz4IX3xYKOHrjqWi7X9RKdAGB10tlpGIIy+ jfHPvr1Lmy7sQXCIeAuCPEU0nGAqBD9AYz9/FniB7P0cppQJwuoJpyxw4iT/NFlhntlaIgu+Y9S KJe6I9oUwSs4nCjVTIjHh6lzOoTeGeOV0MXOZBD6m/zZ1e31iTkAAOpv5AvDYjgMrhRqTPMbRMl B/OG8Pi0/DX/tvWNeJg== X-Authority-Analysis: v=2.4 cv=c4imgB9l c=1 sm=1 tr=0 ts=69b9701a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=3NxGTvUcQvIjaawdP7EA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: K9ayB11ELgZtT39dOoyItso3M-qFS4PG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_02,2026-03-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170134 On 17/03/2026 15:42, Greg Kroah-Hartman wrote: > On Tue, Mar 17, 2026 at 03:39:41PM +0100, Krzysztof Kozlowski wrote: >> On 17/03/2026 14:33, Greg Kroah-Hartman wrote: >>> On Tue, Mar 17, 2026 at 01:48:27PM +0100, Krzysztof Kozlowski wrote: >>>> Zero the allocated memory in probe() for fields and states for increased >>>> code safety and to match expected Linux coding style. >>> >>> What "style"? I'm all for zeroing out memory to start with, but as this >> >> That style ^^^ that we expect zero'ed memory :). >> >> Also, memory-allocation.rst says: >> >> "And, to be on the safe side it's best to use routines that set memory >> to zero, like kzalloc()." >> >> So the style/preference is actually documented. >> >>> has lived for so long without this, are you sure it's still needed? Are >>> there uninitialized fields in here that we are now properly >>> initializing? >> >> Yes. The second allocation is for "hardware_states" which does not >> receive initialization in the probe, but first assignment is in >> suspend() callback. >> >> Zeroing the first allocation for "fields" is rather style or convention, >> because the probe assigns it further in the probe. However if the driver >> exists probe via error path, these bits would remain random heap data, >> which most likely does not matter. >> >> I can expand commit msg with above. > > A changed changelog text would be great, thanks. > > And who is supposed to take this, me? Yes, please. I will send a v2 in few minutes. Best regards, Krzysztof