From: Alexey Makhalov <alexey.makhalov@broadcom.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
hpa@zytor.com, dave.hansen@linux.intel.com, mingo@redhat.com,
tglx@linutronix.de, x86@kernel.org, ajay.kaher@broadcom.com,
bcm-kernel-feedback-list@broadcom.com,
Alex James <alex.james@broadcom.com>
Subject: Re: [PATCH] x86/vmware: fix panic in vmware_hypercall_slow()
Date: Tue, 25 Jun 2024 07:45:50 -0700 [thread overview]
Message-ID: <8193d6d2-5322-4a9a-82ed-50ac24dd3525@broadcom.com> (raw)
In-Reply-To: <20240625084721.GCZnqEGbrkNNW6ZCfZ@fat_crate.local>
My test environment was screwed up during the last version of the
patchset. I was using a kernel which was built previously and didn't pay
attention to commit hash suffix in `uname -r`.
Human mistake, apologize for that.
Alex found it while doing TDX testing on x86/vmware on tip.
Do you want me to resubmit the patchset to do not brake a git bisect?
On 6/25/24 1:47 AM, Borislav Petkov wrote:
> On Tue, Jun 25, 2024 at 01:33:48AM -0700, Alexey Makhalov wrote:
>> Caller of vmware_hypercall_slow() can pass NULL into *out1,
>> *out2,... *out5. It will lead to a NULL pointer dereference.
>>
>> Check a pointer for NULL before assigning a value.
>
> I queue your patches and *now* you find this?!
>
> How did you test them in the first place and why was this scenario missed?
>
> Geez.
>
next prev parent reply other threads:[~2024-06-25 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 8:33 Alexey Makhalov
2024-06-25 8:47 ` Borislav Petkov
2024-06-25 14:45 ` Alexey Makhalov [this message]
2024-06-25 14:51 ` Borislav Petkov
2024-06-25 15:01 ` Alexey Makhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8193d6d2-5322-4a9a-82ed-50ac24dd3525@broadcom.com \
--to=alexey.makhalov@broadcom.com \
--cc=ajay.kaher@broadcom.com \
--cc=alex.james@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®