From: "Vokáč Michal" <Michal.Vokac@ysoft.com>
To: Pavel Machek <pavel@ucw.cz>, "andrew@lunn.ch" <andrew@lunn.ch>,
"vivien.didelot@savoirfairelinux.com"
<vivien.didelot@savoirfairelinux.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>
Cc: "buytenh@marvell.com" <buytenh@marvell.com>,
"buytenh@wantstofly.org" <buytenh@wantstofly.org>,
"nico@marvell.com" <nico@marvell.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dsa device tree bindings: fix typo and wrong example
Date: Thu, 6 Dec 2018 13:28:56 +0000 [thread overview]
Message-ID: <819595ee-9f3e-b7a2-6139-1ba265137f62@ysoft.com> (raw)
In-Reply-To: <20181206130513.GE22343@amd>
On 6.12.2018 14:05, Pavel Machek wrote:
>
> Fix typo and fix compatible value that is not actually permitted by the
> description in the example.
Ahoj Pavle, I think the subject should be more like:
"dt-bindings: net: dsa: ..."
BR, Michal
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> index feb007af13cb..abf1be036ac5 100644
> --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> @@ -41,7 +41,7 @@ Optional properties:
> - mdio : Container of PHY and devices on the switches MDIO
> bus.
> - mdio? : Container of PHYs and devices on the external MDIO
> - bus. The node must contains a compatible string of
> + bus. The node must contain a compatible string of
> "marvell,mv88e6xxx-mdio-external"
>
> Example:
> @@ -80,7 +80,7 @@ Example:
> #interrupt-cells = <2>;
>
> switch0: switch@0 {
> - compatible = "marvell,mv88e6390";
> + compatible = "marvell,mv88e6190";
> reg = <0>;
> reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;
>
>
>
next prev parent reply other threads:[~2018-12-06 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181115195111.GA9946@amd>
[not found] ` <20181206130051.GA22343@amd>
2018-12-06 13:05 ` Pavel Machek
2018-12-06 13:28 ` Vokáč Michal [this message]
2019-01-07 18:49 ` Pavel Machek
2019-01-07 18:53 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=819595ee-9f3e-b7a2-6139-1ba265137f62@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=andrew@lunn.ch \
--cc=buytenh@marvell.com \
--cc=buytenh@wantstofly.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nico@marvell.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®