From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C15A239090 for ; Mon, 7 Apr 2025 11:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744023865; cv=none; b=sqVxidKFoZFGalALfxzvkK4CKV0kRZsqud3/wruzUUYNr/clu67MEi17NCQ42bRQDoBbvgO22moDuejKlkLGlUVHKgu3e9rB1VUzCbzgDcgwQiSjMr6svLfnKEySMLx87evmixFfVvbkC/Rqn4Hdsq1m1VKshtyo5Yj/znLaXy8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744023865; c=relaxed/simple; bh=vPMacaXyS5RgOarFCrFya7CXDPzYxrmSCGIk7I3/RlA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=EwNE5i6cQULvwhJdBhLZMvRNwq6ZY/5neEDGFySHZoUphuA1SpVhfKJ4aQLOgxC61+hhZDQwFCD1oRx+GVuGXl23VjbSkQsQKl+4Yza7FmxW7r6LttlxZpom4QDmzYk1Wz4aX/8cz4bUN+UcvhHCAV/2RfEeC0WM7IgjjsmFBFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MAiDXL25; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MAiDXL25" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cfb6e9031so39085215e9.0 for ; Mon, 07 Apr 2025 04:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744023861; x=1744628661; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=bjNP63G+fAyAyGQb7WUecVf9CDYMikWqHRq+/UjXZxI=; b=MAiDXL251S5WQDA+rh0txJ7+K+1M4uYzBDuOyg+IXEnYVn8AJaWFWILk2UyiiRRlzf lhSBpN+9g3cVuRJlIHjnrrmPIrZ/p5XZL0q9DgLyntFrIqGtw8FIXR1T5EA+t42mwQuA k/k5BaaA8hjJ5vM+9+hQ53Qvf3nIH3WqOFI0NCHObKCzNWhwJQu0+nbgfZALruuxrmFM ZgHPRa1xJpJXBLIc4bAGSMw8w80Kqzja48PnCKGoRE95pHvAmWHJNBJSxbGpVZVodgV/ 1h8iEZCg2IcTD1PliedDxrwMSQ81CdxGJEXtwXf0b6WImLT1nYcPl+1Fo/0kbsY+Rvfw w3hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744023861; x=1744628661; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bjNP63G+fAyAyGQb7WUecVf9CDYMikWqHRq+/UjXZxI=; b=pvimHOuNx7bajSFprBisZcU2nNOKzuQiJlXT49aWOwP8GAnMHe9JkfTWau5l01lwfA DIxRak2Xfb4uOOxKrP/EomwOp00cEYrcgQtkpNHLFpwjXmRmsNOJjAoiHstSjuxGVRoY izjMQI9oAw4sBwfJOEj+xz6AI3TncLTTOez5ufij483Mw+B9JD5dfTLka5tPGbzIbPTF cJZq/nDItu7bQePNM+tzHP9Vp5ZN8Bf+n6g68MDuBwSib4br/42Zn/fQ57tGhMPWwdwN rKeZkIbWHvs7YwpsWVns3Hi3N/C4OChcUCq0PtIdMBfP5IC4zlcR4JQPV+dqpb+Mi1oe w9Xg== X-Forwarded-Encrypted: i=1; AJvYcCXXcTSQVwnFB5lHvHCGdpyVFKo8fp9GCwUNxbiA/q5SA7KBofIkBDMS1f+um5U+kaTi+agEGOOdp/j2jhM=@vger.kernel.org X-Gm-Message-State: AOJu0YyLHddHa41jGxHGoiVV6Cc7MfGl0hJBlmZjh5KnrpOI74ym3BaB OY1gYkyzPYfDinIjs94znQ0UI/BR6kh6rA3k5BWELCYr6pU8hxDX0S6Qar8w9Nw= X-Gm-Gg: ASbGncuC3MpXBRTTm1LOIFYyMvE3CnLJ139DiuuYmTkGRppZYNqotMtO5P2PQnAjan7 V27oBqV448/UXorwqHqaWnWM41rgDhqWpcvKabBVeUan2E6KO6t6GwwFkHEi4IVz0O19lIaPKwg mQZXu08jJnGbAlmFY9R5FKSvsVW2yZgdoU3oGd/Pws9uduWRzvCoIR4FYlLnjhmhI3dhG5vMGRR 2ImAu9h+OCM696gvd0C86sEmCALtHyJ/77UxB3YiDuJI46FbN3Dgc0LM4qToM/1MN6t79/0Hio4 VTEZQ7liPamMs3aUOCT0ZplH1s4Cv27ZWYA8yIRZsPZRgrKjAg== X-Google-Smtp-Source: AGHT+IE98q/exAYcbXtaZDbUrx+IuA1N3tIoGfV9NOXz2xzrCG0lt2xc3oN4y/3w/IH6VurA5lmsRg== X-Received: by 2002:a05:6000:430c:b0:391:47d8:de2d with SMTP id ffacd0b85a97d-39cba93382fmr10043977f8f.23.1744023861560; Mon, 07 Apr 2025 04:04:21 -0700 (PDT) Received: from [10.1.1.109] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1795205sm130230235e9.30.2025.04.07.04.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 04:04:21 -0700 (PDT) Message-ID: <819718d731bc1496a75ebd0a4076d88273b21229.camel@linaro.org> Subject: Re: [PATCH v3 25/32] rtc: s5m: cache value of platform_get_device_id() during probe From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org Date: Mon, 07 Apr 2025 12:04:19 +0100 In-Reply-To: References: <20250403-s2mpg10-v3-0-b542b3505e68@linaro.org> <20250403-s2mpg10-v3-25-b542b3505e68@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2-1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sun, 2025-04-06 at 20:29 +0200, Krzysztof Kozlowski wrote: > On 03/04/2025 10:59, Andr=C3=A9 Draszik wrote: > > platform_get_device_id() is called mulitple times during probe. This > > makes the code harder to read than necessary. > >=20 > > Just get the ID once, which also trims the lengths of the lines > > involved. > >=20 > > Signed-off-by: Andr=C3=A9 Draszik > > --- > > =C2=A0drivers/rtc/rtc-s5m.c | 8 +++++--- > > =C2=A01 file changed, 5 insertions(+), 3 deletions(-) > >=20 > > diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c > > index db5c9b641277213aa1371776c63e2eda3f223465..53c76b0e4253a9ba225c3c7= 23d35d9182d071607 100644 > > --- a/drivers/rtc/rtc-s5m.c > > +++ b/drivers/rtc/rtc-s5m.c > > @@ -637,6 +637,8 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info= *info) > > =C2=A0static int s5m_rtc_probe(struct platform_device *pdev) > > =C2=A0{ > > =C2=A0 struct sec_pmic_dev *s5m87xx =3D dev_get_drvdata(pdev->dev.paren= t); > > + const struct platform_device_id * const id =3D > > + platform_get_device_id(pdev); >=20 >=20 > If doing this, why not storing here driver data, so the enum type? Good point, thanks Krzysztof Cheers, Andr=C3=A9