From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90506EB8FAF for ; Wed, 6 Sep 2023 12:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240489AbjIFMGH (ORCPT ); Wed, 6 Sep 2023 08:06:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240480AbjIFMGG (ORCPT ); Wed, 6 Sep 2023 08:06:06 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1DBC1A4 for ; Wed, 6 Sep 2023 05:06:01 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9a648f9d8e3so484863566b.1 for ; Wed, 06 Sep 2023 05:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694001960; x=1694606760; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=RnE6ybsHsRfqbSRiCw65bve3WZBj9PBmcz+92cU9XrM=; b=knL5qik6NiYr5I53PINcNJvrmf7iiLLSv0ae5a6a6/7uJIe5/gQDBEKfgascIPAzSx 9komCTibr68F1JXJ+psZdfysILGLwzED3EOaTe0qerBNWfUV5XjFGX2sIrLKUgwZj9He NJWSTbEqyxdXAnVGi3fg3DX+b0+1Yh9xNe67U5pic2xMKXe2wliVYUDHH9BrD5DvxJaS Huk/CL0yfZbRV/7w9pDlvLBOEuGkpuDnXTJc/fkWLQJB7pkMkBxpsGVo44HtZTFOKagh VOdVPqN0XfBuQny46QTMUSVXGPZlTmrskY8AoFiibL882yBTHscrdWhDCsChRZ7Pv7cT 4Apg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694001960; x=1694606760; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RnE6ybsHsRfqbSRiCw65bve3WZBj9PBmcz+92cU9XrM=; b=bbT8IzmYS9GzNZoJ2naDWIzsmrN1ud7zPXEom5QOqPSjlJQVqFc72jfWDBYX9aXjfU +pe345Ffc1wiG3R28D4nGJdIhJauZLXWPDI22SUWgt4NgUWmE5NnpvfkuKLJuvo3KXgm 4G4VNlnZ3LYC/8HcYb2phst3ch3J+tJKUhOFNVrIVJrzv2Rs1aJJbN+fyNY/PXJG1YDN TbVmbFiOHSLZss3CkajrMci5hocWMNEj5L+eaE13OUNM7FxJOA2vF8n4VHqV4BzJMOtc pCsVNTRyN0hD7BqfOfdRlhz0jmFtXSk1BhNFr9e5g/tFoGiQYUUpGPTXRcgwRxGkTLed juhA== X-Gm-Message-State: AOJu0YwzTNMEz1nDY+fwSH1RoMuNH9Ejn32IxSakCViLIDtD2EXUYyRd gHv5G/XGCptjyQYAOBKY++goNOAF4rEMEm237G4= X-Google-Smtp-Source: AGHT+IEiAMNpbcOFOpt36HtSQySzO+1jdqRMZEEUzJ5mkpptv2P8p6BykXjwWZrtEZ0bZ119cYn5Zg== X-Received: by 2002:a17:907:75e4:b0:9a3:c4f4:12dc with SMTP id jz4-20020a17090775e400b009a3c4f412dcmr2276409ejc.7.1694001960235; Wed, 06 Sep 2023 05:06:00 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id j6-20020a170906278600b00992b50fbbe9sm8950596ejc.90.2023.09.06.05.05.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 05:05:59 -0700 (PDT) Message-ID: <8197d5c6-bd05-ff16-59d5-ba3eb06a5921@linaro.org> Date: Wed, 6 Sep 2023 14:05:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230906104744.163479-1-krzysztof.kozlowski@linaro.org> <9c7fae56-85a2-4691-8192-24237761d25c@linaro.org> <91f74079-1be3-4c66-9942-cb02c96c8848@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <91f74079-1be3-4c66-9942-cb02c96c8848@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/2023 13:50, Konrad Dybcio wrote: > On 6.09.2023 13:39, Krzysztof Kozlowski wrote: >> On 06/09/2023 13:28, Konrad Dybcio wrote: >>> On 6.09.2023 12:47, Krzysztof Kozlowski wrote: >>>> According to schematics the VCCQ2 supply is not connected and the L3G >>>> regulator instead powers up the controller pads (VDD_PX10). Use correct >>>> supply vdd-hba and drop unsupported current limit for the vdd-hba. >>> Why is it unsupported? >> >> Maybe I was here not precise. I move the regulator from vccq2 to >> vdd-hba. vccq2 has control of current in UFS core driver. Bindings also >> allow it. > Looks like the bindings are out of sync with the driver. > > ufshcd_populate_vreg() which parses current is used for both vccq2 > and vdd-hba. Just for convenience. The current is not used for vdd-hba. Also: https://lore.kernel.org/all/20230906113302.201888-1-krzysztof.kozlowski@linaro.org/ Best regards, Krzysztof