mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhang warden <zhangwarden@gmail.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>,
	Miroslav Benes <mbenes@suse.cz>, Jiri Kosina <jikos@kernel.org>,
	Petr Mladek <pmladek@suse.com>,
	Joe Lawrence <joe.lawrence@redhat.com>
Cc: live-patching@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] livepatch: Add using attribute to klp_func for using function show
Date: Tue, 6 Aug 2024 23:21:13 +0800	[thread overview]
Message-ID: <81AC0E7E-24D8-4768-B1A2-CD3688C1525D@gmail.com> (raw)
In-Reply-To: <20240805064656.40017-2-zhangyongde.zyd@alibaba-inc.com>



> On Aug 5, 2024, at 14:46, zhangyongde.zyd <zhangwarden@gmail.com> wrote:
> 
> From: Wardenjohn <zhangwarden@gmail.com>
> 
> 
> static void klp_init_func_early(struct klp_object *obj,
> struct klp_func *func)
> {
> + func->using = false;
> kobject_init(&func->kobj, &klp_ktype_func);
> list_add_tail(&func->node, &obj->func_list);
> }

I reviewed my mail again and found some typos and point them out first.

func->using = false
is a remaining mistake by the previous patch which will remove in the next patch.

> 
> + * 
> + * When this patch is in transition, all functions of this patch will
> + * set to be unknown
> */
This comment is left and become useless, it will be removed	in the next patch.

Thanks!
Wardenjohn.

  reply	other threads:[~2024-08-06 15:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-05  6:46 [PATCH v2 0/1] livepatch: Add using attribute to klp_func for using function zhangyongde.zyd
2024-08-05  6:46 ` [PATCH v2 1/1] livepatch: Add using attribute to klp_func for using function show zhangyongde.zyd
2024-08-06 15:21   ` zhang warden [this message]
2024-08-13  3:53   ` zhang warden
2024-08-13 16:05   ` Petr Mladek
2024-08-14  2:32     ` zhang warden
2024-08-14 14:23     ` zhang warden
2024-08-15  9:20       ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81AC0E7E-24D8-4768-B1A2-CD3688C1525D@gmail.com \
    --to=zhangwarden@gmail.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®