From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 972AA25C80E for ; Tue, 7 Jul 2026 19:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783450866; cv=none; b=agmJR0LtkQcEtUSLAuRLj33Gmylcu+y8tSrJu7reLuRHAExp9MDSYQ7S2gugI7mKGt4fIQj7rojYwNjXSWPbG5cYmjVhm0+IwgjyT6ADdGQI5hW3E87aLi0o/nAf6BKmYap/6u/bTpUNE98GIUPHIydgwWRoZGvAJ/Y69MNulCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783450866; c=relaxed/simple; bh=IwcMHfwnLLFVSsitBehmP/d9zkapDiPSC74fJVhWDKU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bl3mdUxGWEQq+b+CaEzv0qvoCjxJ1sYIloMaV/Wat6MbE+6RCJtxsK0Lb8YOLD4D2Tyr71AZA46KyfBTqlzsMlE6xvOzOwnbRlqQ+zVObQLphi/T5rSFaxKN9ACDdv4xnCijQdf5ENTZMGweQPvx+Ckf3s5j8YZ8ZsIg2bY1AEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VW6kuO7v; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VW6kuO7v" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-493c52cde9eso44382805e9.3 for ; Tue, 07 Jul 2026 12:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783450863; x=1784055663; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9U+Mm7+UlibCZMW00t912Atja0ya4M2ty/S6lVSlezQ=; b=VW6kuO7vIsosZGAPrZvJUoT+aOdwmwXLQF4BP9aXD+/MNZapccZic9rAIk3JzjzgJu HYs+2Y69Ps+YM81PTyVPEb8dLiOsTouN+NJL8P8dFzgJPbQZENYIX24NKPmKT8Sf9Gyq jFP/Xj/t/JjKZ0v/XdC4lwbZSS7gXfxPS3G3uWKUrf44yezxOsPwYWWjbzTThtprmgUw h9GzS4TqR7UyYIeMdZRIZpwDr/oKRTpas9mi6/UaJpaSp7Uh+VSfDmg+xCwBtI1PaF98 oJXcmf/EM7VSDtZb6XAuaT5DvoFdgzycit1O7wNRpAwqVyILoLddczUnzkiZt/XUu+Nr PMkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783450863; x=1784055663; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9U+Mm7+UlibCZMW00t912Atja0ya4M2ty/S6lVSlezQ=; b=meCDC4axBolBxsY45bjWL2fxHLl1cOFetC65DlBGyEUoXmbAKIvnw+Mlru4zzoOIpL ktztQ+/EVosODE47k29l1hyAaiFSZHyNAcV3Y5Yy4gwVBqDc9PhwrOqQH9/2f15xZTYN D2vZOo3XjQCS5L/i5VeDdSW6N8G/g4gv+Fsu0WrPiXGjTiQksTFVDytbOaX3HGe6+DLd GvhUfg6kufD2CVACZ/lhGDqqQ+GfRJy8TIY3erBb3HczvMhc5mQDcPyOaegCdkAcCMCV rir5fFYPCXikh2gM/nPyOUeRe6Uhzj4JolTs3Lrfn1UuYlmlEA5+5MirqU1mDJYkoZH1 +L4Q== X-Forwarded-Encrypted: i=1; AHgh+RqRxDtsju0X9y0hHhNwvhUcfSCug5GCQfpCe7YKsegqUprtawygYFFJMxoD6rfK7AYH4RcWeh72p7W1f7U=@vger.kernel.org X-Gm-Message-State: AOJu0YyYUSkVg4mgMAKC4ZWzN0ZrCs5XFofXHIsPUUFYiz2RPbNKbigJ AlXIhiE2IXCjjuWu/PgKVdS5Xco4mt3Wmvbg6sZKqsKJ3eCVK8wm4j7j X-Gm-Gg: AfdE7cnhTceFbYPmIe8cpTEdVNRsQzhciKKyQMSW/kfhKmB9sLDWoCCiFV97ByIjQJU mUhjSXstTqfEEkof1twdzRAkk+U9z0VTBWId3jVBV54/V4QVE4ZocMTRSr2MEryR9kF7nEyY50h S89hxChVnP5KzTh5lTziAhDa5cb37EATm0Au7qSg4JCjaz/bLp5cTvRU59W30f+s26HPXnX7sMd RhYbzEFN658Kb4THtY3YxsXtyOr3twcrP6TIGj3QS/OobINeRPH6cvyUZg7uJBC9OQV+PrH5vYq RG4WDt4+uhHEHpqF0/KNqRNo3dpHfrbSSA0xsNphmHvQXYXYLMrWWJ5JmLDcYlbfjQToHpFfMlL NWw0F2arurrBf5CpfUqjSNZ+TS5elIChgpQLPhUE0ezAe+Mg2EhzWv/31MWOunOyi07BcNvXTRh Ne46smDpz7nexnE4p118EDa8zp X-Received: by 2002:a05:600c:8b6c:b0:492:4a50:41fe with SMTP id 5b1f17b1804b1-493df092ac5mr73198175e9.22.1783450862462; Tue, 07 Jul 2026 12:01:02 -0700 (PDT) Received: from [192.168.1.10] ([95.43.220.235]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-493e0f5bc78sm90260455e9.14.2026.07.07.12.01.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 12:01:01 -0700 (PDT) Message-ID: <81a7e0f6-8731-4bae-b06c-932f5c57d4dc@gmail.com> Date: Tue, 7 Jul 2026 22:01:00 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: phy: motorola,cpcap-usb: add chrg_det interrupt To: Conor.Dooley@microchip.com, conor@kernel.org Cc: vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, aaro.koskinen@iki.fi, andreas@kemnade.info, khilman@baylibre.com, rogerq@kernel.org, tony@atomide.com, linusw@kernel.org, brgl@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260705101105.1798069-1-ivo.g.dimitrov.75@gmail.com> <20260705101105.1798069-2-ivo.g.dimitrov.75@gmail.com> <20260706-visitor-calorie-b805ac5af970@spud> <2b192691-54d8-4449-a18c-b87266c6c73c@gmail.com> Content-Language: en-GB From: Ivaylo Dimitrov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7.07.26 г. 12:58 ч., Conor.Dooley@microchip.com wrote: > On 06/07/2026 22:25, Ivaylo Dimitrov wrote: >> >> Hi, >> >> On 6.07.26 г. 20:14 ч., Conor Dooley wrote: >>> On Sun, Jul 05, 2026 at 01:11:02PM +0300, Ivaylo Dimitrov wrote: >>>> The CPCAP USB PHY driver uses the CPCAP charger detection interrupt >>>> for DCP detection. >>> >>> This is not currently true, the driver does not look for this interrupt >>> at the time of this patch. >>> >> >> Right, this is bad wording caused by the fact that initially the driver >> patch came before the binding patch. >> >>>> Update the binding and example DTS to use the corresponding >>>> "chrg_det" interrupt name. >>> >>> Sounds to me like this new interrupt is optional, since until now it has >>> not been needed? The patch however makes it mandatory. I think your >>> driver patch also makes it mandatory, which will break older >>> devicetrees. >>> >> >> Oh, it is indeed not needed for proper DCP/SDP detection, after some >> experiments I was able to teach the driver to do proper detection by >> using current interrupts only. >> >>> What makes this ABI break okay? >>> >> >> Will send new series with schema/DT patches dropped. > > I think the devicetree patches are fine, provided you add > a minItems of N-1 so that the new interrupt is optional. > Dropping them would mean that the documentation for this device > remains incomplete since that interrupt does exist. > Ok, will add that change in the next version, however, I will still change the driver patch to not use chrg_det interrupt. Thanks and Regards, Ivo > Cheers, > Conor. >